From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 16F92CCA480 for ; Mon, 11 Jul 2022 14:49:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231744AbiGKOtb (ORCPT ); Mon, 11 Jul 2022 10:49:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43640 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231132AbiGKOta (ORCPT ); Mon, 11 Jul 2022 10:49:30 -0400 Received: from mail-ej1-x633.google.com (mail-ej1-x633.google.com [IPv6:2a00:1450:4864:20::633]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E7E19E004 for ; Mon, 11 Jul 2022 07:49:27 -0700 (PDT) Received: by mail-ej1-x633.google.com with SMTP id os14so9249390ejb.4 for ; Mon, 11 Jul 2022 07:49:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=Qi/Ki/anv7OubNnIYr0XldagjTwZd4rr8bwwS58D72Q=; b=i00eQXXaoGMEJ8DA0K3m+dyAuq/QN79dlLyXkKT0TIz/ZmyOiwYTt0VZcO0ewhJQhZ AA/tbadaaWrfDUbVgUgJCEeQMCeW0CfcicCXOeLCeLOnHIuOwa3Oxy/BY8QziGeOIVFa L/ayZc+0aJFBHRTK1hj40zCK6/20zA4tzYW8o= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=Qi/Ki/anv7OubNnIYr0XldagjTwZd4rr8bwwS58D72Q=; b=Jokg8VsfQjWm1/CCDLu730FdMoDA+9aZqqQJYJYMiOkeWNXCMHWVrCAW4SH0F4f+2d M0Gx7vRGvZnVEQouuV90LeoNGykdZ/E26kgoiRQIYROOSzZeGg76H6x1k/CsWVX6QHGx mf6JG+uZdeM7JIOPF5MrC/4I2wUA3IXhpKlUUtKpij3+12cZQvnVEY45kwo6z3FQQH+P tbRgdaIxSg9E2aQKyioOWKbQkwdIvS3aWuk7FoyxKsmzbw5UvDP5aKT5k1A0cPVOzINV i9qodi/JtaOu5TScZjtdIyv+IaChtB4Gf9tCcHBqoOlcktUF29KxkRY8rljZP4su76Vn Raeg== X-Gm-Message-State: AJIora8qdUQEGsimGAvhIi2jdNGmbwrtk9IYdE3E5Gid7uSettuyytyO DDvnqA3PKeWhevtI3jYvmUmcLQ== X-Google-Smtp-Source: AGRyM1vQ+Nre/BUBHCQiULN7frVsOc55Cr98OCiFT+lp3w6feq+ZvbdqZ+CXEheBYDfwFjViIi6Iag== X-Received: by 2002:a17:907:2c68:b0:72b:3a2c:e5b5 with SMTP id ib8-20020a1709072c6800b0072b3a2ce5b5mr12227786ejc.619.1657550965961; Mon, 11 Jul 2022 07:49:25 -0700 (PDT) Received: from tom-ThinkPad-T14s-Gen-2i (net-188-217-59-144.cust.vodafonedsl.it. [188.217.59.144]) by smtp.gmail.com with ESMTPSA id j11-20020a50ed0b000000b0043a6b86f024sm4390379eds.67.2022.07.11.07.49.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 11 Jul 2022 07:49:25 -0700 (PDT) Date: Mon, 11 Jul 2022 16:49:23 +0200 From: Tommaso Merciai To: Jacopo Mondi Cc: linuxfancy@googlegroups.com, linux-amarula@amarulasolutions.com, quentin.schulz@theobroma-systems.com, Krzysztof Kozlowski , Daniel Scally , Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v5 5/6] media: dt-bindings: ov5693: document YAML binding Message-ID: <20220711144923.GB66765@tom-ThinkPad-T14s-Gen-2i> References: <20220630134835.592521-1-tommaso.merciai@amarulasolutions.com> <20220630134835.592521-6-tommaso.merciai@amarulasolutions.com> <20220711093659.mf7i4uqtrejtfong@uno.localdomain> <20220711111108.GA66765@tom-ThinkPad-T14s-Gen-2i> <20220711123629.xcknkluu3wwokoz3@uno.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220711123629.xcknkluu3wwokoz3@uno.localdomain> Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Mon, Jul 11, 2022 at 02:36:29PM +0200, Jacopo Mondi wrote: > Hi Tommaso > > On Mon, Jul 11, 2022 at 01:11:08PM +0200, Tommaso Merciai wrote: > > Hi Jacopo, > > Thanks for your review. > > > > On Mon, Jul 11, 2022 at 11:36:59AM +0200, Jacopo Mondi wrote: > > > Hi Tommaso, Krzysztof, > > > > > > This has been reviewed by Krzysztof already, so I guess it's fine, > > > but let me ask anyway > > > > > > On Thu, Jun 30, 2022 at 03:48:34PM +0200, Tommaso Merciai wrote: > > > > Add documentation of device tree in YAML schema for the OV5693 > > > > CMOS image sensor from Omnivision > > > > > > > > Signed-off-by: Tommaso Merciai > > > > Reviewed-by: Krzysztof Kozlowski > > > > --- > > > > Changes since v1: > > > > - Fix allOf position as suggested by Krzysztof > > > > - Remove port description as suggested by Krzysztof > > > > - Fix EOF as suggested by Krzysztof > > > > > > > > Changes since v2: > > > > - Fix commit body as suggested by Krzysztof > > > > > > > > Changes since v3: > > > > - Add reviewed-by tags, suggested by Jacopo, Krzysztof > > > > > > > > Changes since v4: > > > > - Remove wrong Sakari reviewed-by tag, suggested by Krzysztof, Sakari > > > > > > > > .../bindings/media/i2c/ovti,ov5693.yaml | 106 ++++++++++++++++++ > > > > MAINTAINERS | 1 + > > > > 2 files changed, 107 insertions(+) > > > > create mode 100644 Documentation/devicetree/bindings/media/i2c/ovti,ov5693.yaml > > > > > > > > diff --git a/Documentation/devicetree/bindings/media/i2c/ovti,ov5693.yaml b/Documentation/devicetree/bindings/media/i2c/ovti,ov5693.yaml > > > > new file mode 100644 > > > > index 000000000000..b83c9fc04023 > > > > --- /dev/null > > > > +++ b/Documentation/devicetree/bindings/media/i2c/ovti,ov5693.yaml > > > > @@ -0,0 +1,106 @@ > > > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > > > > +# Copyright (c) 2022 Amarulasolutions > > > > +%YAML 1.2 > > > > +--- > > > > +$id: http://devicetree.org/schemas/media/i2c/ovti,ov5693.yaml# > > > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > > > + > > > > +title: Omnivision OV5693 CMOS Sensor > > > > + > > > > +maintainers: > > > > + - Tommaso Merciai > > > > + > > > > +description: | > > > > + The Omnivision OV5693 is a high performance, 1/4-inch, 5 megapixel, CMOS > > > > + image sensor that delivers 2592x1944 at 30fps. It provides full-frame, > > > > + sub-sampled, and windowed 10-bit MIPI images in various formats via the > > > > + Serial Camera Control Bus (SCCB) interface. > > > > + > > > > + OV5693 is controlled via I2C and two-wire Serial Camera Control Bus (SCCB). > > > > + The sensor output is available via CSI-2 serial data output (up to 2-lane). > > > > + > > > > +allOf: > > > > + - $ref: /schemas/media/video-interface-devices.yaml# > > > > + > > > > +properties: > > > > + compatible: > > > > + const: ovti,ov5693 > > > > + > > > > + reg: > > > > + maxItems: 1 > > > > + > > > > + clocks: > > > > + description: > > > > + System input clock (aka XVCLK). From 6 to 27 MHz. > > > > + maxItems: 1 > > > > + > > > > + dovdd-supply: > > > > + description: > > > > + Digital I/O voltage supply, 1.8V. > > > > + > > > > + avdd-supply: > > > > + description: > > > > + Analog voltage supply, 2.8V. > > > > + > > > > + dvdd-supply: > > > > + description: > > > > + Digital core voltage supply, 1.2V. > > > > + > > > > + reset-gpios: > > > > + description: > > > > + The phandle and specifier for the GPIO that controls sensor reset. > > > > + This corresponds to the hardware pin XSHUTDN which is physically > > > > + active low. > > > > + maxItems: 1 > > > > + > > > > +required: > > > > + - compatible > > > > + - reg > > > > + - clocks > > > > + - dovdd-supply > > > > + - avdd-supply > > > > + - dvdd-supply > > > > > > Should supplies be made mandatory ? Sensors are often powered by fixed > > > rails. Do we want DTS writers to create "fixed-regulators" for all of > > > them ? The fact the regulator framework creates dummies if there's no > > > entry in .dts for a regulator makes me think it's fine to have them > > > optional, but I understand how Linux works should not be an indication > > > of how a bindings should look like. > > > > You are right, this depends on hw design and yes in many cases sensors are > > powered by fixed rails. > > But let me say, I see some design in wich I have to handle these signals and > > in fact are mandatory. > > It's fine if you have to handle them, my question is it if it should > be -mandatory- to specify them > > > > > I check also in others binding's doc like: > > > > - Documentation/devicetree/bindings/media/i2c/ovti,ov5640.yaml > > - Documentation/devicetree/bindings/media/i2c/ovti,ov02a10.yaml > > - Documentation/devicetree/bindings/media/i2c/ovti,ov8865.yaml > > ... > > > > These keep this information. > > > > Anyway, You suggest to drop off: > > > > - dovdd-supply > > - avdd-supply > > - dvdd-supply > > > > From required properties, right? > > Yes, I wonder if they should be required. As usual there's a > bunch of different styles in media/i2c/ and it's not always easy to > distinguish which ones are actually intended from the ones which are > instead the result of copying the existing. Got it. Let me know if we need v6 with your suggestion. Tommaso > > > > > > Tommmaso > > > > > > > > > + - port > > > > + > > > > +unevaluatedProperties: false > > > > + > > > > +examples: > > > > + - | > > > > + #include > > > > + #include > > > > + #include > > > > + > > > > + i2c { > > > > + #address-cells = <1>; > > > > + #size-cells = <0>; > > > > + > > > > + ov5693: camera@36 { > > > > + compatible = "ovti,ov5693"; > > > > + reg = <0x36>; > > > > + > > > > + reset-gpios = <&gpio2 RK_PB1 GPIO_ACTIVE_LOW>; > > > > + pinctrl-names = "default"; > > > > + pinctrl-0 = <&cif_clkout_m0>; > > > > + > > > > + clocks = <&cru SCLK_CIF_OUT>; > > > > + assigned-clocks = <&cru SCLK_CIF_OUT>; > > > > + assigned-clock-rates = <19200000>; > > > > + > > > > + avdd-supply = <&vcc_1v8>; > > > > + dvdd-supply = <&vcc_1v2>; > > > > + dovdd-supply = <&vcc_2v8>; > > > > + > > > > + rotation = <90>; > > > > + orientation = <0>; > > > > + > > > > + port { > > > > + ucam_out: endpoint { > > > > + remote-endpoint = <&mipi_in_ucam>; > > > > + data-lanes = <1 2>; > > > > + link-frequencies = /bits/ 64 <450000000>; > > > > + }; > > > > + }; > > > > + }; > > > > + }; > > > > + > > > > +... > > > > diff --git a/MAINTAINERS b/MAINTAINERS > > > > index 1fc9ead83d2a..844307cb20c4 100644 > > > > --- a/MAINTAINERS > > > > +++ b/MAINTAINERS > > > > @@ -14719,6 +14719,7 @@ M: Daniel Scally > > > > L: linux-media@vger.kernel.org > > > > S: Maintained > > > > T: git git://linuxtv.org/media_tree.git > > > > +F: Documentation/devicetree/bindings/media/i2c/ovti,ov5693.yaml > > > > F: drivers/media/i2c/ov5693.c > > > > > > > > OMNIVISION OV5695 SENSOR DRIVER > > > > -- > > > > 2.25.1 > > > > > > > > -- > > Tommaso Merciai > > Embedded Linux Engineer > > tommaso.merciai@amarulasolutions.com > > __________________________________ > > > > Amarula Solutions SRL > > Via Le Canevare 30, 31100 Treviso, Veneto, IT > > T. +39 042 243 5310 > > info@amarulasolutions.com > > www.amarulasolutions.com -- Tommaso Merciai Embedded Linux Engineer tommaso.merciai@amarulasolutions.com __________________________________ Amarula Solutions SRL Via Le Canevare 30, 31100 Treviso, Veneto, IT T. +39 042 243 5310 info@amarulasolutions.com www.amarulasolutions.com