From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 52616C433EF for ; Tue, 12 Jul 2022 18:06:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233416AbiGLSGo (ORCPT ); Tue, 12 Jul 2022 14:06:44 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36074 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233038AbiGLSGm (ORCPT ); Tue, 12 Jul 2022 14:06:42 -0400 Received: from mail-il1-f177.google.com (mail-il1-f177.google.com [209.85.166.177]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 878DCAE553; Tue, 12 Jul 2022 11:06:36 -0700 (PDT) Received: by mail-il1-f177.google.com with SMTP id a20so5321208ilk.9; Tue, 12 Jul 2022 11:06:36 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=YtzP7I40RQyEUjKbXHB73J4wJHJ46s1Pzo+UKJfysDc=; b=50V9cYcO9thGrAX5MUBBL5TTQfHJW20x4pvbSIrcJuQfwnWNPJEpl14/9aPDo1/yNH 4nu6rTI2EyeJk3jO+SDn+NrbA0pS2m29ieOCzhxbNDqlTObzXDx7o2ulVu8P1aFJjHpU NDQ3WW1dhOnE1Z1Syd5Ic5zylwS0sgrg72aPSdCpa51E+5yKhLsJ2WFUFwi7SjDK8doE i82jl4mb+F0Y1MpvOIt9iy3rk8S5Z90ZCka6SkiinzuRSKaUFA35qQDVnMORLX9tE5eL w1UxstMGv7J1uUJcnEf4HH+jaNtVCdEROYRs/ZBtnNRWaSSVjN/RlP5Q+wrv2DjLMXjB n12Q== X-Gm-Message-State: AJIora8x8LhOYdYYjyDvV15wjZaOWO5O0xEwEmg4hJAX2z6unW1+gLWG k9NIYlD7VVNHX011LAruNA== X-Google-Smtp-Source: AGRyM1uQj9XqR1H/j1xEWpea/Q+tQa2PKHOSbgCLwSEg/z123utZodWxiVGVv4vw8BKVxtlj/J0DYg== X-Received: by 2002:a05:6e02:154d:b0:2dc:6324:e1be with SMTP id j13-20020a056e02154d00b002dc6324e1bemr11287953ilu.47.1657649195773; Tue, 12 Jul 2022 11:06:35 -0700 (PDT) Received: from robh.at.kernel.org ([64.188.179.248]) by smtp.gmail.com with ESMTPSA id cq7-20020a056638478700b0033f21999e6csm4389983jab.90.2022.07.12.11.06.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 Jul 2022 11:06:35 -0700 (PDT) Received: (nullmailer pid 2112717 invoked by uid 1000); Tue, 12 Jul 2022 18:06:32 -0000 Date: Tue, 12 Jul 2022 12:06:32 -0600 From: Rob Herring To: Rex-BC Chen Cc: chunkuang.hu@kernel.org, p.zabel@pengutronix.de, daniel@ffwll.ch, krzysztof.kozlowski+dt@linaro.org, mripard@kernel.org, tzimmermann@suse.de, matthias.bgg@gmail.com, deller@gmx.de, airlied@linux.ie, msp@baylibre.com, granquet@baylibre.com, jitao.shi@mediatek.com, wenst@chromium.org, angelogioacchino.delregno@collabora.com, ck.hu@mediatek.com, liangxu.xu@mediatek.com, dri-devel@lists.freedesktop.org, linux-mediatek@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-fbdev@vger.kernel.org, Project_Global_Chrome_Upstream_Group@mediatek.com Subject: Re: [PATCH v13 01/10] dt-bindings: mediatek,dp: Add Display Port binding Message-ID: <20220712180632.GH1823936-robh@kernel.org> References: <20220701062808.18596-1-rex-bc.chen@mediatek.com> <20220701062808.18596-2-rex-bc.chen@mediatek.com> <20220701202914.GA1457156-robh@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Tue, Jul 05, 2022 at 05:40:27PM +0800, Rex-BC Chen wrote: > On Fri, 2022-07-01 at 14:29 -0600, Rob Herring wrote: > > On Fri, Jul 01, 2022 at 02:27:59PM +0800, Bo-Chen Chen wrote: > > > From: Markus Schneider-Pargmann > > > > > > This controller is present on several mediatek hardware. Currently > > > mt8195 and mt8395 have this controller without a functional > > > difference, > > > so only one compatible field is added. > > > > > > The controller can have two forms, as a normal display port and as > > > an > > > embedded display port. > > > > I'm sure you answered this before, but I'll keep asking until the > > information is contained within this patch. Otherwise, I won't > > remember. > > Is there a h/w difference in the 2 blocks? Different registers? Why > > can't you just look at what the output is connected to? > > > > Hello Rob, > > Thanks for your review. > Yes, it's two different hw for edp and dp and they have different > registers base address. Multiple instances *always* have different base addresses. That's not a difference. I probably asked before on what the difference is between edp and dp variants if anything? If the blocks have some difference then, different compatibles makes sense. But you need to explain the difference or I'll just be asking again... Rob