devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Johan Hovold <johan+linaro@kernel.org>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Felipe Balbi <balbi@kernel.org>,
	Bjorn Andersson <bjorn.andersson@linaro.org>
Cc: Andy Gross <agross@kernel.org>,
	Konrad Dybcio <konrad.dybcio@somainline.org>,
	Wesley Cheng <quic_wcheng@quicinc.com>,
	linux-arm-msm@vger.kernel.org, linux-usb@vger.kernel.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	Johan Hovold <johan+linaro@kernel.org>
Subject: [PATCH 3/7] usb: dwc3: qcom: fix missing optional irq warnings
Date: Wed, 13 Jul 2022 15:13:36 +0200	[thread overview]
Message-ID: <20220713131340.29401-4-johan+linaro@kernel.org> (raw)
In-Reply-To: <20220713131340.29401-1-johan+linaro@kernel.org>

Not all platforms have all of the four currently supported wakeup
interrupts so use the optional irq helpers when looking up interrupts to
avoid printing error messages when an optional interrupt is not found:

	dwc3-qcom a6f8800.usb: error -ENXIO: IRQ hs_phy_irq not found

Fixes: a4333c3a6ba9 ("usb: dwc3: Add Qualcomm DWC3 glue driver")
Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
---
 drivers/usb/dwc3/dwc3-qcom.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/usb/dwc3/dwc3-qcom.c b/drivers/usb/dwc3/dwc3-qcom.c
index 77036551987a..c5e482f53e9d 100644
--- a/drivers/usb/dwc3/dwc3-qcom.c
+++ b/drivers/usb/dwc3/dwc3-qcom.c
@@ -490,9 +490,9 @@ static int dwc3_qcom_get_irq(struct platform_device *pdev,
 	int ret;
 
 	if (np)
-		ret = platform_get_irq_byname(pdev_irq, name);
+		ret = platform_get_irq_byname_optional(pdev_irq, name);
 	else
-		ret = platform_get_irq(pdev_irq, num);
+		ret = platform_get_irq_optional(pdev_irq, num);
 
 	return ret;
 }
-- 
2.35.1


  parent reply	other threads:[~2022-07-13 13:18 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-13 13:13 [PATCH 0/7] usb: dwc3: add support for SC8280XP Johan Hovold
2022-07-13 13:13 ` [PATCH 1/7] dt-bindings: usb: qcom,dwc3: add SC8280XP binding Johan Hovold
2022-07-14 10:48   ` Krzysztof Kozlowski
2022-07-14 10:51   ` Krzysztof Kozlowski
2022-07-13 13:13 ` [PATCH 2/7] dt-bindings: usb: qcom,dwc3: refine interrupt requirements Johan Hovold
2022-07-14 10:50   ` Krzysztof Kozlowski
2022-07-13 13:13 ` Johan Hovold [this message]
2022-07-13 14:00   ` [PATCH 3/7] usb: dwc3: qcom: fix missing optional irq warnings Andrew Halaney
2022-07-13 13:13 ` [PATCH 4/7] arm64: dts: qcom: sc8280xp: fix USB clock order Johan Hovold
2022-07-14 10:52   ` Krzysztof Kozlowski
2022-07-13 13:13 ` [PATCH 5/7] arm64: dts: qcom: sc8280xp: fix USB interrupts Johan Hovold
2022-07-13 14:12   ` Andrew Halaney
2022-07-13 14:35     ` Johan Hovold
2022-07-13 14:43       ` Andrew Halaney
2022-07-13 15:03         ` Johan Hovold
2022-07-14 10:52   ` Krzysztof Kozlowski
2022-07-13 13:13 ` [PATCH 6/7] arm64: dts: qcom: sc7280: reorder " Johan Hovold
2022-07-14 10:54   ` Krzysztof Kozlowski
2022-07-13 13:13 ` [PATCH 7/7] arm64: dts: qcom: " Johan Hovold
2022-07-14 10:54   ` Krzysztof Kozlowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220713131340.29401-4-johan+linaro@kernel.org \
    --to=johan+linaro@kernel.org \
    --cc=agross@kernel.org \
    --cc=balbi@kernel.org \
    --cc=bjorn.andersson@linaro.org \
    --cc=devicetree@vger.kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=konrad.dybcio@somainline.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=quic_wcheng@quicinc.com \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).