From: Rob Herring <robh@kernel.org>
To: Raphael-Xu <13691752556@139.com>
Cc: alsa-devel@alsa-project.org, raphael-xu@ti.com,
shenghao-ding@ti.com, navada@ti.com, asyrus@ti.com,
broonie@kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v5] update tas2780.yaml
Date: Wed, 13 Jul 2022 08:51:30 -0600 [thread overview]
Message-ID: <20220713145130.GA3909157-robh@kernel.org> (raw)
In-Reply-To: <20220712050857.267-1-13691752556@139.com>
On Tue, Jul 12, 2022 at 01:08:57PM +0800, Raphael-Xu wrote:
> 1.remove unused item in DT 2.revise the format
Again, fix your subject. Run 'git log --oneline
Documentation/devicetree/bindings/sound/' for inspiration of the format
of the subject.
However, there's a bigger issue here. We already have a binding for this
device. It's in tas27xx.yaml. And you added 2780 to it, so why did you
add another schema? (All the same issues in that patch too. wrong
subject, broken schema. So you haven't learned.)
And then there is also tas2770.yaml which appears to be about the same
as well.
>
> Signed-off-by: Raphael-Xu <13691752556@139.com>
> ---
> .../devicetree/bindings/sound/tas2780.yaml | 19 +++++++++++--------
> 1 file changed, 11 insertions(+), 8 deletions(-)
next prev parent reply other threads:[~2022-07-13 14:51 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-12 5:08 [PATCH v5] update tas2780.yaml Raphael-Xu
2022-07-13 14:51 ` Rob Herring [this message]
2022-07-20 3:48 ` [EXTERNAL] " Xu, Yang
2022-07-20 5:43 ` Xu, Yang
2022-07-20 23:02 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220713145130.GA3909157-robh@kernel.org \
--to=robh@kernel.org \
--cc=13691752556@139.com \
--cc=alsa-devel@alsa-project.org \
--cc=asyrus@ti.com \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=navada@ti.com \
--cc=raphael-xu@ti.com \
--cc=shenghao-ding@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).