From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BC762C433EF for ; Wed, 13 Jul 2022 15:13:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236826AbiGMPNP (ORCPT ); Wed, 13 Jul 2022 11:13:15 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49652 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236797AbiGMPNN (ORCPT ); Wed, 13 Jul 2022 11:13:13 -0400 Received: from mail-pj1-x102c.google.com (mail-pj1-x102c.google.com [IPv6:2607:f8b0:4864:20::102c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8C48E45F4A for ; Wed, 13 Jul 2022 08:13:11 -0700 (PDT) Received: by mail-pj1-x102c.google.com with SMTP id y14-20020a17090a644e00b001ef775f7118so4187312pjm.2 for ; Wed, 13 Jul 2022 08:13:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=nHna6q8haXF012wFoVlU3mi09UNcmJSRQ4P1JKT5xOg=; b=CXc23FklogJD5om5a2d6XqaWm8drlrQjWI+VzShzntPDCJYUU/32ANHo0nlRqD/jce RsVnYDQg8oJCKAAMA5wvHkXAT4kSRxWjsFidkXSQdduRRwqYTgtWE/BgrmuW2b9a66VE PfGbD6jFAsn90/GhjrmzFQrgv/wMn3kNFPmMJkNpvpXBgUSg6ZdaTlj/aGrMCn24ZdVm 4dY9YAHKqMfCQN0B0rEBNOFHDY/MoUYWDiugzIrOPgCSdbDK5LissQcyCrAD4iElyeMb QFCYzDzxooZz/gGb3auvrS5VIEVtlR3RJkw+s6T+m2CjYrn666JNzP2kQcGPVHFclhF2 s2Gw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=nHna6q8haXF012wFoVlU3mi09UNcmJSRQ4P1JKT5xOg=; b=PvVFXZPhOGAOyOCvyCTDsRMilOehqA9c/102C6sPlwJznohTx6zRb9LPvXICXOiY3S H4UlYhCSy1p4TLaf3eCNNczQ+bLDOXCgH/r8Y3ZMo38Br1doRgFqZ5MAlzqawclLVlnv x0FYMLd9aJvVLE9F+zM5qcn9FRTOt4A4pVQC5bE8//wrr6Q3788D5zBwnUoEY/1Ou01Y ilLY7gltAMYt2Tbx8T7a5ylTveBDLBCUb5bk2BY9+Ti7vBJSFEPbMOKnh74cqdRx+WCN e+UJCGdz7HASbOyLmaRuEZlUFVrieCQGV7PK8r56WWc1fnOxelXFDqcs5GTrUfWXC5bC BApw== X-Gm-Message-State: AJIora9XydnH6LvlCEo63mqWeH467Gol8F3BIuHWU4Sq/B1+8vuMbsi6 BPlSZzdoyKLYAT77i315PhIv X-Google-Smtp-Source: AGRyM1vOlU7utJFqv9U8LPiuqQgbEgKciktWFPD48RHUaXgen/iU/qGci5ug+URJIdPFy938rKFaxA== X-Received: by 2002:a17:90a:b398:b0:1ef:7e67:6 with SMTP id e24-20020a17090ab39800b001ef7e670006mr10416045pjr.123.1657725191006; Wed, 13 Jul 2022 08:13:11 -0700 (PDT) Received: from workstation ([117.248.1.226]) by smtp.gmail.com with ESMTPSA id w185-20020a6362c2000000b0041292b732fdsm8138159pgb.38.2022.07.13.08.13.08 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Wed, 13 Jul 2022 08:13:10 -0700 (PDT) Date: Wed, 13 Jul 2022 20:43:05 +0530 From: Manivannan Sadhasivam To: Johan Hovold Cc: bjorn.andersson@linaro.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Johan Hovold , Steve Capper Subject: Re: [PATCH] arm64: dts: qcom: sc8280xp: Fix PMU interrupt Message-ID: <20220713151305.GA4591@workstation> References: <20220713143429.22624-1-manivannan.sadhasivam@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Wed, Jul 13, 2022 at 04:55:12PM +0200, Johan Hovold wrote: > On Wed, Jul 13, 2022 at 08:04:29PM +0530, Manivannan Sadhasivam wrote: > > PPI interrupt should be 7 for the PMU. > > > > Cc: Johan Hovold > > Fixes: 152d1faf1e2f ("arm64: dts: qcom: add SC8280XP platform") > > Reported-by: Steve Capper > > Signed-off-by: Manivannan Sadhasivam > > --- > > arch/arm64/boot/dts/qcom/sc8280xp.dtsi | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/arch/arm64/boot/dts/qcom/sc8280xp.dtsi b/arch/arm64/boot/dts/qcom/sc8280xp.dtsi > > index 268ab423577a..2d7823cb783c 100644 > > --- a/arch/arm64/boot/dts/qcom/sc8280xp.dtsi > > +++ b/arch/arm64/boot/dts/qcom/sc8280xp.dtsi > > @@ -477,7 +477,7 @@ memory@80000000 { > > > > pmu { > > compatible = "arm,armv8-pmuv3"; > > - interrupts = ; > > + interrupts = ; > > }; > > > > psci { > > The interrupt number matches the vendor devicetree I have access to, but > the vendor source also has IRQ_TYPE_LEVEL_LOW instead of > IRQ_TYPE_LEVEL_HIGH here. > > Is that another copy-paste error, perhaps? > I don't have access to the documentation of this SoC now but since Steve tried with IRQ_TYPE_LEVEL_HIGH and it worked for him, I think it is best to leave it as it is. Thanks, Mani > Johan