devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Johan Hovold <johan+linaro@kernel.org>
To: Bjorn Helgaas <bhelgaas@google.com>,
	Stanimir Varbanov <svarbanov@mm-sol.com>,
	Lorenzo Pieralisi <lpieralisi@kernel.org>
Cc: "Rob Herring" <robh+dt@kernel.org>,
	"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
	"Andy Gross" <agross@kernel.org>,
	"Bjorn Andersson" <bjorn.andersson@linaro.org>,
	"Konrad Dybcio" <konrad.dybcio@somainline.org>,
	"Krzysztof Wilczyński" <kw@linux.com>,
	"Dmitry Baryshkov" <dmitry.baryshkov@linaro.org>,
	"Manivannan Sadhasivam" <manivannan.sadhasivam@linaro.org>,
	linux-arm-msm@vger.kernel.org, linux-pci@vger.kernel.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	"Johan Hovold" <johan+linaro@kernel.org>
Subject: [PATCH v2 1/8] dt-bindings: PCI: qcom: Enumerate platforms with single msi interrupt
Date: Thu, 14 Jul 2022 09:13:41 +0200	[thread overview]
Message-ID: <20220714071348.6792-2-johan+linaro@kernel.org> (raw)
In-Reply-To: <20220714071348.6792-1-johan+linaro@kernel.org>

Explicitly enumerate the older platforms that have a single msi host
interrupt. This allows for adding further platforms with, for example,
four msi interrupts without resorting to nested conditionals.

Drop the redundant comment about older chipsets instead of moving it.

Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
---
 .../devicetree/bindings/pci/qcom,pcie.yaml      | 17 +++++++++++++++--
 1 file changed, 15 insertions(+), 2 deletions(-)

diff --git a/Documentation/devicetree/bindings/pci/qcom,pcie.yaml b/Documentation/devicetree/bindings/pci/qcom,pcie.yaml
index 70984037df73..8142c891f18b 100644
--- a/Documentation/devicetree/bindings/pci/qcom,pcie.yaml
+++ b/Documentation/devicetree/bindings/pci/qcom,pcie.yaml
@@ -625,7 +625,6 @@ allOf:
         - reset-names
 
     # On newer chipsets support either 1 or 8 msi interrupts
-    # On older chipsets it's always 1 msi interrupt
   - if:
       properties:
         compatible:
@@ -660,7 +659,21 @@ allOf:
                 - const: msi5
                 - const: msi6
                 - const: msi7
-    else:
+
+  - if:
+      properties:
+        compatible:
+          contains:
+            enum:
+              - qcom,pcie-apq8064
+              - qcom,pcie-apq8084
+              - qcom,pcie-ipq4019
+              - qcom,pcie-ipq6018
+              - qcom,pcie-ipq8064
+              - qcom,pcie-ipq8064-v2
+              - qcom,pcie-ipq8074
+              - qcom,pcie-qcs404
+    then:
       properties:
         interrupts:
           maxItems: 1
-- 
2.35.1


  reply	other threads:[~2022-07-14  7:14 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-14  7:13 [PATCH v2 0/8] PCI: qcom: Add support for SC8280XP and SA8540P Johan Hovold
2022-07-14  7:13 ` Johan Hovold [this message]
2022-07-14 10:44   ` [PATCH v2 1/8] dt-bindings: PCI: qcom: Enumerate platforms with single msi interrupt Krzysztof Kozlowski
2022-07-14  7:13 ` [PATCH v2 2/8] dt-bindings: PCI: qcom: Add SC8280XP to binding Johan Hovold
2022-07-14  7:13 ` [PATCH v2 3/8] dt-bindings: PCI: qcom: Add SA8540P " Johan Hovold
2022-07-14 14:29   ` Brian Masney
2022-07-14  7:13 ` [PATCH v2 4/8] PCI: qcom: Add support for SC8280XP Johan Hovold
2022-07-14  7:13 ` [PATCH v2 5/8] PCI: qcom: Add support for SA8540P Johan Hovold
2022-07-14 14:30   ` Brian Masney
2022-07-14  7:13 ` [PATCH v2 6/8] PCI: qcom: Make all optional clocks optional Johan Hovold
2022-07-14 14:31   ` Brian Masney
2022-07-18 10:37   ` Dmitry Baryshkov
2022-07-14  7:13 ` [PATCH v2 7/8] PCI: qcom: Clean up IP configurations Johan Hovold
2022-07-14 14:42   ` Brian Masney
2022-07-18 10:39   ` Dmitry Baryshkov
2022-07-18 12:00     ` Johan Hovold
2022-07-14  7:13 ` [PATCH v2 8/8] PCI: qcom: Sort device-id table Johan Hovold
2022-07-14 14:27   ` Brian Masney
2022-07-15  7:43     ` Johan Hovold
2022-07-15  9:26       ` Brian Masney
2022-08-16 16:06       ` Lorenzo Pieralisi
2022-08-18 20:05         ` Andrew Halaney
2022-08-19  7:46           ` Lorenzo Pieralisi
2022-08-22 12:45             ` Johan Hovold
2022-07-15 22:37 ` [PATCH v2 0/8] PCI: qcom: Add support for SC8280XP and SA8540P Bjorn Helgaas
2022-07-18 10:16   ` Johan Hovold
2022-07-18  7:49 ` Stanimir Varbanov
2022-07-18 10:18   ` Johan Hovold
2022-07-18 10:51     ` Johan Hovold
2022-08-19  8:40 ` Lorenzo Pieralisi
2022-08-22 12:52   ` Johan Hovold

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220714071348.6792-2-johan+linaro@kernel.org \
    --to=johan+linaro@kernel.org \
    --cc=agross@kernel.org \
    --cc=bhelgaas@google.com \
    --cc=bjorn.andersson@linaro.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dmitry.baryshkov@linaro.org \
    --cc=konrad.dybcio@somainline.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=kw@linux.com \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=lpieralisi@kernel.org \
    --cc=manivannan.sadhasivam@linaro.org \
    --cc=robh+dt@kernel.org \
    --cc=svarbanov@mm-sol.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).