Re: [PATCH v2 4/4] pcie: endpoint: pci-epf-vntb: add endpoint msi support

[Bjorn Helgaas <helgaas@kernel.org>]

[+to Jon, since I guess he will apply or at least review this, not me]

On Fri, Jul 15, 2022 at 02:22:19PM -0500, Frank Li wrote:
> This patch add msi support for ntb endpoint(EP) side.
> EP side driver query if system have msi controller.
> Setup doorbell address according to struct msi_msg.
> 
> So PCIe host can write this doorbell address to EP
> side's irq.
> 
> If no msi controller exist, failback software polling.

s/This patch add/Add/
s/msi/MSI/ (several)
s/ntb/NTB/
s/irq/IRQ/
s/failback/fall back to/

Rewrap commit log to fill 75 columns to make it easier to read.

> +static int epf_ntb_db_size(struct epf_ntb *ntb)
> +{
> +	const struct pci_epc_features *epc_features;
> +	size_t	size = 4 * ntb->db_count;
> +	u32	align;

Replace tabs with spaces in these declarations , since that's what
code below does, e.g., in epf_ntb_db_bar_init(), etc.

> +		dev_info(dev, "Can't allocate MSI, failure back to poll mode\n");

s/failure/fall/

> +		return;
> +	}
> +
> +	dev_info(dev, "vntb use MSI as doorbell\n");

> +		ret = devm_request_irq(dev, virq,
> +			       epf_ntb_interrupt_handler, 0,
> +			       "ntb", ntb);
> +
> +		if (ret)
> +			dev_err(dev, "request irq failure\n");

s/irq/IRQ/ (or spell out "devm_request_irq()").

Capitalize all messages or none of them.  Match the prevailing style
of the file.