From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0E2C4C433EF for ; Sat, 16 Jul 2022 14:50:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229745AbiGPOu3 (ORCPT ); Sat, 16 Jul 2022 10:50:29 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52664 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229473AbiGPOu2 (ORCPT ); Sat, 16 Jul 2022 10:50:28 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 17869F3F; Sat, 16 Jul 2022 07:50:25 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id B5C1BB80A08; Sat, 16 Jul 2022 14:50:23 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 46922C34114; Sat, 16 Jul 2022 14:50:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1657983022; bh=NGGWpUHcEC9+bYxY+zgYgLByRAr/mR69cowRWdBo/0I=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=SO2Xky1+d9rereWiZRoQQudL02luIZhodAJF+jW6YFdJIPdSkpg1eIwpVOu53J8hm M1ZQpebdnZpYmxne4bwBKAuogNhD2zDLh5y8MDc0ZtPjo8H18r0IbFLST3c6LbNtnD DGsshF5MmPEMHrm4BS0YEeC7OQjjYv47riVF7bZP23pgQ4wj7TNVbdoI62yDNgNwyJ D8Z908VwuDCkZ7IxBaODUPTUDDddQQ4PRQwS2OQgqH5t+cpiI+DXeh3geZpwILhF2y PyiziJoMtdmnf6+qCAduXmQOuRKt9yBWTnyEc9vJfiwIWiaiJ74o2kRHUXo6dIBgd5 IpzYuVD1UG1Iw== Received: by pali.im (Postfix) id 30724A52; Sat, 16 Jul 2022 16:50:19 +0200 (CEST) Date: Sat, 16 Jul 2022 16:50:19 +0200 From: Pali =?utf-8?B?Um9ow6Fy?= To: Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= Cc: Thierry Reding , Lee Jones , Linus Walleij , Bartosz Golaszewski , Rob Herring , Krzysztof Kozlowski , Andrew Lunn , Gregory Clement , Sebastian Hesselbarth , Marek =?utf-8?B?QmVow7pu?= , linux-pwm@vger.kernel.org, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v2 3/4] ARM: dts: armada-38x: Fix compatible string for gpios Message-ID: <20220716145019.nps3oh4a22fsuzup@pali> References: <20220714115515.5748-1-pali@kernel.org> <20220714183328.4137-1-pali@kernel.org> <20220714183328.4137-3-pali@kernel.org> <20220716144028.rzwcn4wl5uyxepjd@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20220716144028.rzwcn4wl5uyxepjd@pengutronix.de> User-Agent: NeoMutt/20180716 Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Saturday 16 July 2022 16:40:28 Uwe Kleine-König wrote: > On Thu, Jul 14, 2022 at 08:33:27PM +0200, Pali Rohár wrote: > > Armada 38x supports per CPU interrupts for gpios, like Armada XP. Pre-XP > > variants like Armada 370 do not support per CPU interrupts for gpios. > > > > So change compatible string for Armada 38x from "marvell,armada-370-gpio" > > which indicates pre-XP variant to "marvell,armadaxp-gpio" which indicates > > XP variant or new. > > > > Driver gpio-mvebu.c which handles both pre-XP and XP variants already > > provides support for per CPU interrupts on XP and newer variants. > > > > Signed-off-by: Pali Rohár > > Fixes: 7cb2acb3fbae ("ARM: dts: mvebu: Add PWM properties for armada-38x") > > --- > > arch/arm/boot/dts/armada-38x.dtsi | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/arch/arm/boot/dts/armada-38x.dtsi b/arch/arm/boot/dts/armada-38x.dtsi > > index df3c8d1d8f64..9343de6947b3 100644 > > --- a/arch/arm/boot/dts/armada-38x.dtsi > > +++ b/arch/arm/boot/dts/armada-38x.dtsi > > @@ -292,7 +292,7 @@ > > }; > > > > gpio0: gpio@18100 { > > - compatible = "marvell,armada-370-gpio", > > + compatible = "marvell,armadaxp-gpio", > > "marvell,orion-gpio"; > > If you can treat the XP variant as 370 and everything that is supposed > to work on 370 works then, then maybe the right incarnation is: > > compatible = "marvell,armadaxp-gpio", "marvell,armada-370-gpio", "marvell,orion-gpio"; > > ? For pre-XP variants is "marvell,orion-gpio" enough and for XP + post-XP is needed "marvell,armadaxp-gpio" (with possible "marvell,orion-gpio" for backward compatibility). So I do not see reason why to add "marvell,armada-370-gpio" nor what value it brings. > Best regards > Uwe > > -- > Pengutronix e.K. | Uwe Kleine-König | > Industrial Linux Solutions | https://www.pengutronix.de/ |