devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jonathan Cameron <jic23@kernel.org>
To: Alexander Stein <alexander.stein@ew.tq-group.com>,
	linux-imx@nxp.com, linux-iio@vger.kernel.org
Cc: Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Lars-Peter Clausen <lars@metafoo.de>,
	Haibo Chen <haibo.chen@nxp.com>,
	devicetree@vger.kernel.org
Subject: Re: [PATCH] dt-bindings: iio: adc: Add imx6ul & imx6sx compatibles
Date: Sat, 16 Jul 2022 15:52:43 +0100	[thread overview]
Message-ID: <20220716155243.4b1c8ba9@jic23-huawei> (raw)
In-Reply-To: <8090017.T7Z3S40VBb@steina-w>

On Fri, 15 Jul 2022 09:56:45 +0200
Alexander Stein <alexander.stein@ew.tq-group.com> wrote:

> Am Dienstag, 28. Juni 2022, 23:09:19 CEST schrieb Rob Herring:
> > On Mon, Jun 20, 2022 at 10:12:44AM +0200, Alexander Stein wrote:  
> > > Hello,
> > > 
> > > Am Samstag, 18. Juni 2022, 19:01:29 CEST schrieb Jonathan Cameron:  
> > > > On Fri, 17 Jun 2022 16:44:48 -0600
> > > > 
> > > > Rob Herring <robh@kernel.org> wrote:  
> > > > > On Mon, Jun 13, 2022 at 11:34:46AM -0600, Rob Herring wrote:  
> > > > > > On Mon, 13 Jun 2022 14:35:29 +0200, Alexander Stein wrote:  
> > > > > > > Both are already using the vf610 compatible.
> > > > > > > 
> > > > > > > Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
> > > > > > > ---
> > > > > > > 
> > > > > > >  .../devicetree/bindings/iio/adc/fsl,vf610-adc.yaml       | 9
> > > > > > >  ++++++++-
> > > > > > >  1 file changed, 8 insertions(+), 1 deletion(-)  
> > > > > > 
> > > > > > Running 'make dtbs_check' with the schema in this patch gives the
> > > > > > following warnings. Consider if they are expected or the schema is
> > > > > > incorrect. These may not be new warnings.
> > > > > > 
> > > > > > Note that it is not yet a requirement to have 0 warnings for
> > > > > > dtbs_check.
> > > > > > This will change in the future.
> > > > > > 
> > > > > > Full log is available here: https://patchwork.ozlabs.org/patch/
> > > > > > 
> > > > > > 
> > > > > > adc@2198000: 'num-channels' does not match any of the regexes:
> > > > > > 'pinctrl-[0-9]+'>  
> > > > > 
> > > > > Looks like you need to add 'num-channels'?  
> > > > 
> > > > or a lot of wrong dtbs :)
> > > > 
> > > > By which I mean ones providing a property that may or may not be
> > > > actually
> > > > used by any drivers...  
> > > 
> > > This got already fixed by Baruch's patch which is currently in Shawn's
> > > imx-
> > > fixes-5.19 branch at [1]  
> > 
> > Great!
> > 
> > Reviewed-by: Rob Herring <robh@kernel.org>  
> 
> Did this got missed? Or is it applied somwhere I' not aware of?
Missed it.  Thanks for pointing it out!

Applied to the togreg branch of iio.git and pushed out initially as testing
for 0-day to poke at it.  Note this may well not make this cycle now unfortunately
given the timing.

Thanks,

Jonathan

> 
> Best regards,
> Alexander
> 
> 
> 


      reply	other threads:[~2022-07-16 14:42 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-13 12:35 [PATCH] dt-bindings: iio: adc: Add imx6ul & imx6sx compatibles Alexander Stein
2022-06-13 17:34 ` Rob Herring
2022-06-17 22:44   ` Rob Herring
2022-06-18 17:01     ` Jonathan Cameron
2022-06-20  8:12       ` (EXT) " Alexander Stein
2022-06-28 21:09         ` Rob Herring
2022-07-15  7:56           ` Alexander Stein
2022-07-16 14:52             ` Jonathan Cameron [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220716155243.4b1c8ba9@jic23-huawei \
    --to=jic23@kernel.org \
    --cc=alexander.stein@ew.tq-group.com \
    --cc=devicetree@vger.kernel.org \
    --cc=haibo.chen@nxp.com \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=lars@metafoo.de \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-imx@nxp.com \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).