From: Sebastian Reichel <sebastian.reichel@collabora.com>
To: Anjelique Melendez <quic_amelende@quicinc.com>
Cc: corbet@lwn.net, robh+dt@kernel.org, agross@kernel.org,
bjorn.andersson@linaro.org, krzysztof.kozlowski+dt@linaro.org,
vkoul@kernel.org, linux-doc@vger.kernel.org,
linux-pm@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 2/2] power: reset: qcom-pon: add support for qcom,pmk8350-pon compatible string
Date: Sat, 16 Jul 2022 23:58:03 +0200 [thread overview]
Message-ID: <20220716215803.r3ldaswyhehfpcip@mercury.elektranox.org> (raw)
In-Reply-To: <20220713193350.29796-3-quic_amelende@quicinc.com>
[-- Attachment #1: Type: text/plain, Size: 1054 bytes --]
Hi,
On Wed, Jul 13, 2022 at 12:33:51PM -0700, Anjelique Melendez wrote:
> Add support for the new "qcom,pmk8350-pon" comptaible string.
>
> Signed-off-by: Anjelique Melendez <quic_amelende@quicinc.com>
> ---
> drivers/power/reset/qcom-pon.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/power/reset/qcom-pon.c b/drivers/power/reset/qcom-pon.c
> index 4a688741a88a..16bc01738be9 100644
> --- a/drivers/power/reset/qcom-pon.c
> +++ b/drivers/power/reset/qcom-pon.c
> @@ -82,6 +82,7 @@ static const struct of_device_id pm8916_pon_id_table[] = {
> { .compatible = "qcom,pm8916-pon", .data = (void *)GEN1_REASON_SHIFT },
> { .compatible = "qcom,pms405-pon", .data = (void *)GEN1_REASON_SHIFT },
> { .compatible = "qcom,pm8998-pon", .data = (void *)GEN2_REASON_SHIFT },
> + { .compatible = "qcom,pmk8350-pon", .data = (void *)GEN2_REASON_SHIFT },
> { }
> };
> MODULE_DEVICE_TABLE(of, pm8916_pon_id_table);
No handling of the second register? Why is it needed in DT in the
first place?
-- Sebastian
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2022-07-16 21:58 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-13 19:33 [PATCH v3 0/2] add support for PON GEN3 device Anjelique Melendez
2022-07-13 19:33 ` [PATCH v3 1/2] dt-bindings: power: reset: qcom-pon: update "reg" property details Anjelique Melendez
2022-07-14 11:48 ` Krzysztof Kozlowski
2022-07-18 19:57 ` Anjelique Melendez
2022-07-18 20:56 ` Rob Herring
2022-07-13 19:33 ` [PATCH v3 2/2] power: reset: qcom-pon: add support for qcom,pmk8350-pon compatible string Anjelique Melendez
2022-07-16 21:58 ` Sebastian Reichel [this message]
2022-07-18 19:48 ` Anjelique Melendez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220716215803.r3ldaswyhehfpcip@mercury.elektranox.org \
--to=sebastian.reichel@collabora.com \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=corbet@lwn.net \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=quic_amelende@quicinc.com \
--cc=robh+dt@kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).