Re: [PATCH 3/3] usb: typec: tcpci_rt1711h: Add compatible with rt1715

[kernel test robot <lkp@intel.com>]

Hi Gene,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on v5.19-rc6]
[also build test WARNING on linus/master]
[cannot apply to usb/usb-testing next-20220715]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Gene-Chen/usb-typec-tcpci_rt1711h-Add-compatible-with-rt1715/20220717-003638
base:    32346491ddf24599decca06190ebca03ff9de7f8
config: i386-allyesconfig (https://download.01.org/0day-ci/archive/20220717/202207170406.z3r8vDPb-lkp@intel.com/config)
compiler: gcc-11 (Debian 11.3.0-3) 11.3.0
reproduce (this is a W=1 build):
        # https://github.com/intel-lab-lkp/linux/commit/694b38f034326c96d5211fc2da10a25f4938cc3b
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Gene-Chen/usb-typec-tcpci_rt1711h-Add-compatible-with-rt1715/20220717-003638
        git checkout 694b38f034326c96d5211fc2da10a25f4938cc3b
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        make W=1 O=build_dir ARCH=i386 SHELL=/bin/bash drivers/usb/typec/tcpm/

If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

   drivers/usb/typec/tcpm/tcpci_rt1711h.c: In function 'rt1711h_init_cc_params':
>> drivers/usb/typec/tcpm/tcpci_rt1711h.c:181:26: warning: variable 'rxdz_sel' set but not used [-Wunused-but-set-variable]
     181 |         u32 rxdz_en = 0, rxdz_sel = 0;
         |                          ^~~~~~~~


vim +/rxdz_sel +181 drivers/usb/typec/tcpm/tcpci_rt1711h.c

   170	
   171	/*
   172	 * Selects the CC PHY noise filter voltage level according to the current
   173	 * CC voltage level.
   174	 *
   175	 * @param cc_level The CC voltage level for the port's current role
   176	 * @return EC_SUCCESS if writes succeed; failure code otherwise
   177	 */
   178	static inline int rt1711h_init_cc_params(struct rt1711h_chip *chip,
   179		enum typec_cc_status cc1, enum typec_cc_status cc2)
   180	{
 > 181		u32 rxdz_en = 0, rxdz_sel = 0;
   182		int ret;
   183	
   184		if ((cc1 >= TYPEC_CC_RP_1_5 && cc2 < TYPEC_CC_RP_DEF) ||
   185		    (cc2 >= TYPEC_CC_RP_1_5 && cc1 < TYPEC_CC_RP_DEF)) {
   186			if (chip->did == RT1715_DID) {
   187				rxdz_en = 1;
   188				rxdz_sel = 1;
   189			} else {
   190				rxdz_en = 1;
   191				rxdz_sel = 0;
   192			}
   193		} else {
   194			rxdz_en = 0;
   195			rxdz_sel = 1;
   196		}
   197	
   198		ret = regmap_update_bits(chip->data.regmap, RT1711H_RTCTRL18,
   199					 BMCIO_RXDZEN_MASK, rxdz_en);
   200		if (ret < 0)
   201			return ret;
   202	
   203		return regmap_update_bits(chip->data.regmap, RT1711H_RTCTRL4,
   204					  RT1711H_BMCIO_RXDZSEL, rxdz_en);
   205	}
   206	

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp