From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9069BC433EF for ; Mon, 18 Jul 2022 05:37:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233295AbiGRFhp (ORCPT ); Mon, 18 Jul 2022 01:37:45 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48648 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233074AbiGRFhn (ORCPT ); Mon, 18 Jul 2022 01:37:43 -0400 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 096F313DDE for ; Sun, 17 Jul 2022 22:37:39 -0700 (PDT) Received: from ptx.hi.pengutronix.de ([2001:67c:670:100:1d::c0]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oDJRb-0001j5-RG; Mon, 18 Jul 2022 07:37:23 +0200 Received: from sha by ptx.hi.pengutronix.de with local (Exim 4.92) (envelope-from ) id 1oDJRZ-0006zq-WD; Mon, 18 Jul 2022 07:37:22 +0200 Date: Mon, 18 Jul 2022 07:37:21 +0200 From: Sascha Hauer To: Adam Ford Cc: linux-arm-kernel@lists.infradead.org, Rob Herring , Krzysztof Kozlowski , Shawn Guo , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Catalin Marinas , Will Deacon , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 4/6] arm64: dts: imx8mm-beacon: Enable Digitial Microphone Message-ID: <20220718053721.GB7333@pengutronix.de> References: <20220717181000.1186373-1-aford173@gmail.com> <20220717181000.1186373-5-aford173@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220717181000.1186373-5-aford173@gmail.com> X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-Accept-Language: de,en X-Accept-Content-Type: text/plain User-Agent: Mutt/1.10.1 (2018-07-13) X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::c0 X-SA-Exim-Mail-From: sha@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: devicetree@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hi Adam, On Sun, Jul 17, 2022 at 01:09:58PM -0500, Adam Ford wrote: > There is a PDM microphone port on the baseboard which is connected to the > micfil controller. Create a new sound card to support this interface. > > Signed-off-by: Adam Ford > > diff --git a/arch/arm64/boot/dts/freescale/imx8mm-beacon-baseboard.dtsi b/arch/arm64/boot/dts/freescale/imx8mm-beacon-baseboard.dtsi > index 03266bd90a06..16444954f873 100644 > --- a/arch/arm64/boot/dts/freescale/imx8mm-beacon-baseboard.dtsi > +++ b/arch/arm64/boot/dts/freescale/imx8mm-beacon-baseboard.dtsi > @@ -98,7 +98,7 @@ reg_usdhc2_vmmc: regulator-usdhc2 { > enable-active-high; > }; > > - sound { > + sound-codec { > compatible = "fsl,imx-audio-wm8962"; > model = "wm8962-audio"; > audio-cpu = <&sai3>; > @@ -111,6 +111,18 @@ sound { > "AMIC", "MICBIAS", > "IN3R", "AMIC"; > }; > + > + sound-micfil { > + compatible = "fsl,imx-audio-card"; > + model = "imx-audio-micfil"; > + pri-dai-link { > + link-name = "micfil hifi"; > + format = "i2s"; > + cpu { > + sound-dai = <&micfil>; > + }; > + }; > + }; Note the micfil works well with the simple-audio-card driver which might be an alternative here. Sascha -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |