From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3369FCCA479 for ; Mon, 18 Jul 2022 07:50:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233216AbiGRHuA (ORCPT ); Mon, 18 Jul 2022 03:50:00 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40356 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229815AbiGRHuA (ORCPT ); Mon, 18 Jul 2022 03:50:00 -0400 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 86A3D18376 for ; Mon, 18 Jul 2022 00:49:59 -0700 (PDT) Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oDLVu-0000p6-11; Mon, 18 Jul 2022 09:49:58 +0200 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1oDLVt-001fbn-3e; Mon, 18 Jul 2022 09:49:57 +0200 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1oDLVs-005uu1-7D; Mon, 18 Jul 2022 09:49:56 +0200 Date: Mon, 18 Jul 2022 09:49:54 +0200 From: Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= To: Ben Dooks Cc: linux-pwm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Lee Jones , Thierry Reding , Krzysztof Kozlowski , Greentime Hu , Jude Onyenegecha , Sudip Mukherjee , William Salmon , Adnan Chowdhury Subject: Re: [PATCH 1/7] pwm: change &pci->dev to dev in probe Message-ID: <20220718074954.4z4qiz2pbuyrzaje@pengutronix.de> References: <20220712100113.569042-1-ben.dooks@sifive.com> <20220712100113.569042-2-ben.dooks@sifive.com> <20220713081633.5lsunbl5mfnngdrs@pengutronix.de> <2cd139dd-559e-7975-41a7-c813bc5851ea@sifive.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="gugjtpolg2xq7sbq" Content-Disposition: inline In-Reply-To: <2cd139dd-559e-7975-41a7-c813bc5851ea@sifive.com> X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: devicetree@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org --gugjtpolg2xq7sbq Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Jul 18, 2022 at 08:19:16AM +0100, Ben Dooks wrote: > On 13/07/2022 09:16, Uwe Kleine-K=F6nig wrote: > > On Tue, Jul 12, 2022 at 11:01:07AM +0100, Ben Dooks wrote: > > > The dwc_pwm_probe() assignes dev to be &pci->dev but then uses > > > &pci->dev throughout the function. Change these all to the be > > > 'dev' variable to make lines shorter. > >=20 > > Looks reasonable. > >=20 > > Acked-by: Uwe Kleine-K=F6nig >=20 > ack for 1/7 or the series? The former. For the other patches I assume they will change in v2. Best regards Uwe --=20 Pengutronix e.K. | Uwe Kleine-K=F6nig | Industrial Linux Solutions | https://www.pengutronix.de/ | --gugjtpolg2xq7sbq Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEfnIqFpAYrP8+dKQLwfwUeK3K7AkFAmLVEJ8ACgkQwfwUeK3K 7Ank1gf/aVK8DObV4OI8VKrTvEmxLg4uzaKulXPLONF9YVCLqp+OcklVONURMzSy 06f2yQrGKiVQHysJyp8schvUryXZr2iUNA7R63Gn0X47aElFjxcpZ4kiGX6qMDDg N270bJgnqQ07OXwqcuqCqki8886WBZGVyIyqrDwD8O31UIw/9mwKuSL9Svn5hwEX GD3d8s6VEuNif/YUTcb0jGv5xYVEZfKuXmQcWD3VDAn8iZ0PiwYQUpX+Y9FCgN6O QHVC7AjL8JkSDlZAbd37aFqdtj5f/hFd2LP2vHM0uxQasMrwjWONxlaGT1sifBb5 6QL2AKWvXFgcr1DbHjncNUzuXbRytA== =YjeE -----END PGP SIGNATURE----- --gugjtpolg2xq7sbq--