From: Charles Keepax <ckeepax@opensource.cirrus.com>
To: Zhu Ning <zhuning0077@gmail.com>
Cc: <alsa-devel@alsa-project.org>, <devicetree@vger.kernel.org>,
<pierre-louis.bossart@linux.intel.com>, <tiwai@suse.com>,
<broonie@kernel.org>, Zhu Ning <zhuning@everest-semi.com>,
David Yang <yangxiaohua@everest-semi.com>
Subject: Re: [PATCH v1 1/2] ASoC: codecs: add support for ES8326
Date: Mon, 18 Jul 2022 10:18:04 +0000 [thread overview]
Message-ID: <20220718101804.GA106016@ediswmail.ad.cirrus.com> (raw)
In-Reply-To: <20220718053237.20146-1-zhuning0077@gmail.com>
On Mon, Jul 18, 2022 at 01:32:36PM +0800, Zhu Ning wrote:
> The ES8326 codec is not compatible with ES8316 and requires a dedicated driver.
>
> Signed-off-by: David Yang <yangxiaohua@everest-semi.com>
> Signed-off-by: Zhu Ning <zhuning@everest-semi.com>
>
> -----
> +static const struct snd_soc_component_driver soc_component_dev_es8326 = {
> + .probe = es8326_probe,
> + .remove = es8326_remove,
> + .resume = es8326_resume,
> + .suspend = es8326_suspend,
> + .set_bias_level = es8326_set_bias_level,
> + .set_jack = es8326_set_jack,
> +
> + .dapm_widgets = es8326_dapm_widgets,
> + .num_dapm_widgets = ARRAY_SIZE(es8326_dapm_widgets),
> + .dapm_routes = es8326_dapm_routes,
> + .num_dapm_routes = ARRAY_SIZE(es8326_dapm_routes),
> + .controls = es8326_snd_controls,
> + .num_controls = ARRAY_SIZE(es8326_snd_controls),
> +};
As this device sits behind an I2S link you need the endianness
flag here to specify that the endian will be lost over the bus.
Thanks,
Charles
prev parent reply other threads:[~2022-07-18 10:18 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-18 5:32 [PATCH v1 1/2] ASoC: codecs: add support for ES8326 Zhu Ning
2022-07-18 5:32 ` [PATCH v1 2/2] dt-bindings: sound: es8326: Add dtbindings documentation Zhu Ning
2022-07-20 22:34 ` Rob Herring
2022-07-18 10:18 ` Charles Keepax [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220718101804.GA106016@ediswmail.ad.cirrus.com \
--to=ckeepax@opensource.cirrus.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=tiwai@suse.com \
--cc=yangxiaohua@everest-semi.com \
--cc=zhuning0077@gmail.com \
--cc=zhuning@everest-semi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).