From: Bjorn Helgaas <helgaas@kernel.org>
To: Richard Zhu <hongxing.zhu@nxp.com>
Cc: robh@kernel.org, l.stach@pengutronix.de,
galak@kernel.crashing.org, shawnguo@kernel.org,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-imx@nxp.com,
kernel@pengutronix.de
Subject: Re: [PATCH v2 1/3] dt-bindings: PCI: imx6: convert the imx pcie controller to dtschema
Date: Tue, 19 Jul 2022 13:00:25 -0500 [thread overview]
Message-ID: <20220719180025.GA1549128@bhelgaas> (raw)
In-Reply-To: <1630046580-19282-2-git-send-email-hongxing.zhu@nxp.com>
On Fri, Aug 27, 2021 at 02:42:58PM +0800, Richard Zhu wrote:
> Convert the fsl,imx6q-pcie.txt into a schema.
> - ranges property should be grouped by region, with no functional
> changes.
> - only one propert is allowed in the compatible string, remove
> "snps,dw-pcie".
>
> Signed-off-by: Richard Zhu <hongxing.zhu@nxp.com>
> ---
> .../bindings/pci/fsl,imx6q-pcie.txt | 100 ---------
> .../bindings/pci/fsl,imx6q-pcie.yaml | 202 ++++++++++++++++++
> MAINTAINERS | 2 +-
> 3 files changed, 203 insertions(+), 101 deletions(-)
> delete mode 100644 Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.txt
> create mode 100644 Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.yaml
>
> diff --git a/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.txt b/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.txt
> -Optional properties:
> -- fsl,tx-deemph-gen1: Gen1 De-emphasis value. Default: 0
> -- fsl,tx-deemph-gen2-3p5db: Gen2 (3.5db) De-emphasis value. Default: 0
> diff --git a/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.yaml b/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.yaml
> + fsl,tx-deemph-gen1:
> + description: Gen1 De-emphasis value (optional required).
> + $ref: /schemas/types.yaml#/definitions/uint32
> + default: 0
> +
> + fsl,tx-deemph-gen2-3p5db:
> + description: Gen2 (3.5db) De-emphasis value (optional required).
> + $ref: /schemas/types.yaml#/definitions/uint32
> + default: 0
What does "optional required" mean in all these properties?
"Optional" is the opposite of "required."
next prev parent reply other threads:[~2022-07-19 18:00 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-27 6:42 [PATCH v2 0/3] dt-bindings: PCI: imx6: convert the imx pcie Richard Zhu
2021-08-27 6:42 ` [PATCH v2 1/3] dt-bindings: PCI: imx6: convert the imx pcie controller to dtschema Richard Zhu
2021-08-31 0:19 ` Rob Herring
2022-07-19 18:00 ` Bjorn Helgaas [this message]
2022-07-20 1:16 ` Hongxing Zhu
2022-07-20 21:03 ` Bjorn Helgaas
2022-07-21 2:37 ` Hongxing Zhu
2021-08-27 6:42 ` [PATCH v2 2/3] arm: dts: imx: fix the schema check errors Richard Zhu
2021-09-22 6:45 ` Shawn Guo
2021-08-27 6:43 ` [PATCH v2 3/3] arm64: dts: imx8mq: " Richard Zhu
2021-09-15 5:21 ` Richard Zhu
2021-09-22 6:48 ` Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220719180025.GA1549128@bhelgaas \
--to=helgaas@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=galak@kernel.crashing.org \
--cc=hongxing.zhu@nxp.com \
--cc=kernel@pengutronix.de \
--cc=l.stach@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).