From: Michael Grzeschik <mgr@pengutronix.de>
To: Piyush Mehta <piyush.mehta@xilinx.com>
Cc: gregkh@linuxfoundation.org, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, balbi@kernel.org,
linux-usb@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, michal.simek@xilinx.com,
git@xilinx.com, sivadur@xilinx.com
Subject: Re: [PATCH 0/2] usb: dwc3: core: Enable GUCTL1 bit 10 for fixing crc error after resume
Date: Wed, 20 Jul 2022 00:06:30 +0200 [thread overview]
Message-ID: <20220719220630.GA24858@pengutronix.de> (raw)
In-Reply-To: <20220613124703.4493-1-piyush.mehta@xilinx.com>
[-- Attachment #1: Type: text/plain, Size: 1731 bytes --]
Hi Piyush!
On Mon, Jun 13, 2022 at 06:17:01PM +0530, Piyush Mehta wrote:
>This patch of the series does the following:
>- Add a new DT "snps,enable_guctl1_resume_quirk" quirk
>- Enable GUCTL1 bit 10 for fixing crc error after resume bug
> When this bit is set to '1', the ULPI opmode will be changed
> to 'normal' along with HS terminations after EOR.
> This option is to support certain legacy ULPI PHYs.
>
>Piyush Mehta (2):
> dt-bindings: usb: snps,dwc3: Add 'snps,enable_guctl1_resume_quirk'
> quirk
> usb: dwc3: core: Enable GUCTL1 bit 10 for fixing crc error after
> resume bug
>
> .../devicetree/bindings/usb/snps,dwc3.yaml | 6 ++++++
> drivers/usb/dwc3/core.c | 16 ++++++++++++++++
> drivers/usb/dwc3/core.h | 6 ++++++
> 3 files changed, 28 insertions(+)
I found your series and am wondering if you are planning to send a v2 of
it? It would really help to see this mainline.
The Xilinx Register Reference states BIT 10 as
RESUME_TERMSEL_XCVRSEL_UNIFY
which seems to be more meaningful than GUCTL1_RESUME_QUIRK. It would
probably make sense to work this in for v2.
The Documentation is also refering more than just opmode to be 0
during EOR. (termsel, xcvrsel, opmode).
https://www.xilinx.com/htmldocs/registers/ug1087/ug1087-zynq-ultrascale-registers.html#usb3_xhci___guctl1.html
Regards,
Michael
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2022-07-19 22:06 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-13 12:47 [PATCH 0/2] usb: dwc3: core: Enable GUCTL1 bit 10 for fixing crc error after resume Piyush Mehta
2022-06-13 12:47 ` [PATCH 1/2] dt-bindings: usb: snps,dwc3: Add 'snps,enable_guctl1_resume_quirk' quirk Piyush Mehta
2022-06-16 22:42 ` Krzysztof Kozlowski
2022-06-13 12:47 ` [PATCH 2/2] usb: dwc3: core: Enable GUCTL1 bit 10 for fixing crc error after resume bug Piyush Mehta
2022-06-17 22:48 ` Rob Herring
2022-09-08 5:40 ` Mehta, Piyush
2022-07-19 22:06 ` Michael Grzeschik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220719220630.GA24858@pengutronix.de \
--to=mgr@pengutronix.de \
--cc=balbi@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=git@xilinx.com \
--cc=gregkh@linuxfoundation.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=michal.simek@xilinx.com \
--cc=piyush.mehta@xilinx.com \
--cc=robh+dt@kernel.org \
--cc=sivadur@xilinx.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).