* [RESEND PATCH 3/9] arm64: dts: bcmbca: update BCM4908 board dts files
@ 2022-07-21 0:07 William Zhang
2022-07-21 6:15 ` Rafał Miłecki
0 siblings, 1 reply; 3+ messages in thread
From: William Zhang @ 2022-07-21 0:07 UTC (permalink / raw)
To: Linux ARM List
Cc: joel.peshkin, dan.beygelman, William Zhang, Rob Herring,
Krzysztof Kozlowski, Florian Fainelli, Rafał Miłecki,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
open list
[-- Attachment #1: Type: text/plain, Size: 2892 bytes --]
Append "brcm,bcmbca" to compatible strings based on the new bcmbca
binding rule for BCM4908 family based boards. This will break drivers
that use the old compatible string for binding. Fortunately there is no
such usage in linux and u-boot.
Signed-off-by: William Zhang <william.zhang@broadcom.com>
---
arch/arm64/boot/dts/broadcom/bcm4908/bcm4906-netgear-r8000p.dts | 2 +-
.../dts/broadcom/bcm4908/bcm4906-tplink-archer-c2300-v1.dts | 2 +-
arch/arm64/boot/dts/broadcom/bcm4908/bcm4908-asus-gt-ac5300.dts | 2 +-
.../arm64/boot/dts/broadcom/bcm4908/bcm4908-netgear-raxe500.dts | 2 +-
4 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/arch/arm64/boot/dts/broadcom/bcm4908/bcm4906-netgear-r8000p.dts b/arch/arm64/boot/dts/broadcom/bcm4908/bcm4906-netgear-r8000p.dts
index 2dd028438c22..d8b60575eb4f 100644
--- a/arch/arm64/boot/dts/broadcom/bcm4908/bcm4906-netgear-r8000p.dts
+++ b/arch/arm64/boot/dts/broadcom/bcm4908/bcm4906-netgear-r8000p.dts
@@ -7,7 +7,7 @@
#include "bcm4906.dtsi"
/ {
- compatible = "netgear,r8000p", "brcm,bcm4906", "brcm,bcm4908";
+ compatible = "netgear,r8000p", "brcm,bcm4906", "brcm,bcm4908", "brcm,bcmbca";
model = "Netgear R8000P";
memory@0 {
diff --git a/arch/arm64/boot/dts/broadcom/bcm4908/bcm4906-tplink-archer-c2300-v1.dts b/arch/arm64/boot/dts/broadcom/bcm4908/bcm4906-tplink-archer-c2300-v1.dts
index 064f7f549665..296393d4aaab 100644
--- a/arch/arm64/boot/dts/broadcom/bcm4908/bcm4906-tplink-archer-c2300-v1.dts
+++ b/arch/arm64/boot/dts/broadcom/bcm4908/bcm4906-tplink-archer-c2300-v1.dts
@@ -7,7 +7,7 @@
#include "bcm4906.dtsi"
/ {
- compatible = "tplink,archer-c2300-v1", "brcm,bcm4906", "brcm,bcm4908";
+ compatible = "tplink,archer-c2300-v1", "brcm,bcm4906", "brcm,bcm4908", "brcm,bcmbca";
model = "TP-Link Archer C2300 V1";
memory@0 {
diff --git a/arch/arm64/boot/dts/broadcom/bcm4908/bcm4908-asus-gt-ac5300.dts b/arch/arm64/boot/dts/broadcom/bcm4908/bcm4908-asus-gt-ac5300.dts
index 04f8524b5335..787c7ddf9102 100644
--- a/arch/arm64/boot/dts/broadcom/bcm4908/bcm4908-asus-gt-ac5300.dts
+++ b/arch/arm64/boot/dts/broadcom/bcm4908/bcm4908-asus-gt-ac5300.dts
@@ -6,7 +6,7 @@
#include "bcm4908.dtsi"
/ {
- compatible = "asus,gt-ac5300", "brcm,bcm4908";
+ compatible = "asus,gt-ac5300", "brcm,bcm4908", "brcm,bcmbca";
model = "Asus GT-AC5300";
memory@0 {
diff --git a/arch/arm64/boot/dts/broadcom/bcm4908/bcm4908-netgear-raxe500.dts b/arch/arm64/boot/dts/broadcom/bcm4908/bcm4908-netgear-raxe500.dts
index 3c2cf2d238b6..23b96c663239 100644
--- a/arch/arm64/boot/dts/broadcom/bcm4908/bcm4908-netgear-raxe500.dts
+++ b/arch/arm64/boot/dts/broadcom/bcm4908/bcm4908-netgear-raxe500.dts
@@ -3,7 +3,7 @@
#include "bcm4908.dtsi"
/ {
- compatible = "netgear,raxe500", "brcm,bcm4908";
+ compatible = "netgear,raxe500", "brcm,bcm4908", "brcm,bcmbca";
model = "Netgear RAXE500";
memory@0 {
--
2.34.1
[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4212 bytes --]
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [RESEND PATCH 3/9] arm64: dts: bcmbca: update BCM4908 board dts files
2022-07-21 0:07 [RESEND PATCH 3/9] arm64: dts: bcmbca: update BCM4908 board dts files William Zhang
@ 2022-07-21 6:15 ` Rafał Miłecki
2022-07-21 17:54 ` William Zhang
0 siblings, 1 reply; 3+ messages in thread
From: Rafał Miłecki @ 2022-07-21 6:15 UTC (permalink / raw)
To: William Zhang
Cc: Linux ARM List, joel.peshkin, dan.beygelman, Rob Herring,
Krzysztof Kozlowski, Florian Fainelli, devicetree, linux-kernel
On 2022-07-21 02:07, William Zhang wrote:
> Append "brcm,bcmbca" to compatible strings based on the new bcmbca
> binding rule for BCM4908 family based boards. This will break drivers
> that use the old compatible string for binding. Fortunately there is no
> such usage in linux and u-boot.
Why should an extra "compatible" value break anything? I don't think it
will happen unless some driver does some really crazy stuff (like
checking full list of "compatible" values).
> Signed-off-by: William Zhang <william.zhang@broadcom.com>
Other than confusing commit message:
Acked-by: Rafał Miłecki <rafal@milecki.pl>
> ---
>
> arch/arm64/boot/dts/broadcom/bcm4908/bcm4906-netgear-r8000p.dts | 2 +-
> .../dts/broadcom/bcm4908/bcm4906-tplink-archer-c2300-v1.dts | 2 +-
> arch/arm64/boot/dts/broadcom/bcm4908/bcm4908-asus-gt-ac5300.dts | 2 +-
> .../arm64/boot/dts/broadcom/bcm4908/bcm4908-netgear-raxe500.dts | 2 +-
> 4 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git
> a/arch/arm64/boot/dts/broadcom/bcm4908/bcm4906-netgear-r8000p.dts
> b/arch/arm64/boot/dts/broadcom/bcm4908/bcm4906-netgear-r8000p.dts
> index 2dd028438c22..d8b60575eb4f 100644
> --- a/arch/arm64/boot/dts/broadcom/bcm4908/bcm4906-netgear-r8000p.dts
> +++ b/arch/arm64/boot/dts/broadcom/bcm4908/bcm4906-netgear-r8000p.dts
> @@ -7,7 +7,7 @@
> #include "bcm4906.dtsi"
>
> / {
> - compatible = "netgear,r8000p", "brcm,bcm4906", "brcm,bcm4908";
> + compatible = "netgear,r8000p", "brcm,bcm4906", "brcm,bcm4908",
> "brcm,bcmbca";
> model = "Netgear R8000P";
>
> memory@0 {
> diff --git
> a/arch/arm64/boot/dts/broadcom/bcm4908/bcm4906-tplink-archer-c2300-v1.dts
> b/arch/arm64/boot/dts/broadcom/bcm4908/bcm4906-tplink-archer-c2300-v1.dts
> index 064f7f549665..296393d4aaab 100644
> ---
> a/arch/arm64/boot/dts/broadcom/bcm4908/bcm4906-tplink-archer-c2300-v1.dts
> +++
> b/arch/arm64/boot/dts/broadcom/bcm4908/bcm4906-tplink-archer-c2300-v1.dts
> @@ -7,7 +7,7 @@
> #include "bcm4906.dtsi"
>
> / {
> - compatible = "tplink,archer-c2300-v1", "brcm,bcm4906",
> "brcm,bcm4908";
> + compatible = "tplink,archer-c2300-v1", "brcm,bcm4906",
> "brcm,bcm4908", "brcm,bcmbca";
> model = "TP-Link Archer C2300 V1";
>
> memory@0 {
> diff --git
> a/arch/arm64/boot/dts/broadcom/bcm4908/bcm4908-asus-gt-ac5300.dts
> b/arch/arm64/boot/dts/broadcom/bcm4908/bcm4908-asus-gt-ac5300.dts
> index 04f8524b5335..787c7ddf9102 100644
> --- a/arch/arm64/boot/dts/broadcom/bcm4908/bcm4908-asus-gt-ac5300.dts
> +++ b/arch/arm64/boot/dts/broadcom/bcm4908/bcm4908-asus-gt-ac5300.dts
> @@ -6,7 +6,7 @@
> #include "bcm4908.dtsi"
>
> / {
> - compatible = "asus,gt-ac5300", "brcm,bcm4908";
> + compatible = "asus,gt-ac5300", "brcm,bcm4908", "brcm,bcmbca";
> model = "Asus GT-AC5300";
>
> memory@0 {
> diff --git
> a/arch/arm64/boot/dts/broadcom/bcm4908/bcm4908-netgear-raxe500.dts
> b/arch/arm64/boot/dts/broadcom/bcm4908/bcm4908-netgear-raxe500.dts
> index 3c2cf2d238b6..23b96c663239 100644
> --- a/arch/arm64/boot/dts/broadcom/bcm4908/bcm4908-netgear-raxe500.dts
> +++ b/arch/arm64/boot/dts/broadcom/bcm4908/bcm4908-netgear-raxe500.dts
> @@ -3,7 +3,7 @@
> #include "bcm4908.dtsi"
>
> / {
> - compatible = "netgear,raxe500", "brcm,bcm4908";
> + compatible = "netgear,raxe500", "brcm,bcm4908", "brcm,bcmbca";
> model = "Netgear RAXE500";
>
> memory@0 {
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [RESEND PATCH 3/9] arm64: dts: bcmbca: update BCM4908 board dts files
2022-07-21 6:15 ` Rafał Miłecki
@ 2022-07-21 17:54 ` William Zhang
0 siblings, 0 replies; 3+ messages in thread
From: William Zhang @ 2022-07-21 17:54 UTC (permalink / raw)
To: Rafał Miłecki
Cc: Linux ARM List, joel.peshkin, dan.beygelman, Rob Herring,
Krzysztof Kozlowski, Florian Fainelli, devicetree, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 3844 bytes --]
On 07/20/2022 11:15 PM, Rafał Miłecki wrote:
> On 2022-07-21 02:07, William Zhang wrote:
>> Append "brcm,bcmbca" to compatible strings based on the new bcmbca
>> binding rule for BCM4908 family based boards. This will break drivers
>> that use the old compatible string for binding. Fortunately there is no
>> such usage in linux and u-boot.
>
> Why should an extra "compatible" value break anything? I don't think it
> will happen unless some driver does some really crazy stuff (like
> checking full list of "compatible" values).
>
Yes anything along those lines will break. But there is no such
craziness in linux and u-boot(wouldn't be accepted in first place). But
Krzysztof suggested to add that to the commit message. I would prefer
not to add that either.
>
>> Signed-off-by: William Zhang <william.zhang@broadcom.com>
>
> Other than confusing commit message:
>
> Acked-by: Rafał Miłecki <rafal@milecki.pl>
>
>
>> ---
>>
>> arch/arm64/boot/dts/broadcom/bcm4908/bcm4906-netgear-r8000p.dts | 2 +-
>> .../dts/broadcom/bcm4908/bcm4906-tplink-archer-c2300-v1.dts | 2 +-
>> arch/arm64/boot/dts/broadcom/bcm4908/bcm4908-asus-gt-ac5300.dts | 2 +-
>> .../arm64/boot/dts/broadcom/bcm4908/bcm4908-netgear-raxe500.dts | 2 +-
>> 4 files changed, 4 insertions(+), 4 deletions(-)
>>
>> diff --git
>> a/arch/arm64/boot/dts/broadcom/bcm4908/bcm4906-netgear-r8000p.dts
>> b/arch/arm64/boot/dts/broadcom/bcm4908/bcm4906-netgear-r8000p.dts
>> index 2dd028438c22..d8b60575eb4f 100644
>> --- a/arch/arm64/boot/dts/broadcom/bcm4908/bcm4906-netgear-r8000p.dts
>> +++ b/arch/arm64/boot/dts/broadcom/bcm4908/bcm4906-netgear-r8000p.dts
>> @@ -7,7 +7,7 @@
>> #include "bcm4906.dtsi"
>>
>> / {
>> - compatible = "netgear,r8000p", "brcm,bcm4906", "brcm,bcm4908";
>> + compatible = "netgear,r8000p", "brcm,bcm4906", "brcm,bcm4908",
>> "brcm,bcmbca";
>> model = "Netgear R8000P";
>>
>> memory@0 {
>> diff --git
>> a/arch/arm64/boot/dts/broadcom/bcm4908/bcm4906-tplink-archer-c2300-v1.dts
>> b/arch/arm64/boot/dts/broadcom/bcm4908/bcm4906-tplink-archer-c2300-v1.dts
>> index 064f7f549665..296393d4aaab 100644
>> ---
>> a/arch/arm64/boot/dts/broadcom/bcm4908/bcm4906-tplink-archer-c2300-v1.dts
>> +++
>> b/arch/arm64/boot/dts/broadcom/bcm4908/bcm4906-tplink-archer-c2300-v1.dts
>> @@ -7,7 +7,7 @@
>> #include "bcm4906.dtsi"
>>
>> / {
>> - compatible = "tplink,archer-c2300-v1", "brcm,bcm4906",
>> "brcm,bcm4908";
>> + compatible = "tplink,archer-c2300-v1", "brcm,bcm4906",
>> "brcm,bcm4908", "brcm,bcmbca";
>> model = "TP-Link Archer C2300 V1";
>>
>> memory@0 {
>> diff --git
>> a/arch/arm64/boot/dts/broadcom/bcm4908/bcm4908-asus-gt-ac5300.dts
>> b/arch/arm64/boot/dts/broadcom/bcm4908/bcm4908-asus-gt-ac5300.dts
>> index 04f8524b5335..787c7ddf9102 100644
>> --- a/arch/arm64/boot/dts/broadcom/bcm4908/bcm4908-asus-gt-ac5300.dts
>> +++ b/arch/arm64/boot/dts/broadcom/bcm4908/bcm4908-asus-gt-ac5300.dts
>> @@ -6,7 +6,7 @@
>> #include "bcm4908.dtsi"
>>
>> / {
>> - compatible = "asus,gt-ac5300", "brcm,bcm4908";
>> + compatible = "asus,gt-ac5300", "brcm,bcm4908", "brcm,bcmbca";
>> model = "Asus GT-AC5300";
>>
>> memory@0 {
>> diff --git
>> a/arch/arm64/boot/dts/broadcom/bcm4908/bcm4908-netgear-raxe500.dts
>> b/arch/arm64/boot/dts/broadcom/bcm4908/bcm4908-netgear-raxe500.dts
>> index 3c2cf2d238b6..23b96c663239 100644
>> --- a/arch/arm64/boot/dts/broadcom/bcm4908/bcm4908-netgear-raxe500.dts
>> +++ b/arch/arm64/boot/dts/broadcom/bcm4908/bcm4908-netgear-raxe500.dts
>> @@ -3,7 +3,7 @@
>> #include "bcm4908.dtsi"
>>
>> / {
>> - compatible = "netgear,raxe500", "brcm,bcm4908";
>> + compatible = "netgear,raxe500", "brcm,bcm4908", "brcm,bcmbca";
>> model = "Netgear RAXE500";
>>
>> memory@0 {
[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4212 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-07-21 17:54 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-07-21 0:07 [RESEND PATCH 3/9] arm64: dts: bcmbca: update BCM4908 board dts files William Zhang
2022-07-21 6:15 ` Rafał Miłecki
2022-07-21 17:54 ` William Zhang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).