* [PATCH] arm64: dts: rockchip: Lower sd speed on quartz64-b
@ 2022-07-21 4:43 Nicolas Frattaroli
2022-07-22 5:54 ` Peter Geis
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Nicolas Frattaroli @ 2022-07-21 4:43 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Heiko Stuebner, Peter Geis
Cc: Nicolas Frattaroli, devicetree, linux-arm-kernel, linux-rockchip,
linux-kernel
The previously stated speed of sdr-104 is too high for the hardware
to reliably communicate with some fast SD cards.
Lower this to sd-uhs-sdr50 to fix this.
Fixes: dcc8c66bef79 ("arm64: dts: rockchip: add Pine64 Quartz64-B device tree")
Signed-off-by: Nicolas Frattaroli <frattaroli.nicolas@gmail.com>
---
arch/arm64/boot/dts/rockchip/rk3566-quartz64-b.dts | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/rockchip/rk3566-quartz64-b.dts b/arch/arm64/boot/dts/rockchip/rk3566-quartz64-b.dts
index 02d5f5a8ca03..528bb4e8ac77 100644
--- a/arch/arm64/boot/dts/rockchip/rk3566-quartz64-b.dts
+++ b/arch/arm64/boot/dts/rockchip/rk3566-quartz64-b.dts
@@ -506,7 +506,7 @@ &sdmmc0 {
disable-wp;
pinctrl-names = "default";
pinctrl-0 = <&sdmmc0_bus4 &sdmmc0_clk &sdmmc0_cmd &sdmmc0_det>;
- sd-uhs-sdr104;
+ sd-uhs-sdr50;
vmmc-supply = <&vcc3v3_sd>;
vqmmc-supply = <&vccio_sd>;
status = "okay";
--
2.37.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] arm64: dts: rockchip: Lower sd speed on quartz64-b
2022-07-21 4:43 [PATCH] arm64: dts: rockchip: Lower sd speed on quartz64-b Nicolas Frattaroli
@ 2022-07-22 5:54 ` Peter Geis
2022-08-19 23:53 ` Nicolas Frattaroli
2022-08-23 12:36 ` Heiko Stuebner
2 siblings, 0 replies; 4+ messages in thread
From: Peter Geis @ 2022-07-22 5:54 UTC (permalink / raw)
To: Nicolas Frattaroli
Cc: Rob Herring, Krzysztof Kozlowski, Heiko Stuebner, devicetree,
arm-mail-list, open list:ARM/Rockchip SoC...,
Linux Kernel Mailing List
On Thu, Jul 21, 2022 at 6:43 AM Nicolas Frattaroli
<frattaroli.nicolas@gmail.com> wrote:
>
> The previously stated speed of sdr-104 is too high for the hardware
> to reliably communicate with some fast SD cards.
>
> Lower this to sd-uhs-sdr50 to fix this.
I can confirm this is necessary. Thanks!
Tested-by: Peter Geis <pgwipeout@gmail.com>
>
> Fixes: dcc8c66bef79 ("arm64: dts: rockchip: add Pine64 Quartz64-B device tree")
>
> Signed-off-by: Nicolas Frattaroli <frattaroli.nicolas@gmail.com>
> ---
> arch/arm64/boot/dts/rockchip/rk3566-quartz64-b.dts | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/rockchip/rk3566-quartz64-b.dts b/arch/arm64/boot/dts/rockchip/rk3566-quartz64-b.dts
> index 02d5f5a8ca03..528bb4e8ac77 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3566-quartz64-b.dts
> +++ b/arch/arm64/boot/dts/rockchip/rk3566-quartz64-b.dts
> @@ -506,7 +506,7 @@ &sdmmc0 {
> disable-wp;
> pinctrl-names = "default";
> pinctrl-0 = <&sdmmc0_bus4 &sdmmc0_clk &sdmmc0_cmd &sdmmc0_det>;
> - sd-uhs-sdr104;
> + sd-uhs-sdr50;
> vmmc-supply = <&vcc3v3_sd>;
> vqmmc-supply = <&vccio_sd>;
> status = "okay";
> --
> 2.37.1
>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] arm64: dts: rockchip: Lower sd speed on quartz64-b
2022-07-21 4:43 [PATCH] arm64: dts: rockchip: Lower sd speed on quartz64-b Nicolas Frattaroli
2022-07-22 5:54 ` Peter Geis
@ 2022-08-19 23:53 ` Nicolas Frattaroli
2022-08-23 12:36 ` Heiko Stuebner
2 siblings, 0 replies; 4+ messages in thread
From: Nicolas Frattaroli @ 2022-08-19 23:53 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Heiko Stuebner, Peter Geis
Cc: devicetree, linux-arm-kernel, linux-rockchip, linux-kernel
On Donnerstag, 21. Juli 2022 06:43:06 CEST Nicolas Frattaroli wrote:
> The previously stated speed of sdr-104 is too high for the hardware
> to reliably communicate with some fast SD cards.
>
> Lower this to sd-uhs-sdr50 to fix this.
>
> Fixes: dcc8c66bef79 ("arm64: dts: rockchip: add Pine64 Quartz64-B device tree")
>
> Signed-off-by: Nicolas Frattaroli <frattaroli.nicolas@gmail.com>
> ---
> arch/arm64/boot/dts/rockchip/rk3566-quartz64-b.dts | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/rockchip/rk3566-quartz64-b.dts b/arch/arm64/boot/dts/rockchip/rk3566-quartz64-b.dts
> index 02d5f5a8ca03..528bb4e8ac77 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3566-quartz64-b.dts
> +++ b/arch/arm64/boot/dts/rockchip/rk3566-quartz64-b.dts
> @@ -506,7 +506,7 @@ &sdmmc0 {
> disable-wp;
> pinctrl-names = "default";
> pinctrl-0 = <&sdmmc0_bus4 &sdmmc0_clk &sdmmc0_cmd &sdmmc0_det>;
> - sd-uhs-sdr104;
> + sd-uhs-sdr50;
> vmmc-supply = <&vcc3v3_sd>;
> vqmmc-supply = <&vccio_sd>;
> status = "okay";
>
Please apply. Thank you!
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] arm64: dts: rockchip: Lower sd speed on quartz64-b
2022-07-21 4:43 [PATCH] arm64: dts: rockchip: Lower sd speed on quartz64-b Nicolas Frattaroli
2022-07-22 5:54 ` Peter Geis
2022-08-19 23:53 ` Nicolas Frattaroli
@ 2022-08-23 12:36 ` Heiko Stuebner
2 siblings, 0 replies; 4+ messages in thread
From: Heiko Stuebner @ 2022-08-23 12:36 UTC (permalink / raw)
To: Krzysztof Kozlowski, Nicolas Frattaroli, Peter Geis, Rob Herring
Cc: Heiko Stuebner, devicetree, linux-arm-kernel, linux-rockchip,
linux-kernel
On Thu, 21 Jul 2022 06:43:06 +0200, Nicolas Frattaroli wrote:
> The previously stated speed of sdr-104 is too high for the hardware
> to reliably communicate with some fast SD cards.
>
> Lower this to sd-uhs-sdr50 to fix this.
>
> Fixes: dcc8c66bef79 ("arm64: dts: rockchip: add Pine64 Quartz64-B device tree")
Applied, thanks!
[1/1] arm64: dts: rockchip: Lower sd speed on quartz64-b
commit: 1ea90b2d293fd8b1f3377c9ed08364ff6f2a8562
Best regards,
--
Heiko Stuebner <heiko@sntech.de>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-08-23 16:15 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-07-21 4:43 [PATCH] arm64: dts: rockchip: Lower sd speed on quartz64-b Nicolas Frattaroli
2022-07-22 5:54 ` Peter Geis
2022-08-19 23:53 ` Nicolas Frattaroli
2022-08-23 12:36 ` Heiko Stuebner
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).