* [PATCH] ARM: dts: BCM5301X: Add basic PCI controller properties
@ 2022-07-21 9:15 Rafał Miłecki
2022-07-21 23:18 ` Florian Fainelli
0 siblings, 1 reply; 2+ messages in thread
From: Rafał Miłecki @ 2022-07-21 9:15 UTC (permalink / raw)
To: Florian Fainelli
Cc: Hauke Mehrtens, Rob Herring, Krzysztof Kozlowski,
linux-arm-kernel, devicetree, bcm-kernel-feedback-list,
Rafał Miłecki
From: Rafał Miłecki <rafal@milecki.pl>
This fixes:
arch/arm/boot/dts/bcm47081-buffalo-wzr-600dhp2.dtb: pcie@12000: 'device_type' is a required property
From schema: /lib/python3.9/site-packages/dtschema/schemas/pci/pci-bus.yaml
arch/arm/boot/dts/bcm47081-buffalo-wzr-600dhp2.dtb: pcie@12000: '#address-cells' is a required property
From schema: /lib/python3.9/site-packages/dtschema/schemas/pci/pci-bus.yaml
arch/arm/boot/dts/bcm47081-buffalo-wzr-600dhp2.dtb: pcie@12000: '#size-cells' is a required property
From schema: /lib/python3.9/site-packages/dtschema/schemas/pci/pci-bus.yaml
arch/arm/boot/dts/bcm47081-buffalo-wzr-600dhp2.dtb: pcie@13000: 'device_type' is a required property
From schema: /lib/python3.9/site-packages/dtschema/schemas/pci/pci-bus.yaml
arch/arm/boot/dts/bcm47081-buffalo-wzr-600dhp2.dtb: pcie@13000: '#address-cells' is a required property
From schema: /lib/python3.9/site-packages/dtschema/schemas/pci/pci-bus.yaml
arch/arm/boot/dts/bcm47081-buffalo-wzr-600dhp2.dtb: pcie@13000: '#size-cells' is a required property
From schema: /lib/python3.9/site-packages/dtschema/schemas/pci/pci-bus.yaml
arch/arm/boot/dts/bcm47081-buffalo-wzr-600dhp2.dtb: pcie@14000: 'device_type' is a required property
From schema: /lib/python3.9/site-packages/dtschema/schemas/pci/pci-bus.yaml
arch/arm/boot/dts/bcm47081-buffalo-wzr-600dhp2.dtb: pcie@14000: '#address-cells' is a required property
From schema: /lib/python3.9/site-packages/dtschema/schemas/pci/pci-bus.yaml
arch/arm/boot/dts/bcm47081-buffalo-wzr-600dhp2.dtb: pcie@14000: '#size-cells' is a required property
From schema: /lib/python3.9/site-packages/dtschema/schemas/pci/pci-bus.yaml
What remains missing is "ranges" property. I currently don't know its
correct value for Northstar SoC.
Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
---
arch/arm/boot/dts/bcm5301x.dtsi | 12 ++++++++++++
1 file changed, 12 insertions(+)
diff --git a/arch/arm/boot/dts/bcm5301x.dtsi b/arch/arm/boot/dts/bcm5301x.dtsi
index 5fc1b847f4aa..a06184b8e0d9 100644
--- a/arch/arm/boot/dts/bcm5301x.dtsi
+++ b/arch/arm/boot/dts/bcm5301x.dtsi
@@ -239,14 +239,26 @@ chipcommon: chipcommon@0 {
pcie0: pcie@12000 {
reg = <0x00012000 0x1000>;
+ device_type = "pci";
+
+ #address-cells = <3>;
+ #size-cells = <2>;
};
pcie1: pcie@13000 {
reg = <0x00013000 0x1000>;
+ device_type = "pci";
+
+ #address-cells = <3>;
+ #size-cells = <2>;
};
pcie2: pcie@14000 {
reg = <0x00014000 0x1000>;
+ device_type = "pci";
+
+ #address-cells = <3>;
+ #size-cells = <2>;
};
usb2: usb2@21000 {
--
2.34.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] ARM: dts: BCM5301X: Add basic PCI controller properties
2022-07-21 9:15 [PATCH] ARM: dts: BCM5301X: Add basic PCI controller properties Rafał Miłecki
@ 2022-07-21 23:18 ` Florian Fainelli
0 siblings, 0 replies; 2+ messages in thread
From: Florian Fainelli @ 2022-07-21 23:18 UTC (permalink / raw)
To: Rafał Miłecki, Florian Fainelli
Cc: Hauke Mehrtens, Rob Herring, Krzysztof Kozlowski,
linux-arm-kernel, devicetree, bcm-kernel-feedback-list,
Rafał Miłecki
On 7/21/22 02:15, Rafał Miłecki wrote:
> From: Rafał Miłecki <rafal@milecki.pl>
>
> This fixes:
> arch/arm/boot/dts/bcm47081-buffalo-wzr-600dhp2.dtb: pcie@12000: 'device_type' is a required property
> From schema: /lib/python3.9/site-packages/dtschema/schemas/pci/pci-bus.yaml
> arch/arm/boot/dts/bcm47081-buffalo-wzr-600dhp2.dtb: pcie@12000: '#address-cells' is a required property
> From schema: /lib/python3.9/site-packages/dtschema/schemas/pci/pci-bus.yaml
> arch/arm/boot/dts/bcm47081-buffalo-wzr-600dhp2.dtb: pcie@12000: '#size-cells' is a required property
> From schema: /lib/python3.9/site-packages/dtschema/schemas/pci/pci-bus.yaml
> arch/arm/boot/dts/bcm47081-buffalo-wzr-600dhp2.dtb: pcie@13000: 'device_type' is a required property
> From schema: /lib/python3.9/site-packages/dtschema/schemas/pci/pci-bus.yaml
> arch/arm/boot/dts/bcm47081-buffalo-wzr-600dhp2.dtb: pcie@13000: '#address-cells' is a required property
> From schema: /lib/python3.9/site-packages/dtschema/schemas/pci/pci-bus.yaml
> arch/arm/boot/dts/bcm47081-buffalo-wzr-600dhp2.dtb: pcie@13000: '#size-cells' is a required property
> From schema: /lib/python3.9/site-packages/dtschema/schemas/pci/pci-bus.yaml
> arch/arm/boot/dts/bcm47081-buffalo-wzr-600dhp2.dtb: pcie@14000: 'device_type' is a required property
> From schema: /lib/python3.9/site-packages/dtschema/schemas/pci/pci-bus.yaml
> arch/arm/boot/dts/bcm47081-buffalo-wzr-600dhp2.dtb: pcie@14000: '#address-cells' is a required property
> From schema: /lib/python3.9/site-packages/dtschema/schemas/pci/pci-bus.yaml
> arch/arm/boot/dts/bcm47081-buffalo-wzr-600dhp2.dtb: pcie@14000: '#size-cells' is a required property
> From schema: /lib/python3.9/site-packages/dtschema/schemas/pci/pci-bus.yaml
>
> What remains missing is "ranges" property. I currently don't know its
> correct value for Northstar SoC.
>
> Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
> ---
Applied to https://github.com/Broadcom/stblinux/commits/devicetree/next, thanks!
--
Florian
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-07-21 23:18 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-07-21 9:15 [PATCH] ARM: dts: BCM5301X: Add basic PCI controller properties Rafał Miłecki
2022-07-21 23:18 ` Florian Fainelli
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).