From: Rob Herring <robh@kernel.org>
To: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: "Marek Vasut" <marex@denx.de>,
devicetree@vger.kernel.org, robert.foss@linaro.org,
dri-devel@lists.freedesktop.org,
"Guido Günther" <agx@sigxcpu.org>,
"Jagan Teki" <jagan@amarulasolutions.com>,
"Linus Walleij" <linus.walleij@linaro.org>,
"Sam Ravnborg" <sam@ravnborg.org>,
"Thierry Reding" <thierry.reding@gmail.com>
Subject: Re: [PATCH] dt-bindings: vendor-prefixes: add Densitron
Date: Thu, 21 Jul 2022 13:23:27 -0600 [thread overview]
Message-ID: <20220721192327.GA1771991-robh@kernel.org> (raw)
In-Reply-To: <YtlHz1+zLR2oi7cK@pendragon.ideasonboard.com>
On Thu, Jul 21, 2022 at 03:34:23PM +0300, Laurent Pinchart wrote:
> Hi Marek,
>
> On Thu, Jul 21, 2022 at 02:24:57PM +0200, Marek Vasut wrote:
> > On 7/21/22 07:41, Laurent Pinchart wrote:
> > > On Thu, Jul 21, 2022 at 05:03:27AM +0200, Marek Vasut wrote:
> > >> Densitron is a manufacturer of LCD panels.
> > >> https://www.densitron.com
> > >>
> > >> Signed-off-by: Marek Vasut <marex@denx.de>
> > >> Cc: Guido Günther <agx@sigxcpu.org>
> > >> Cc: Jagan Teki <jagan@amarulasolutions.com>
> > >> Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> > >> Cc: Linus Walleij <linus.walleij@linaro.org>
> > >> Cc: Rob Herring <robh+dt@kernel.org>
> > >> Cc: Sam Ravnborg <sam@ravnborg.org>
> > >> Cc: Thierry Reding <thierry.reding@gmail.com>
> > >> ---
> > >> Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++
> > >> 1 file changed, 2 insertions(+)
> > >>
> > >> diff --git a/Documentation/devicetree/bindings/vendor-prefixes.yaml b/Documentation/devicetree/bindings/vendor-prefixes.yaml
> > >> index 88859dd4040ee..6277240536b44 100644
> > >> --- a/Documentation/devicetree/bindings/vendor-prefixes.yaml
> > >> +++ b/Documentation/devicetree/bindings/vendor-prefixes.yaml
> > >> @@ -312,6 +312,8 @@ patternProperties:
> > >> description: Dell Inc.
> > >> "^delta,.*":
> > >> description: Delta Electronics, Inc.
> > >> + "^densitron,.*":
> > >
> > > How about "dsn", to follow the practice of using stock names as vendor
> > > prefixes ?
> >
> > Is there any benefit to that ? All I can see is that it's making DTS
> > less clear and more difficult to read. It is easy to map "densitron" to
> > "densitron" when it is spelled out like so in the DT, but it sure isn't
> > immediately obvious that "dsn" means "densitron" without extra look up.
> > And even that extra look up of "dsn" does not return densitron, but some
> > woodworking company and other totally unrelated results.
>
> I don't know where that practice originates from, and if it's still the
> recommended naming scheme these days. All I know is that it was the
> recommended scheme at some point. I expect Rob will be able to tell
> which name is best.
The other practice is using the website name minus .com or whatever. I
would stick with that here.
Rob
next prev parent reply other threads:[~2022-07-21 19:23 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-21 3:03 [PATCH] dt-bindings: vendor-prefixes: add Densitron Marek Vasut
2022-07-21 5:41 ` Laurent Pinchart
2022-07-21 12:24 ` Marek Vasut
2022-07-21 12:34 ` Laurent Pinchart
2022-07-21 19:23 ` Rob Herring [this message]
2022-07-21 19:23 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220721192327.GA1771991-robh@kernel.org \
--to=robh@kernel.org \
--cc=agx@sigxcpu.org \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=jagan@amarulasolutions.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linus.walleij@linaro.org \
--cc=marex@denx.de \
--cc=robert.foss@linaro.org \
--cc=sam@ravnborg.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).