* [PATCH] dt-bindings: vendor-prefixes: add Densitron
@ 2022-07-21 3:03 Marek Vasut
2022-07-21 5:41 ` Laurent Pinchart
2022-07-21 19:23 ` Rob Herring
0 siblings, 2 replies; 6+ messages in thread
From: Marek Vasut @ 2022-07-21 3:03 UTC (permalink / raw)
To: devicetree
Cc: robert.foss, dri-devel, Marek Vasut, Guido Günther,
Jagan Teki, Laurent Pinchart, Linus Walleij, Rob Herring,
Sam Ravnborg, Thierry Reding
Densitron is a manufacturer of LCD panels.
https://www.densitron.com
Signed-off-by: Marek Vasut <marex@denx.de>
Cc: Guido Günther <agx@sigxcpu.org>
Cc: Jagan Teki <jagan@amarulasolutions.com>
Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: Linus Walleij <linus.walleij@linaro.org>
Cc: Rob Herring <robh+dt@kernel.org>
Cc: Sam Ravnborg <sam@ravnborg.org>
Cc: Thierry Reding <thierry.reding@gmail.com>
---
Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++
1 file changed, 2 insertions(+)
diff --git a/Documentation/devicetree/bindings/vendor-prefixes.yaml b/Documentation/devicetree/bindings/vendor-prefixes.yaml
index 88859dd4040ee..6277240536b44 100644
--- a/Documentation/devicetree/bindings/vendor-prefixes.yaml
+++ b/Documentation/devicetree/bindings/vendor-prefixes.yaml
@@ -312,6 +312,8 @@ patternProperties:
description: Dell Inc.
"^delta,.*":
description: Delta Electronics, Inc.
+ "^densitron,.*":
+ description: Densitron Technologies Ltd
"^denx,.*":
description: Denx Software Engineering
"^devantech,.*":
--
2.35.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] dt-bindings: vendor-prefixes: add Densitron
2022-07-21 3:03 [PATCH] dt-bindings: vendor-prefixes: add Densitron Marek Vasut
@ 2022-07-21 5:41 ` Laurent Pinchart
2022-07-21 12:24 ` Marek Vasut
2022-07-21 19:23 ` Rob Herring
1 sibling, 1 reply; 6+ messages in thread
From: Laurent Pinchart @ 2022-07-21 5:41 UTC (permalink / raw)
To: Marek Vasut
Cc: devicetree, robert.foss, dri-devel, Guido Günther,
Jagan Teki, Linus Walleij, Rob Herring, Sam Ravnborg,
Thierry Reding
Hi Marek,
Thank you for the patch.
On Thu, Jul 21, 2022 at 05:03:27AM +0200, Marek Vasut wrote:
> Densitron is a manufacturer of LCD panels.
> https://www.densitron.com
>
> Signed-off-by: Marek Vasut <marex@denx.de>
> Cc: Guido Günther <agx@sigxcpu.org>
> Cc: Jagan Teki <jagan@amarulasolutions.com>
> Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> Cc: Linus Walleij <linus.walleij@linaro.org>
> Cc: Rob Herring <robh+dt@kernel.org>
> Cc: Sam Ravnborg <sam@ravnborg.org>
> Cc: Thierry Reding <thierry.reding@gmail.com>
> ---
> Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/vendor-prefixes.yaml b/Documentation/devicetree/bindings/vendor-prefixes.yaml
> index 88859dd4040ee..6277240536b44 100644
> --- a/Documentation/devicetree/bindings/vendor-prefixes.yaml
> +++ b/Documentation/devicetree/bindings/vendor-prefixes.yaml
> @@ -312,6 +312,8 @@ patternProperties:
> description: Dell Inc.
> "^delta,.*":
> description: Delta Electronics, Inc.
> + "^densitron,.*":
How about "dsn", to follow the practice of using stock names as vendor
prefixes ?
> + description: Densitron Technologies Ltd
> "^denx,.*":
> description: Denx Software Engineering
> "^devantech,.*":
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] dt-bindings: vendor-prefixes: add Densitron
2022-07-21 5:41 ` Laurent Pinchart
@ 2022-07-21 12:24 ` Marek Vasut
2022-07-21 12:34 ` Laurent Pinchart
0 siblings, 1 reply; 6+ messages in thread
From: Marek Vasut @ 2022-07-21 12:24 UTC (permalink / raw)
To: Laurent Pinchart
Cc: devicetree, robert.foss, dri-devel, Guido Günther,
Jagan Teki, Linus Walleij, Rob Herring, Sam Ravnborg,
Thierry Reding
On 7/21/22 07:41, Laurent Pinchart wrote:
> Hi Marek,
>
> Thank you for the patch.
>
> On Thu, Jul 21, 2022 at 05:03:27AM +0200, Marek Vasut wrote:
>> Densitron is a manufacturer of LCD panels.
>> https://www.densitron.com
>>
>> Signed-off-by: Marek Vasut <marex@denx.de>
>> Cc: Guido Günther <agx@sigxcpu.org>
>> Cc: Jagan Teki <jagan@amarulasolutions.com>
>> Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
>> Cc: Linus Walleij <linus.walleij@linaro.org>
>> Cc: Rob Herring <robh+dt@kernel.org>
>> Cc: Sam Ravnborg <sam@ravnborg.org>
>> Cc: Thierry Reding <thierry.reding@gmail.com>
>> ---
>> Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++
>> 1 file changed, 2 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/vendor-prefixes.yaml b/Documentation/devicetree/bindings/vendor-prefixes.yaml
>> index 88859dd4040ee..6277240536b44 100644
>> --- a/Documentation/devicetree/bindings/vendor-prefixes.yaml
>> +++ b/Documentation/devicetree/bindings/vendor-prefixes.yaml
>> @@ -312,6 +312,8 @@ patternProperties:
>> description: Dell Inc.
>> "^delta,.*":
>> description: Delta Electronics, Inc.
>> + "^densitron,.*":
>
> How about "dsn", to follow the practice of using stock names as vendor
> prefixes ?
Is there any benefit to that ? All I can see is that it's making DTS
less clear and more difficult to read. It is easy to map "densitron" to
"densitron" when it is spelled out like so in the DT, but it sure isn't
immediately obvious that "dsn" means "densitron" without extra look up.
And even that extra look up of "dsn" does not return densitron, but some
woodworking company and other totally unrelated results.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] dt-bindings: vendor-prefixes: add Densitron
2022-07-21 12:24 ` Marek Vasut
@ 2022-07-21 12:34 ` Laurent Pinchart
2022-07-21 19:23 ` Rob Herring
0 siblings, 1 reply; 6+ messages in thread
From: Laurent Pinchart @ 2022-07-21 12:34 UTC (permalink / raw)
To: Marek Vasut
Cc: devicetree, robert.foss, dri-devel, Guido Günther,
Jagan Teki, Linus Walleij, Rob Herring, Sam Ravnborg,
Thierry Reding
Hi Marek,
On Thu, Jul 21, 2022 at 02:24:57PM +0200, Marek Vasut wrote:
> On 7/21/22 07:41, Laurent Pinchart wrote:
> > On Thu, Jul 21, 2022 at 05:03:27AM +0200, Marek Vasut wrote:
> >> Densitron is a manufacturer of LCD panels.
> >> https://www.densitron.com
> >>
> >> Signed-off-by: Marek Vasut <marex@denx.de>
> >> Cc: Guido Günther <agx@sigxcpu.org>
> >> Cc: Jagan Teki <jagan@amarulasolutions.com>
> >> Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> >> Cc: Linus Walleij <linus.walleij@linaro.org>
> >> Cc: Rob Herring <robh+dt@kernel.org>
> >> Cc: Sam Ravnborg <sam@ravnborg.org>
> >> Cc: Thierry Reding <thierry.reding@gmail.com>
> >> ---
> >> Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++
> >> 1 file changed, 2 insertions(+)
> >>
> >> diff --git a/Documentation/devicetree/bindings/vendor-prefixes.yaml b/Documentation/devicetree/bindings/vendor-prefixes.yaml
> >> index 88859dd4040ee..6277240536b44 100644
> >> --- a/Documentation/devicetree/bindings/vendor-prefixes.yaml
> >> +++ b/Documentation/devicetree/bindings/vendor-prefixes.yaml
> >> @@ -312,6 +312,8 @@ patternProperties:
> >> description: Dell Inc.
> >> "^delta,.*":
> >> description: Delta Electronics, Inc.
> >> + "^densitron,.*":
> >
> > How about "dsn", to follow the practice of using stock names as vendor
> > prefixes ?
>
> Is there any benefit to that ? All I can see is that it's making DTS
> less clear and more difficult to read. It is easy to map "densitron" to
> "densitron" when it is spelled out like so in the DT, but it sure isn't
> immediately obvious that "dsn" means "densitron" without extra look up.
> And even that extra look up of "dsn" does not return densitron, but some
> woodworking company and other totally unrelated results.
I don't know where that practice originates from, and if it's still the
recommended naming scheme these days. All I know is that it was the
recommended scheme at some point. I expect Rob will be able to tell
which name is best.
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] dt-bindings: vendor-prefixes: add Densitron
2022-07-21 12:34 ` Laurent Pinchart
@ 2022-07-21 19:23 ` Rob Herring
0 siblings, 0 replies; 6+ messages in thread
From: Rob Herring @ 2022-07-21 19:23 UTC (permalink / raw)
To: Laurent Pinchart
Cc: Marek Vasut, devicetree, robert.foss, dri-devel,
Guido Günther, Jagan Teki, Linus Walleij, Sam Ravnborg,
Thierry Reding
On Thu, Jul 21, 2022 at 03:34:23PM +0300, Laurent Pinchart wrote:
> Hi Marek,
>
> On Thu, Jul 21, 2022 at 02:24:57PM +0200, Marek Vasut wrote:
> > On 7/21/22 07:41, Laurent Pinchart wrote:
> > > On Thu, Jul 21, 2022 at 05:03:27AM +0200, Marek Vasut wrote:
> > >> Densitron is a manufacturer of LCD panels.
> > >> https://www.densitron.com
> > >>
> > >> Signed-off-by: Marek Vasut <marex@denx.de>
> > >> Cc: Guido Günther <agx@sigxcpu.org>
> > >> Cc: Jagan Teki <jagan@amarulasolutions.com>
> > >> Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> > >> Cc: Linus Walleij <linus.walleij@linaro.org>
> > >> Cc: Rob Herring <robh+dt@kernel.org>
> > >> Cc: Sam Ravnborg <sam@ravnborg.org>
> > >> Cc: Thierry Reding <thierry.reding@gmail.com>
> > >> ---
> > >> Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++
> > >> 1 file changed, 2 insertions(+)
> > >>
> > >> diff --git a/Documentation/devicetree/bindings/vendor-prefixes.yaml b/Documentation/devicetree/bindings/vendor-prefixes.yaml
> > >> index 88859dd4040ee..6277240536b44 100644
> > >> --- a/Documentation/devicetree/bindings/vendor-prefixes.yaml
> > >> +++ b/Documentation/devicetree/bindings/vendor-prefixes.yaml
> > >> @@ -312,6 +312,8 @@ patternProperties:
> > >> description: Dell Inc.
> > >> "^delta,.*":
> > >> description: Delta Electronics, Inc.
> > >> + "^densitron,.*":
> > >
> > > How about "dsn", to follow the practice of using stock names as vendor
> > > prefixes ?
> >
> > Is there any benefit to that ? All I can see is that it's making DTS
> > less clear and more difficult to read. It is easy to map "densitron" to
> > "densitron" when it is spelled out like so in the DT, but it sure isn't
> > immediately obvious that "dsn" means "densitron" without extra look up.
> > And even that extra look up of "dsn" does not return densitron, but some
> > woodworking company and other totally unrelated results.
>
> I don't know where that practice originates from, and if it's still the
> recommended naming scheme these days. All I know is that it was the
> recommended scheme at some point. I expect Rob will be able to tell
> which name is best.
The other practice is using the website name minus .com or whatever. I
would stick with that here.
Rob
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] dt-bindings: vendor-prefixes: add Densitron
2022-07-21 3:03 [PATCH] dt-bindings: vendor-prefixes: add Densitron Marek Vasut
2022-07-21 5:41 ` Laurent Pinchart
@ 2022-07-21 19:23 ` Rob Herring
1 sibling, 0 replies; 6+ messages in thread
From: Rob Herring @ 2022-07-21 19:23 UTC (permalink / raw)
To: Marek Vasut
Cc: devicetree, dri-devel, Jagan Teki, robert.foss, Linus Walleij,
Rob Herring, Laurent Pinchart, Thierry Reding, Guido Günther,
Sam Ravnborg
On Thu, 21 Jul 2022 05:03:27 +0200, Marek Vasut wrote:
> Densitron is a manufacturer of LCD panels.
> https://www.densitron.com
>
> Signed-off-by: Marek Vasut <marex@denx.de>
> Cc: Guido Günther <agx@sigxcpu.org>
> Cc: Jagan Teki <jagan@amarulasolutions.com>
> Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> Cc: Linus Walleij <linus.walleij@linaro.org>
> Cc: Rob Herring <robh+dt@kernel.org>
> Cc: Sam Ravnborg <sam@ravnborg.org>
> Cc: Thierry Reding <thierry.reding@gmail.com>
> ---
> Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++
> 1 file changed, 2 insertions(+)
>
Applied, thanks!
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2022-07-21 19:23 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-07-21 3:03 [PATCH] dt-bindings: vendor-prefixes: add Densitron Marek Vasut
2022-07-21 5:41 ` Laurent Pinchart
2022-07-21 12:24 ` Marek Vasut
2022-07-21 12:34 ` Laurent Pinchart
2022-07-21 19:23 ` Rob Herring
2022-07-21 19:23 ` Rob Herring
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).