From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 61B84C433EF for ; Fri, 22 Jul 2022 12:42:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234347AbiGVMmV (ORCPT ); Fri, 22 Jul 2022 08:42:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58512 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230486AbiGVMmT (ORCPT ); Fri, 22 Jul 2022 08:42:19 -0400 Received: from esa.microchip.iphmx.com (esa.microchip.iphmx.com [68.232.154.123]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AA48DE0CA; Fri, 22 Jul 2022 05:42:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=microchip.com; i=@microchip.com; q=dns/txt; s=mchp; t=1658493735; x=1690029735; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=khPSA7SdeZvexVlLJVFq2jEQ1fN3eCp5D1jxG3kOEnY=; b=LtIxRKMZLMD/LHGNwY9MP6yohL7DBQ5jdcy424nN09S/elT5Ingf1pqe f+FzD0erzChbLkJniH/F7My98Z802xQiGSoKZyAW/GtDL2X6AdDv96mGw S+Ut1DpVylrzN3GVfGkQKkuQiYlZGMn+RTpShN3FqcOXWEMnnzGUkqPwX /oPQ48qDRo2aSTWG0m2Epoj/SSDy+seF73L7VDo5C+7F3t8rQZ1F+Qo4t XmQ4jwz5KveIH5d6Dnvimsu0GHf/av0Vc9XIqoaWXX08hP2MbNBFxyEBg 2Hj6yoZg0TlzzPenKntrWpbCIJswGgVx0LFJGksr+lDWUjLTXtXiWpepI Q==; X-IronPort-AV: E=Sophos;i="5.93,185,1654585200"; d="scan'208";a="169063672" Received: from unknown (HELO email.microchip.com) ([170.129.1.10]) by esa2.microchip.iphmx.com with ESMTP/TLS/AES256-SHA256; 22 Jul 2022 05:42:13 -0700 Received: from chn-vm-ex01.mchp-main.com (10.10.85.143) by chn-vm-ex02.mchp-main.com (10.10.85.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.17; Fri, 22 Jul 2022 05:42:12 -0700 Received: from localhost (10.10.115.15) by chn-vm-ex01.mchp-main.com (10.10.85.143) with Microsoft SMTP Server id 15.1.2375.17 via Frontend Transport; Fri, 22 Jul 2022 05:42:12 -0700 Date: Fri, 22 Jul 2022 14:46:20 +0200 From: Horatiu Vultur - M31836 To: Kavyasree Kotagiri - I30978 CC: "robh+dt@kernel.org" , "krzysztof.kozlowski+dt@linaro.org" , Nicolas Ferre - M43238 , "alexandre.belloni@bootlin.com" , "Claudiu Beznea - M18063" , "arnd@arndb.de" , "olof@lixom.net" , "soc@kernel.org" , UNGLinuxDriver , "maxime.chevallier@bootlin.com" , "devicetree@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH 2/2] ARM: dts: lan966x: add support for pcb8309 Message-ID: <20220722124620.khueuxinijmwgot5@soft-dev3-1.localhost> References: <20220720194904.2025384-1-horatiu.vultur@microchip.com> <20220720194904.2025384-3-horatiu.vultur@microchip.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org The 07/21/2022 06:08, Kavyasree Kotagiri - I30978 wrote: > > + i2c-mux { > > + compatible = "i2c-mux"; > > + #address-cells = <1>; > > + #size-cells = <0>; > > + mux-controls = <&mux>; > > + i2c-parent = <&i2c4>; > > + > > + i2c102: i2c-sfp@1 { > > + reg = <1>; > > + #address-cells = <1>; > > + #size-cells = <0>; > > Why do you need #address-cells and #size-cells here? > > + }; > > + > > + i2c103: i2c-sfp@2 { > > + reg = <2>; > > + #address-cells = <1>; > > + #size-cells = <0>; > Same here > > + }; > > + }; They are not needed. I will remove them in the next version. > > + > > + mux: mux-controller { > > + compatible = "gpio-mux"; > > + #mux-control-cells = <0>; > > + > > + mux-gpios = <&sgpio_out 11 0 GPIO_ACTIVE_HIGH>, /* > > p11b0 */ > > + <&sgpio_out 11 1 GPIO_ACTIVE_HIGH>; /* p11b1 > > */ > > + }; ... > > +&i2c4 { > > + compatible = "microchip,sam9x60-i2c"; > > + reg = <0x600 0x200>; > > + interrupts = ; > > + #address-cells = <1>; > > + #size-cells = <0>; > > Same here > Also here. -- /Horatiu