From: Rob Herring <robh@kernel.org>
To: Harini Katakam <harini.katakam@xilinx.com>
Cc: nicolas.ferre@microchip.com, davem@davemloft.net,
claudiu.beznea@microchip.com, kuba@kernel.org,
edumazet@google.com, pabeni@redhat.com,
krzysztof.kozlowski+dt@linaro.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, michal.simek@xilinx.com,
harinikatakamlinux@gmail.com, harini.katakam@amd.com,
devicetree@vger.kernel.org, radhey.shyam.pandey@xilinx.com
Subject: Re: [PATCH v2 1/3] dt-bindings: net: cdns,macb: Add versal compatible string
Date: Mon, 25 Jul 2022 13:33:56 -0600 [thread overview]
Message-ID: <20220725193356.GA2561062-robh@kernel.org> (raw)
In-Reply-To: <20220722110330.13257-2-harini.katakam@xilinx.com>
On Fri, Jul 22, 2022 at 04:33:28PM +0530, Harini Katakam wrote:
> From: Radhey Shyam Pandey <radhey.shyam.pandey@xilinx.com>
>
> Add versal compatible string.
>
> Signed-off-by: Radhey Shyam Pandey <radhey.shyam.pandey@xilinx.com>
> Signed-off-by: Harini Katakam <harini.katakam@xilinx.com>
> ---
> v2:
> Sort compatible string alphabetically.
>
> Documentation/devicetree/bindings/net/cdns,macb.yaml | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/devicetree/bindings/net/cdns,macb.yaml b/Documentation/devicetree/bindings/net/cdns,macb.yaml
> index 9c92156869b2..762deccd3640 100644
> --- a/Documentation/devicetree/bindings/net/cdns,macb.yaml
> +++ b/Documentation/devicetree/bindings/net/cdns,macb.yaml
> @@ -20,6 +20,7 @@ properties:
>
> - items:
> - enum:
> + - cdns,versal-gem # Xilinx Versal
> - cdns,zynq-gem # Xilinx Zynq-7xxx SoC
> - cdns,zynqmp-gem # Xilinx Zynq Ultrascale+ MPSoC
Uh, how did we start this pattern? The vendor here is Xilinx, not
Cadence. It should be xlnx,versal-gem instead.
> - const: cdns,gem # Generic
> --
> 2.17.1
>
>
next prev parent reply other threads:[~2022-07-25 19:34 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-22 11:03 [PATCH v2 0/3] Add Versal compatible string to Macb driver Harini Katakam
2022-07-22 11:03 ` [PATCH v2 1/3] dt-bindings: net: cdns,macb: Add versal compatible string Harini Katakam
2022-07-22 18:31 ` Krzysztof Kozlowski
2022-07-25 19:33 ` Rob Herring [this message]
2022-07-25 19:39 ` Krzysztof Kozlowski
2022-07-26 4:57 ` Katakam, Harini
2022-07-22 11:03 ` [PATCH v2 2/3] net: macb: Sort CAPS flags by bit positions Harini Katakam
2022-07-22 11:10 ` Claudiu.Beznea
2022-07-22 11:03 ` [PATCH v2 3/3] net: macb: Update tsu clk usage in runtime suspend/resume for Versal Harini Katakam
2022-07-25 11:40 ` [PATCH v2 0/3] Add Versal compatible string to Macb driver patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220725193356.GA2561062-robh@kernel.org \
--to=robh@kernel.org \
--cc=claudiu.beznea@microchip.com \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=harini.katakam@amd.com \
--cc=harini.katakam@xilinx.com \
--cc=harinikatakamlinux@gmail.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michal.simek@xilinx.com \
--cc=netdev@vger.kernel.org \
--cc=nicolas.ferre@microchip.com \
--cc=pabeni@redhat.com \
--cc=radhey.shyam.pandey@xilinx.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).