From: Rob Herring <robh@kernel.org>
To: Raphael-Xu <13691752556@139.com>
Cc: alsa-devel@alsa-project.org, raphael-xu@ti.com,
shenghao-ding@ti.com, broonie@kernel.org,
devicetree@vger.kernel.org, kevin-lu@ti.com
Subject: Re: [PATCH v8] ASoc: dt-bindings: tas27xx: revise tas27xx format
Date: Mon, 25 Jul 2022 16:52:37 -0600 [thread overview]
Message-ID: <20220725225237.GA2893298-robh@kernel.org> (raw)
In-Reply-To: <20220722105512.191-1-13691752556@139.com>
On Fri, Jul 22, 2022 at 06:55:12PM +0800, Raphael-Xu wrote:
> revise the format
Complete sentences.
And this is not v8. Each new change is v1.
>
> Signed-off-by: Raphael-Xu <13691752556@139.com>
> ---
> .../devicetree/bindings/sound/tas27xx.yaml | 16 +++++++++++-----
> 1 file changed, 11 insertions(+), 5 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/sound/tas27xx.yaml b/Documentation/devicetree/bindings/sound/tas27xx.yaml
> index 66a0df8850ea..573652577462 100644
> --- a/Documentation/devicetree/bindings/sound/tas27xx.yaml
> +++ b/Documentation/devicetree/bindings/sound/tas27xx.yaml
> @@ -8,7 +8,7 @@ $schema: "http://devicetree.org/meta-schemas/core.yaml#"
> title: Texas Instruments TAS2764/TAS2780 Smart PA
>
> maintainers:
> - - Shenghao Ding <shenghao-ding@ti.com>
> + - Raphael Xu <raphael-xu@ti.com>
>
> description: |
> The TAS2764/TAS2780 is a mono, digital input Class-D audio amplifier
> @@ -23,17 +23,19 @@ properties:
> - ti,tas2780
>
> reg:
> - maxItems: 1
> description: |
> - I2C address of the device can be between 0x38 to 0x45.
0x40-0x45 is no longer valid?
> + I2C address of the device can be between 0x38 to 0x3f.
> + minimum: 0x38
> + maximum: 0x3f
>
> reset-gpios:
> - maxItems: 1
> description: GPIO used to reset the device.
> + maxItems: 1
Unnecessary change.
>
> shutdown-gpios:
> + description: |
Don't need '|' if no formatting.
> + GPIO used to control the state of the device.Only for TAS2764.
Space needed after period.
> maxItems: 1
> - description: GPIO used to control the state of the device.
>
> interrupts:
> maxItems: 1
> @@ -41,10 +43,14 @@ properties:
> ti,imon-slot-no:
> $ref: /schemas/types.yaml#/definitions/uint32
> description: TDM TX current sense time slot.
> + minimum: 0
> + maximum: 3
>
> ti,vmon-slot-no:
> $ref: /schemas/types.yaml#/definitions/uint32
> description: TDM TX voltage sense time slot.
> + minimum: 0
> + maximum: 3
>
> '#sound-dai-cells':
> const: 1
> --
> 2.35.1
>
>
>
prev parent reply other threads:[~2022-07-25 22:52 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-22 10:55 [PATCH v8] ASoc: dt-bindings: tas27xx: revise tas27xx format Raphael-Xu
2022-07-25 22:52 ` Rob Herring [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220725225237.GA2893298-robh@kernel.org \
--to=robh@kernel.org \
--cc=13691752556@139.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=kevin-lu@ti.com \
--cc=raphael-xu@ti.com \
--cc=shenghao-ding@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).