* [PATCH 2/4] media: mediatek: vcodec: add decoder compatible to support mt8188
2022-07-26 4:01 [PATCH 1/4] dt-bindings: media: mediatek: vcodec: add decoder dt-bindings for mt8188 Yunfei Dong
@ 2022-07-26 4:01 ` Yunfei Dong
2022-07-26 8:06 ` AngeloGioacchino Del Regno
2022-07-26 4:01 ` [PATCH 3/4] media: mediatek: vcodec: Add mt8188 decoder's chip name Yunfei Dong
` (2 subsequent siblings)
3 siblings, 1 reply; 9+ messages in thread
From: Yunfei Dong @ 2022-07-26 4:01 UTC (permalink / raw)
To: Yunfei Dong, Chen-Yu Tsai, Nicolas Dufresne, Hans Verkuil,
AngeloGioacchino Del Regno, Benjamin Gaignard, Tiffany Lin,
Andrew-CT Chen
Cc: Mauro Carvalho Chehab, Rob Herring, Matthias Brugger, George Sun,
Xiaoyong Lu, Hsin-Yi Wang, Fritz Koenig, Daniel Vetter, Irui Wang,
Steve Cho, linux-media, devicetree, linux-kernel,
linux-arm-kernel, linux-mediatek,
Project_Global_Chrome_Upstream_Group
1: add mt8188's compatible name: mediatek,mt8188-vcodec-dec.
2: mt8188 is lat single core architecture, using mtk_lat_sig_core_pdata to
initialize private data.
Signed-off-by: Yunfei Dong <yunfei.dong@mediatek.com>
---
drivers/media/platform/mediatek/vcodec/mtk_vcodec_dec_drv.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/drivers/media/platform/mediatek/vcodec/mtk_vcodec_dec_drv.c b/drivers/media/platform/mediatek/vcodec/mtk_vcodec_dec_drv.c
index e0b6ae9d6caa..174a6eec2f54 100644
--- a/drivers/media/platform/mediatek/vcodec/mtk_vcodec_dec_drv.c
+++ b/drivers/media/platform/mediatek/vcodec/mtk_vcodec_dec_drv.c
@@ -478,6 +478,10 @@ static const struct of_device_id mtk_vcodec_match[] = {
.compatible = "mediatek,mt8195-vcodec-dec",
.data = &mtk_lat_sig_core_pdata,
},
+ {
+ .compatible = "mediatek,mt8188-vcodec-dec",
+ .data = &mtk_lat_sig_core_pdata,
+ },
{},
};
--
2.25.1
^ permalink raw reply related [flat|nested] 9+ messages in thread* Re: [PATCH 2/4] media: mediatek: vcodec: add decoder compatible to support mt8188
2022-07-26 4:01 ` [PATCH 2/4] media: mediatek: vcodec: add decoder compatible to support mt8188 Yunfei Dong
@ 2022-07-26 8:06 ` AngeloGioacchino Del Regno
0 siblings, 0 replies; 9+ messages in thread
From: AngeloGioacchino Del Regno @ 2022-07-26 8:06 UTC (permalink / raw)
To: Yunfei Dong, Chen-Yu Tsai, Nicolas Dufresne, Hans Verkuil,
Benjamin Gaignard, Tiffany Lin, Andrew-CT Chen
Cc: Mauro Carvalho Chehab, Rob Herring, Matthias Brugger, George Sun,
Xiaoyong Lu, Hsin-Yi Wang, Fritz Koenig, Daniel Vetter, Irui Wang,
Steve Cho, linux-media, devicetree, linux-kernel,
linux-arm-kernel, linux-mediatek,
Project_Global_Chrome_Upstream_Group
Il 26/07/22 06:01, Yunfei Dong ha scritto:
> 1: add mt8188's compatible name: mediatek,mt8188-vcodec-dec.
> 2: mt8188 is lat single core architecture, using mtk_lat_sig_core_pdata to
> initialize private data.
>
> Signed-off-by: Yunfei Dong <yunfei.dong@mediatek.com>
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH 3/4] media: mediatek: vcodec: Add mt8188 decoder's chip name
2022-07-26 4:01 [PATCH 1/4] dt-bindings: media: mediatek: vcodec: add decoder dt-bindings for mt8188 Yunfei Dong
2022-07-26 4:01 ` [PATCH 2/4] media: mediatek: vcodec: add decoder compatible to support mt8188 Yunfei Dong
@ 2022-07-26 4:01 ` Yunfei Dong
2022-07-26 8:28 ` Chen-Yu Tsai
2022-07-26 4:01 ` [PATCH 4/4] media: mediatek: vcodec: Add mt8188 encoder's " Yunfei Dong
2022-07-26 8:06 ` [PATCH 1/4] dt-bindings: media: mediatek: vcodec: add decoder dt-bindings for mt8188 AngeloGioacchino Del Regno
3 siblings, 1 reply; 9+ messages in thread
From: Yunfei Dong @ 2022-07-26 4:01 UTC (permalink / raw)
To: Yunfei Dong, Chen-Yu Tsai, Nicolas Dufresne, Hans Verkuil,
AngeloGioacchino Del Regno, Benjamin Gaignard, Tiffany Lin,
Andrew-CT Chen
Cc: Mauro Carvalho Chehab, Rob Herring, Matthias Brugger, George Sun,
Xiaoyong Lu, Hsin-Yi Wang, Fritz Koenig, Daniel Vetter, Irui Wang,
Steve Cho, linux-media, devicetree, linux-kernel,
linux-arm-kernel, linux-mediatek,
Project_Global_Chrome_Upstream_Group
Getting mt8188's chip name according to decoder compatible name.
Signed-off-by: Yunfei Dong <yunfei.dong@mediatek.com>
---
drivers/media/platform/mediatek/vcodec/mtk_vcodec_dec.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/media/platform/mediatek/vcodec/mtk_vcodec_dec.c b/drivers/media/platform/mediatek/vcodec/mtk_vcodec_dec.c
index 7d194a476713..641f533c417f 100644
--- a/drivers/media/platform/mediatek/vcodec/mtk_vcodec_dec.c
+++ b/drivers/media/platform/mediatek/vcodec/mtk_vcodec_dec.c
@@ -227,6 +227,8 @@ static int mtk_vcodec_dec_get_chip_name(void *priv)
return 8195;
else if (of_device_is_compatible(dev->of_node, "mediatek,mt8186-vcodec-dec"))
return 8186;
+ else if (of_device_is_compatible(dev->of_node, "mediatek,mt8188-vcodec-dec"))
+ return 8188;
else
return 8173;
}
--
2.25.1
^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH 3/4] media: mediatek: vcodec: Add mt8188 decoder's chip name
2022-07-26 4:01 ` [PATCH 3/4] media: mediatek: vcodec: Add mt8188 decoder's chip name Yunfei Dong
@ 2022-07-26 8:28 ` Chen-Yu Tsai
2022-07-26 11:34 ` yunfei.dong
0 siblings, 1 reply; 9+ messages in thread
From: Chen-Yu Tsai @ 2022-07-26 8:28 UTC (permalink / raw)
To: Yunfei Dong
Cc: Nicolas Dufresne, Hans Verkuil, AngeloGioacchino Del Regno,
Benjamin Gaignard, Tiffany Lin, Andrew-CT Chen,
Mauro Carvalho Chehab, Rob Herring, Matthias Brugger, George Sun,
Xiaoyong Lu, Hsin-Yi Wang, Fritz Koenig, Daniel Vetter, Irui Wang,
Steve Cho, linux-media, devicetree, linux-kernel,
linux-arm-kernel, linux-mediatek,
Project_Global_Chrome_Upstream_Group
On Tue, Jul 26, 2022 at 12:02 PM Yunfei Dong <yunfei.dong@mediatek.com> wrote:
>
> Getting mt8188's chip name according to decoder compatible name.
>
> Signed-off-by: Yunfei Dong <yunfei.dong@mediatek.com>
This should be squashed with the previous patch adding the compatible
to the driver.
> ---
> drivers/media/platform/mediatek/vcodec/mtk_vcodec_dec.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/media/platform/mediatek/vcodec/mtk_vcodec_dec.c b/drivers/media/platform/mediatek/vcodec/mtk_vcodec_dec.c
> index 7d194a476713..641f533c417f 100644
> --- a/drivers/media/platform/mediatek/vcodec/mtk_vcodec_dec.c
> +++ b/drivers/media/platform/mediatek/vcodec/mtk_vcodec_dec.c
> @@ -227,6 +227,8 @@ static int mtk_vcodec_dec_get_chip_name(void *priv)
> return 8195;
> else if (of_device_is_compatible(dev->of_node, "mediatek,mt8186-vcodec-dec"))
> return 8186;
> + else if (of_device_is_compatible(dev->of_node, "mediatek,mt8188-vcodec-dec"))
> + return 8188;
> else
> return 8173;
> }
> --
> 2.25.1
>
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 3/4] media: mediatek: vcodec: Add mt8188 decoder's chip name
2022-07-26 8:28 ` Chen-Yu Tsai
@ 2022-07-26 11:34 ` yunfei.dong
0 siblings, 0 replies; 9+ messages in thread
From: yunfei.dong @ 2022-07-26 11:34 UTC (permalink / raw)
To: Chen-Yu Tsai
Cc: Nicolas Dufresne, Hans Verkuil, AngeloGioacchino Del Regno,
Benjamin Gaignard, Tiffany Lin, Andrew-CT Chen,
Mauro Carvalho Chehab, Rob Herring, Matthias Brugger, George Sun,
Xiaoyong Lu, Hsin-Yi Wang, Fritz Koenig, Daniel Vetter, Irui Wang,
Steve Cho, linux-media, devicetree, linux-kernel,
linux-arm-kernel, linux-mediatek,
Project_Global_Chrome_Upstream_Group
Hi Chen-Yu,
Thanks for your suggestion.
I will merge patch 3 and 2 into one patch in v2.
Best Regards,
Yunfei DOng
On Tue, 2022-07-26 at 16:28 +0800, Chen-Yu Tsai wrote:
> On Tue, Jul 26, 2022 at 12:02 PM Yunfei Dong <
> yunfei.dong@mediatek.com> wrote:
> >
> > Getting mt8188's chip name according to decoder compatible name.
> >
> > Signed-off-by: Yunfei Dong <yunfei.dong@mediatek.com>
>
> This should be squashed with the previous patch adding the compatible
> to the driver.
>
> > ---
> > drivers/media/platform/mediatek/vcodec/mtk_vcodec_dec.c | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git
> > a/drivers/media/platform/mediatek/vcodec/mtk_vcodec_dec.c
> > b/drivers/media/platform/mediatek/vcodec/mtk_vcodec_dec.c
> > index 7d194a476713..641f533c417f 100644
> > --- a/drivers/media/platform/mediatek/vcodec/mtk_vcodec_dec.c
> > +++ b/drivers/media/platform/mediatek/vcodec/mtk_vcodec_dec.c
> > @@ -227,6 +227,8 @@ static int mtk_vcodec_dec_get_chip_name(void
> > *priv)
> > return 8195;
> > else if (of_device_is_compatible(dev->of_node,
> > "mediatek,mt8186-vcodec-dec"))
> > return 8186;
> > + else if (of_device_is_compatible(dev->of_node,
> > "mediatek,mt8188-vcodec-dec"))
> > + return 8188;
> > else
> > return 8173;
> > }
> > --
> > 2.25.1
> >
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH 4/4] media: mediatek: vcodec: Add mt8188 encoder's chip name
2022-07-26 4:01 [PATCH 1/4] dt-bindings: media: mediatek: vcodec: add decoder dt-bindings for mt8188 Yunfei Dong
2022-07-26 4:01 ` [PATCH 2/4] media: mediatek: vcodec: add decoder compatible to support mt8188 Yunfei Dong
2022-07-26 4:01 ` [PATCH 3/4] media: mediatek: vcodec: Add mt8188 decoder's chip name Yunfei Dong
@ 2022-07-26 4:01 ` Yunfei Dong
2022-07-26 8:06 ` AngeloGioacchino Del Regno
2022-07-26 8:06 ` [PATCH 1/4] dt-bindings: media: mediatek: vcodec: add decoder dt-bindings for mt8188 AngeloGioacchino Del Regno
3 siblings, 1 reply; 9+ messages in thread
From: Yunfei Dong @ 2022-07-26 4:01 UTC (permalink / raw)
To: Yunfei Dong, Chen-Yu Tsai, Nicolas Dufresne, Hans Verkuil,
AngeloGioacchino Del Regno, Benjamin Gaignard, Tiffany Lin,
Andrew-CT Chen
Cc: Mauro Carvalho Chehab, Rob Herring, Matthias Brugger, George Sun,
Xiaoyong Lu, Hsin-Yi Wang, Fritz Koenig, Daniel Vetter, Irui Wang,
Steve Cho, linux-media, devicetree, linux-kernel,
linux-arm-kernel, linux-mediatek,
Project_Global_Chrome_Upstream_Group
Getting mt8188's chip name according to encoder compatible name.
Signed-off-by: Yunfei Dong <yunfei.dong@mediatek.com>
---
drivers/media/platform/mediatek/vcodec/mtk_vcodec_enc.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/media/platform/mediatek/vcodec/mtk_vcodec_enc.c b/drivers/media/platform/mediatek/vcodec/mtk_vcodec_enc.c
index 25e816863597..75454b955638 100644
--- a/drivers/media/platform/mediatek/vcodec/mtk_vcodec_enc.c
+++ b/drivers/media/platform/mediatek/vcodec/mtk_vcodec_enc.c
@@ -225,6 +225,8 @@ static int mtk_vcodec_enc_get_chip_name(void *priv)
return 8192;
else if (of_device_is_compatible(dev->of_node, "mediatek,mt8195-vcodec-enc"))
return 8195;
+ else if (of_device_is_compatible(dev->of_node, "mediatek,mt8188-vcodec-enc"))
+ return 8188;
else
return 8173;
}
--
2.25.1
^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH 4/4] media: mediatek: vcodec: Add mt8188 encoder's chip name
2022-07-26 4:01 ` [PATCH 4/4] media: mediatek: vcodec: Add mt8188 encoder's " Yunfei Dong
@ 2022-07-26 8:06 ` AngeloGioacchino Del Regno
0 siblings, 0 replies; 9+ messages in thread
From: AngeloGioacchino Del Regno @ 2022-07-26 8:06 UTC (permalink / raw)
To: Yunfei Dong, Chen-Yu Tsai, Nicolas Dufresne, Hans Verkuil,
Benjamin Gaignard, Tiffany Lin, Andrew-CT Chen
Cc: Mauro Carvalho Chehab, Rob Herring, Matthias Brugger, George Sun,
Xiaoyong Lu, Hsin-Yi Wang, Fritz Koenig, Daniel Vetter, Irui Wang,
Steve Cho, linux-media, devicetree, linux-kernel,
linux-arm-kernel, linux-mediatek,
Project_Global_Chrome_Upstream_Group
Il 26/07/22 06:01, Yunfei Dong ha scritto:
> Getting mt8188's chip name according to encoder compatible name.
>
> Signed-off-by: Yunfei Dong <yunfei.dong@mediatek.com>
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 1/4] dt-bindings: media: mediatek: vcodec: add decoder dt-bindings for mt8188
2022-07-26 4:01 [PATCH 1/4] dt-bindings: media: mediatek: vcodec: add decoder dt-bindings for mt8188 Yunfei Dong
` (2 preceding siblings ...)
2022-07-26 4:01 ` [PATCH 4/4] media: mediatek: vcodec: Add mt8188 encoder's " Yunfei Dong
@ 2022-07-26 8:06 ` AngeloGioacchino Del Regno
3 siblings, 0 replies; 9+ messages in thread
From: AngeloGioacchino Del Regno @ 2022-07-26 8:06 UTC (permalink / raw)
To: Yunfei Dong, Chen-Yu Tsai, Nicolas Dufresne, Hans Verkuil,
Benjamin Gaignard, Tiffany Lin, Andrew-CT Chen
Cc: Mauro Carvalho Chehab, Rob Herring, Matthias Brugger, George Sun,
Xiaoyong Lu, Hsin-Yi Wang, Fritz Koenig, Daniel Vetter, Irui Wang,
Steve Cho, linux-media, devicetree, linux-kernel,
linux-arm-kernel, linux-mediatek,
Project_Global_Chrome_Upstream_Group
Il 26/07/22 06:01, Yunfei Dong ha scritto:
> Add decoder document in dt-bindings yaml file for mt8188 platform.
>
> Signed-off-by: Yunfei Dong <yunfei.dong@mediatek.com>
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
^ permalink raw reply [flat|nested] 9+ messages in thread