From: Stephen Boyd <sboyd@kernel.org>
To: Bjorn Andersson <bjorn.andersson@linaro.org>,
Michael Turquette <mturquette@baylibre.com>,
Satya Priya <quic_c_skakit@quicinc.com>
Cc: linux-arm-msm@vger.kernel.org, linux-soc@vger.kernel.org,
linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org, robh@kernel.org, robh+dt@kernel.org,
quic_tdas@quicinc.com, quic_c_skakit@quicinc.com
Subject: Re: [PATCH V6 5/5] clk: qcom: lpass: Add support for resets & external mclk for SC7280
Date: Tue, 26 Jul 2022 18:31:58 -0700 [thread overview]
Message-ID: <20220727013200.90E37C433C1@smtp.kernel.org> (raw)
In-Reply-To: <1658315023-3336-6-git-send-email-quic_c_skakit@quicinc.com>
Quoting Satya Priya (2022-07-20 04:03:43)
> From: Taniya Das <quic_tdas@quicinc.com>
>
> The clock gating control for TX/RX/WSA core bus clocks would be required
> to be reset(moved from hardware control) from audio core driver. Thus
> add the support for the reset clocks.
>
> Also add the external mclk to interface external MI2S.
>
> Fixes: a9dd26639d05 ("clk: qcom: lpass: Add support for LPASS clock controller for SC7280").
> Signed-off-by: Taniya Das <quic_tdas@quicinc.com>
> ---
> drivers/clk/qcom/lpassaudiocc-sc7280.c | 22 +++++++++++++++++++++-
> drivers/clk/qcom/lpasscorecc-sc7280.c | 33 +++++++++++++++++++++++++++++++++
> 2 files changed, 54 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/clk/qcom/lpassaudiocc-sc7280.c b/drivers/clk/qcom/lpassaudiocc-sc7280.c
> index 6067328..063e036 100644
> --- a/drivers/clk/qcom/lpassaudiocc-sc7280.c
> +++ b/drivers/clk/qcom/lpassaudiocc-sc7280.c
> @@ -23,6 +23,7 @@
> #include "clk-regmap-mux.h"
> #include "common.h"
> #include "gdsc.h"
> +#include "reset.h"
>
> enum {
> P_BI_TCXO,
> @@ -248,7 +249,7 @@ static struct clk_rcg2 lpass_aon_cc_main_rcg_clk_src = {
> .parent_data = lpass_aon_cc_parent_data_0,
> .num_parents = ARRAY_SIZE(lpass_aon_cc_parent_data_0),
> .flags = CLK_OPS_PARENT_ENABLE,
> - .ops = &clk_rcg2_ops,
> + .ops = &clk_rcg2_shared_ops,
This diff isn't mentioned in the commit text at all. Is it intentional?
If so, please mention why it needs to change.
next prev parent reply other threads:[~2022-07-27 1:32 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-20 11:03 [PATCH V6 0/5] Add support for audio clock gating resets for SC7280 Satya Priya
2022-07-20 11:03 ` [PATCH V6 1/5] dt-bindings: clock: Add "qcom,adsp-pil-mode" property Satya Priya
2022-07-25 22:24 ` Rob Herring
2022-07-27 1:27 ` Stephen Boyd
2022-07-20 11:03 ` [PATCH V6 2/5] clk: qcom: lpass: Handle the regmap overlap of lpasscc and lpass_aon Satya Priya
2022-07-27 1:28 ` Stephen Boyd
2022-07-20 11:03 ` [PATCH V6 3/5] dt-bindings: clock: Add resets for LPASS audio clock controller for SC7280 Satya Priya
2022-07-27 1:29 ` Stephen Boyd
2022-07-27 1:30 ` Stephen Boyd
2022-07-27 5:53 ` Satya Priya Kakitapalli (Temp)
2022-07-20 11:03 ` [PATCH V6 4/5] dt-bindings: clock: Add support for external MCLKs for LPASS on SC7280 Satya Priya
2022-07-20 11:03 ` [PATCH V6 5/5] clk: qcom: lpass: Add support for resets & external mclk for SC7280 Satya Priya
2022-07-27 1:31 ` Stephen Boyd [this message]
2022-07-27 5:58 ` Satya Priya Kakitapalli (Temp)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220727013200.90E37C433C1@smtp.kernel.org \
--to=sboyd@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-soc@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=quic_c_skakit@quicinc.com \
--cc=quic_tdas@quicinc.com \
--cc=robh+dt@kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).