[PATCH v1 0/2] char: ipmi: kcs: add Arbel NPCM8XX support

[PATCH v1 0/2] char: ipmi: kcs: add Arbel NPCM8XX support

[Tomer Maimon]

This patch set adds Arbel NPCM8XX Keyboard Controller Style (KCS) support to 
KCS NPCM driver.

The NPCM KCS driver tested on NPCM845 evaluation board.

Tomer Maimon (2):
  dt-bindings: ipmi: Add npcm845 compatible
  char: ipmi: modify NPCM KCS configuration

 Documentation/devicetree/bindings/ipmi/npcm7xx-kcs-bmc.txt | 5 +++--
 drivers/char/ipmi/Kconfig                                  | 6 +++---
 2 files changed, 6 insertions(+), 5 deletions(-)

-- 
2.33.0

[PATCH v1 1/2] dt-bindings: ipmi: Add npcm845 compatible

[Tomer Maimon]

Add a compatible string for Nuvoton BMC NPCM845 KCS and modify NPCM KCS
description to support all NPCM BMC SoC.

Signed-off-by: Tomer Maimon <tmaimon77@gmail.com>
---
 Documentation/devicetree/bindings/ipmi/npcm7xx-kcs-bmc.txt | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/Documentation/devicetree/bindings/ipmi/npcm7xx-kcs-bmc.txt b/Documentation/devicetree/bindings/ipmi/npcm7xx-kcs-bmc.txt
index 352f5e9c759b..cbc10a68ddef 100644
--- a/Documentation/devicetree/bindings/ipmi/npcm7xx-kcs-bmc.txt
+++ b/Documentation/devicetree/bindings/ipmi/npcm7xx-kcs-bmc.txt
@@ -1,12 +1,13 @@
-* Nuvoton NPCM7xx KCS (Keyboard Controller Style) IPMI interface
+* Nuvoton NPCM KCS (Keyboard Controller Style) IPMI interface
 
-The Nuvoton SOCs (NPCM7xx) are commonly used as BMCs
+The Nuvoton SOCs (NPCM) are commonly used as BMCs
 (Baseboard Management Controllers) and the KCS interface can be
 used to perform in-band IPMI communication with their host.
 
 Required properties:
 - compatible : should be one of
     "nuvoton,npcm750-kcs-bmc"
+    "nuvoton,npcm845-kcs-bmc"
 - interrupts : interrupt generated by the controller
 - kcs_chan : The KCS channel number in the controller
 
-- 
2.33.0

Re: [PATCH v1 1/2] dt-bindings: ipmi: Add npcm845 compatible

[Krzysztof Kozlowski]

On 17/07/2022 14:11, Tomer Maimon wrote:
> Add a compatible string for Nuvoton BMC NPCM845 KCS and modify NPCM KCS
> description to support all NPCM BMC SoC.
> 
> Signed-off-by: Tomer Maimon <tmaimon77@gmail.com>


Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>


Best regards,
Krzysztof

[PATCH v1 2/2] char: ipmi: modify NPCM KCS configuration

[Tomer Maimon]

Modify NPCM IPMI KCS configuration to support all NPCM BMC SoC.

Signed-off-by: Tomer Maimon <tmaimon77@gmail.com>
---
 drivers/char/ipmi/Kconfig | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/char/ipmi/Kconfig b/drivers/char/ipmi/Kconfig
index b061e6b513ed..39565cf74b2c 100644
--- a/drivers/char/ipmi/Kconfig
+++ b/drivers/char/ipmi/Kconfig
@@ -119,13 +119,13 @@ config ASPEED_KCS_IPMI_BMC
 	  provides the access of KCS IO space for BMC side.
 
 config NPCM7XX_KCS_IPMI_BMC
-	depends on ARCH_NPCM7XX || COMPILE_TEST
+	depends on ARCH_NPCM || COMPILE_TEST
 	select IPMI_KCS_BMC
 	select REGMAP_MMIO
-	tristate "NPCM7xx KCS IPMI BMC driver"
+	tristate "NPCM KCS IPMI BMC driver"
 	help
 	  Provides a driver for the KCS (Keyboard Controller Style) IPMI
-	  interface found on Nuvoton NPCM7xx SOCs.
+	  interface found on Nuvoton NPCM SOCs.
 
 	  The driver implements the BMC side of the KCS contorller, it
 	  provides the access of KCS IO space for BMC side.
-- 
2.33.0

Re: [PATCH v1 0/2] char: ipmi: kcs: add Arbel NPCM8XX support

[Corey Minyard]

On Sun, Jul 17, 2022 at 03:11:22PM +0300, Tomer Maimon wrote:
> This patch set adds Arbel NPCM8XX Keyboard Controller Style (KCS) support to 
> KCS NPCM driver.
> 
> The NPCM KCS driver tested on NPCM845 evaluation board.

This seems reasonable, I've pulled it into my tree.  If anyone has any
issues with this, please respond.

-corey

> 
> Tomer Maimon (2):
>   dt-bindings: ipmi: Add npcm845 compatible
>   char: ipmi: modify NPCM KCS configuration
> 
>  Documentation/devicetree/bindings/ipmi/npcm7xx-kcs-bmc.txt | 5 +++--
>  drivers/char/ipmi/Kconfig                                  | 6 +++---
>  2 files changed, 6 insertions(+), 5 deletions(-)
> 
> -- 
> 2.33.0
> 

Re: [PATCH v1 0/2] char: ipmi: kcs: add Arbel NPCM8XX support

[Tomer Maimon]

Hi Corey,


On Mon, 18 Jul 2022 at 15:51, Corey Minyard <minyard@acm.org> wrote:
>
> On Sun, Jul 17, 2022 at 03:11:22PM +0300, Tomer Maimon wrote:
> > This patch set adds Arbel NPCM8XX Keyboard Controller Style (KCS) support to
> > KCS NPCM driver.
> >
> > The NPCM KCS driver tested on NPCM845 evaluation board.
>
> This seems reasonable, I've pulled it into my tree.  If anyone has any
> issues with this, please respond.
>
> -corey
>
> >
> > Tomer Maimon (2):
> >   dt-bindings: ipmi: Add npcm845 compatible
> >   char: ipmi: modify NPCM KCS configuration
> >
> >  Documentation/devicetree/bindings/ipmi/npcm7xx-kcs-bmc.txt | 5 +++--
> >  drivers/char/ipmi/Kconfig                                  | 6 +++---
> >  2 files changed, 6 insertions(+), 5 deletions(-)
> >
> > --
> > 2.33.0
> >

Sorry but I need to do a little fix in the document file.

Can I do it or have you already applied the patches?

Thanks,

Tomer

Re: [PATCH v1 0/2] char: ipmi: kcs: add Arbel NPCM8XX support

[Corey Minyard]

On Tue, Jul 26, 2022 at 10:41:38PM +0300, Tomer Maimon wrote:
> Hi Corey,
> 
> 
> On Mon, 18 Jul 2022 at 15:51, Corey Minyard <minyard@acm.org> wrote:
> >
> > On Sun, Jul 17, 2022 at 03:11:22PM +0300, Tomer Maimon wrote:
> > > This patch set adds Arbel NPCM8XX Keyboard Controller Style (KCS) support to
> > > KCS NPCM driver.
> > >
> > > The NPCM KCS driver tested on NPCM845 evaluation board.
> >
> > This seems reasonable, I've pulled it into my tree.  If anyone has any
> > issues with this, please respond.
> >
> > -corey
> >
> > >
> > > Tomer Maimon (2):
> > >   dt-bindings: ipmi: Add npcm845 compatible
> > >   char: ipmi: modify NPCM KCS configuration
> > >
> > >  Documentation/devicetree/bindings/ipmi/npcm7xx-kcs-bmc.txt | 5 +++--
> > >  drivers/char/ipmi/Kconfig                                  | 6 +++---
> > >  2 files changed, 6 insertions(+), 5 deletions(-)
> > >
> > > --
> > > 2.33.0
> > >
> 
> Sorry but I need to do a little fix in the document file.
> 
> Can I do it or have you already applied the patches?

At this point I'd prefer a patch on top of what is there.  5.19 isn't
released yet, so the window isn't open, but that will happen soon and I
don't want to rebase at this point.

-corey

> 
> Thanks,
> 
> Tomer

Re: [PATCH v1 0/2] char: ipmi: kcs: add Arbel NPCM8XX support

[Tomer Maimon]

Hi Corey,

On Tue, 26 Jul 2022 at 22:47, Corey Minyard <minyard@acm.org> wrote:
>
> On Tue, Jul 26, 2022 at 10:41:38PM +0300, Tomer Maimon wrote:
> > Hi Corey,
> >
> >
> > On Mon, 18 Jul 2022 at 15:51, Corey Minyard <minyard@acm.org> wrote:
> > >
> > > On Sun, Jul 17, 2022 at 03:11:22PM +0300, Tomer Maimon wrote:
> > > > This patch set adds Arbel NPCM8XX Keyboard Controller Style (KCS) support to
> > > > KCS NPCM driver.
> > > >
> > > > The NPCM KCS driver tested on NPCM845 evaluation board.
> > >
> > > This seems reasonable, I've pulled it into my tree.  If anyone has any
> > > issues with this, please respond.
> > >
> > > -corey
> > >
> > > >
> > > > Tomer Maimon (2):
> > > >   dt-bindings: ipmi: Add npcm845 compatible
> > > >   char: ipmi: modify NPCM KCS configuration
> > > >
> > > >  Documentation/devicetree/bindings/ipmi/npcm7xx-kcs-bmc.txt | 5 +++--
> > > >  drivers/char/ipmi/Kconfig                                  | 6 +++---
> > > >  2 files changed, 6 insertions(+), 5 deletions(-)
> > > >
> > > > --
> > > > 2.33.0
> > > >
> >
> > Sorry but I need to do a little fix in the document file.
> >
> > Can I do it or have you already applied the patches?
>
> At this point I'd prefer a patch on top of what is there.  5.19 isn't
> released yet, so the window isn't open, but that will happen soon and I
> don't want to rebase at this point.
O.K. thanks,
I will wait until 5.19 is released and then I will send the patch.
>
> -corey
>
> >
> > Thanks,
> >
> > Tomer

Best regards,

Tomer

Re: [PATCH v1 0/2] char: ipmi: kcs: add Arbel NPCM8XX support

[Corey Minyard]

On Wed, Jul 27, 2022 at 08:39:08AM +0300, Tomer Maimon wrote:
> Hi Corey,
> 
> On Tue, 26 Jul 2022 at 22:47, Corey Minyard <minyard@acm.org> wrote:
> >
> > On Tue, Jul 26, 2022 at 10:41:38PM +0300, Tomer Maimon wrote:
> > > Hi Corey,
> > >
> > >
> > > On Mon, 18 Jul 2022 at 15:51, Corey Minyard <minyard@acm.org> wrote:
> > > >
> > > > On Sun, Jul 17, 2022 at 03:11:22PM +0300, Tomer Maimon wrote:
> > > > > This patch set adds Arbel NPCM8XX Keyboard Controller Style (KCS) support to
> > > > > KCS NPCM driver.
> > > > >
> > > > > The NPCM KCS driver tested on NPCM845 evaluation board.
> > > >
> > > > This seems reasonable, I've pulled it into my tree.  If anyone has any
> > > > issues with this, please respond.
> > > >
> > > > -corey
> > > >
> > > > >
> > > > > Tomer Maimon (2):
> > > > >   dt-bindings: ipmi: Add npcm845 compatible
> > > > >   char: ipmi: modify NPCM KCS configuration
> > > > >
> > > > >  Documentation/devicetree/bindings/ipmi/npcm7xx-kcs-bmc.txt | 5 +++--
> > > > >  drivers/char/ipmi/Kconfig                                  | 6 +++---
> > > > >  2 files changed, 6 insertions(+), 5 deletions(-)
> > > > >
> > > > > --
> > > > > 2.33.0
> > > > >
> > >
> > > Sorry but I need to do a little fix in the document file.
> > >
> > > Can I do it or have you already applied the patches?
> >
> > At this point I'd prefer a patch on top of what is there.  5.19 isn't
> > released yet, so the window isn't open, but that will happen soon and I
> > don't want to rebase at this point.
> O.K. thanks,
> I will wait until 5.19 is released and then I will send the patch.

Oh, sorry I wasn't clear.  You can send it now, I just don't want to
rebase what I have already.  Just a new patch on top of it, and I'll get
it in to 5.19.

-corey

Re: [PATCH v1 0/2] char: ipmi: kcs: add Arbel NPCM8XX support

[Tomer Maimon]

Hi Corey,

Sorry, miss this email...

On Wed, 27 Jul 2022 at 18:47, Corey Minyard <minyard@acm.org> wrote:
>
> On Wed, Jul 27, 2022 at 08:39:08AM +0300, Tomer Maimon wrote:
> > Hi Corey,
> >
> > On Tue, 26 Jul 2022 at 22:47, Corey Minyard <minyard@acm.org> wrote:
> > >
> > > On Tue, Jul 26, 2022 at 10:41:38PM +0300, Tomer Maimon wrote:
> > > > Hi Corey,
> > > >
> > > >
> > > > On Mon, 18 Jul 2022 at 15:51, Corey Minyard <minyard@acm.org> wrote:
> > > > >
> > > > > On Sun, Jul 17, 2022 at 03:11:22PM +0300, Tomer Maimon wrote:
> > > > > > This patch set adds Arbel NPCM8XX Keyboard Controller Style (KCS) support to
> > > > > > KCS NPCM driver.
> > > > > >
> > > > > > The NPCM KCS driver tested on NPCM845 evaluation board.
> > > > >
> > > > > This seems reasonable, I've pulled it into my tree.  If anyone has any
> > > > > issues with this, please respond.
> > > > >
> > > > > -corey
> > > > >
> > > > > >
> > > > > > Tomer Maimon (2):
> > > > > >   dt-bindings: ipmi: Add npcm845 compatible
> > > > > >   char: ipmi: modify NPCM KCS configuration
> > > > > >
> > > > > >  Documentation/devicetree/bindings/ipmi/npcm7xx-kcs-bmc.txt | 5 +++--
> > > > > >  drivers/char/ipmi/Kconfig                                  | 6 +++---
> > > > > >  2 files changed, 6 insertions(+), 5 deletions(-)
> > > > > >
> > > > > > --
> > > > > > 2.33.0
> > > > > >
> > > >
> > > > Sorry but I need to do a little fix in the document file.
> > > >
> > > > Can I do it or have you already applied the patches?
> > >
> > > At this point I'd prefer a patch on top of what is there.  5.19 isn't
> > > released yet, so the window isn't open, but that will happen soon and I
> > > don't want to rebase at this point.
> > O.K. thanks,
> > I will wait until 5.19 is released and then I will send the patch.
>
> Oh, sorry I wasn't clear.  You can send it now, I just don't want to
> rebase what I have already.  Just a new patch on top of it, and I'll get
> it in to 5.19.
>
> -corey

Sent a patch now.

Best regards,

Tomer