From: Stephen Boyd <sboyd@kernel.org>
To: Robert Marko <robimarko@gmail.com>
Cc: Abhishek Sahu <absahu@codeaurora.org>,
Andy Gross <agross@kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Devicetree List <devicetree@vger.kernel.org>,
Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
krzysztof.kozlowski+dt@linaro.org,
linux-arm-msm <linux-arm-msm@vger.kernel.org>,
linux-clk@vger.kernel.org,
open list <linux-kernel@vger.kernel.org>,
Michael Turquette <mturquette@baylibre.com>,
Rob Herring <robh+dt@kernel.org>,
tdas@codeaurora.org
Subject: Re: [PATCH v4 10/11] clk: qcom: ipq8074: dont disable gcc_sleep_clk_src
Date: Fri, 29 Jul 2022 16:27:48 -0700 [thread overview]
Message-ID: <20220729232750.8EAADC433D6@smtp.kernel.org> (raw)
In-Reply-To: <CAOX2RU7NaJL5dTrjz26oiz0psvXKV8C-7HGMmJ-rfNJ3r=y2qg@mail.gmail.com>
Quoting Robert Marko (2022-07-11 14:14:38)
> On Mon, 11 Jul 2022 at 23:10, Stephen Boyd <sboyd@kernel.org> wrote:
> >
> > Quoting Robert Marko (2022-05-15 14:00:47)
> > > diff --git a/drivers/clk/qcom/gcc-ipq8074.c b/drivers/clk/qcom/gcc-ipq8074.c
> > > index 3204d550ff76..42d185fe19c8 100644
> > > --- a/drivers/clk/qcom/gcc-ipq8074.c
> > > +++ b/drivers/clk/qcom/gcc-ipq8074.c
> > > @@ -663,6 +663,7 @@ static struct clk_branch gcc_sleep_clk_src = {
> > > },
> > > .num_parents = 1,
> > > .ops = &clk_branch2_ops,
> > > + .flags = CLK_IS_CRITICAL,
> > > },
> >
> > Why not just remove the clk from the driver? Is anything using it?
>
> Hi Stephen, USB sleep clocks are derived from it so it cant be dropped.
>
And we can't return NULL clks to USB for the sleep clk?
next prev parent reply other threads:[~2022-07-29 23:27 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-15 21:00 [PATCH v4 01/11] clk: qcom: ipq8074: fix NSS core PLL-s Robert Marko
2022-05-15 21:00 ` [PATCH v4 02/11] clk: qcom: ipq8074: SW workaround for UBI32 PLL lock Robert Marko
2022-05-15 21:00 ` [PATCH v4 03/11] clk: qcom: ipq8074: fix NSS port frequency tables Robert Marko
2022-05-15 21:00 ` [PATCH v4 04/11] dt-bindings: clock: qcom: ipq8074: add PPE crypto clock Robert Marko
2022-05-15 21:00 ` [PATCH v4 05/11] clk: " Robert Marko
2022-05-15 21:00 ` [PATCH v4 06/11] clk: qcom: ipq8074: set BRANCH_HALT_DELAY flag for UBI clocks Robert Marko
2022-05-15 21:00 ` [PATCH v4 07/11] dt-bindings: clocks: qcom,gcc-ipq8074: support power domains Robert Marko
2022-05-17 8:11 ` Krzysztof Kozlowski
2022-05-15 21:00 ` [PATCH v4 08/11] dt-bindings: clock: qcom: ipq8074: add USB GDSCs Robert Marko
2022-05-17 8:12 ` Krzysztof Kozlowski
2022-05-15 21:00 ` [PATCH v4 09/11] clk: " Robert Marko
2022-05-15 21:00 ` [PATCH v4 10/11] clk: qcom: ipq8074: dont disable gcc_sleep_clk_src Robert Marko
2022-07-11 21:10 ` Stephen Boyd
2022-07-11 21:14 ` Robert Marko
2022-07-29 23:27 ` Stephen Boyd [this message]
2022-05-15 21:00 ` [PATCH v4 11/11] arm64: dts: ipq8074: add USB power domains Robert Marko
2022-07-03 3:56 ` (subset) " Bjorn Andersson
2022-07-03 3:56 ` (subset) [PATCH v4 01/11] clk: qcom: ipq8074: fix NSS core PLL-s Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220729232750.8EAADC433D6@smtp.kernel.org \
--to=sboyd@kernel.org \
--cc=absahu@codeaurora.org \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=robh+dt@kernel.org \
--cc=robimarko@gmail.com \
--cc=tdas@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).