devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Pavel Machek <pavel@ucw.cz>
To: Jean-Jacques Hiblot <jjhiblot@traphandler.com>
Cc: robh+dt@kernel.org, sven.schwermer@disruptive-technologies.com,
	krzysztof.kozlowski+dt@linaro.org, johan+linaro@kernel.org,
	marijn.suijten@somainline.org, bjorn.andersson@linaro.org,
	andy.shevchenko@gmail.com, linux-leds@vger.kernel.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 4/4] leds: Add a multicolor LED driver to group monochromatic LEDs
Date: Sat, 30 Jul 2022 23:19:04 +0200	[thread overview]
Message-ID: <20220730211904.GF23307@duo.ucw.cz> (raw)
In-Reply-To: <20220719191801.345773-5-jjhiblot@traphandler.com>

[-- Attachment #1: Type: text/plain, Size: 1061 bytes --]

Hi!

> By allowing to group multiple monochrome LED into multicolor LEDs,
> all involved LEDs can be controlled in-sync. This enables using effects
> using triggers, etc.
> 
> Signed-off-by: Jean-Jacques Hiblot <jjhiblot@traphandler.com>
> ---
>  drivers/leds/rgb/Kconfig                 |   6 +
>  drivers/leds/rgb/Makefile                |   1 +
>  drivers/leds/rgb/leds-group-multicolor.c | 153 +++++++++++++++++++++++
>  3 files changed, 160 insertions(+)
>  create mode 100644 drivers/leds/rgb/leds-group-multicolor.c
> 
> diff --git a/drivers/leds/rgb/Kconfig b/drivers/leds/rgb/Kconfig
> index 204cf470beae..70b157d1fdca 100644
> --- a/drivers/leds/rgb/Kconfig
> +++ b/drivers/leds/rgb/Kconfig
> @@ -2,6 +2,12 @@
>  
>  if LEDS_CLASS_MULTICOLOR
>  
> +config LEDS_GRP_MULTICOLOR
> +	tristate "multi-color LED grouping Support"

Make this
        tristate "Multi-color LED grouping support"

Others commented on other issues.

Thank you,
							Pavel
-- 
People of Russia, stop Putin before his war on Ukraine escalates.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

      parent reply	other threads:[~2022-07-30 21:19 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-19 19:17 [PATCH v2 0/4] Add a multicolor LED driver for groups of monochromatic LEDs Jean-Jacques Hiblot
2022-07-19 19:17 ` [PATCH v2 1/4] leds: class: simplify the implementation of devm_of_led_get() Jean-Jacques Hiblot
2022-07-19 19:17 ` [PATCH v2 2/4] leds: class: store the color index in struct led_classdev Jean-Jacques Hiblot
2022-07-19 19:18 ` [PATCH v2 3/4] dt-bindings: leds: Add binding for a multicolor group of LEDs Jean-Jacques Hiblot
2022-07-19 21:25   ` Rob Herring
2022-07-19 23:15     ` Rob Herring
2022-07-19 23:16   ` Rob Herring
2022-07-19 19:18 ` [PATCH v2 4/4] leds: Add a multicolor LED driver to group monochromatic LEDs Jean-Jacques Hiblot
2022-07-20  7:28   ` Christophe JAILLET
2022-07-30 21:19   ` Pavel Machek [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220730211904.GF23307@duo.ucw.cz \
    --to=pavel@ucw.cz \
    --cc=andy.shevchenko@gmail.com \
    --cc=bjorn.andersson@linaro.org \
    --cc=devicetree@vger.kernel.org \
    --cc=jjhiblot@traphandler.com \
    --cc=johan+linaro@kernel.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-leds@vger.kernel.org \
    --cc=marijn.suijten@somainline.org \
    --cc=robh+dt@kernel.org \
    --cc=sven.schwermer@disruptive-technologies.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).