From: Pavel Machek <pavel@ucw.cz>
To: ChiaEn Wu <peterwu.pub@gmail.com>
Cc: lee.jones@linaro.org, daniel.thompson@linaro.org,
jingoohan1@gmail.com, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, matthias.bgg@gmail.com,
sre@kernel.org, chunfeng.yun@mediatek.com,
gregkh@linuxfoundation.org, jic23@kernel.org, lars@metafoo.de,
lgirdwood@gmail.com, broonie@kernel.org, linux@roeck-us.net,
heikki.krogerus@linux.intel.com, deller@gmx.de,
andy.shevchenko@gmail.com, chiaen_wu@richtek.com,
alice_chen@richtek.com, cy_huang@richtek.com,
dri-devel@lists.freedesktop.org, linux-leds@vger.kernel.org,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org,
linux-pm@vger.kernel.org, linux-usb@vger.kernel.org,
linux-iio@vger.kernel.org, linux-fbdev@vger.kernel.org,
szunichen@gmail.com
Subject: Re: [PATCH v6 12/13] leds: flash: mt6370: Add MediaTek MT6370 flashlight support
Date: Sat, 30 Jul 2022 23:42:05 +0200 [thread overview]
Message-ID: <20220730214205.GK23307@duo.ucw.cz> (raw)
In-Reply-To: <20220722102407.2205-13-peterwu.pub@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1116 bytes --]
Hi!
> From: Alice Chen <alice_chen@richtek.com>
>
> The MediaTek MT6370 is a highly-integrated smart power management IC,
> which includes a single cell Li-Ion/Li-Polymer switching battery
> charger, a USB Type-C & Power Delivery (PD) controller, dual Flash
> LED current sources, a RGB LED driver, a backlight WLED driver,
> a display bias driver and a general LDO for portable devices.
>
> The Flash LED in MT6370 has 2 channels and support torch/strobe mode.
> Add the support of MT6370 FLASH LED.
>
> Signed-off-by: Alice Chen <alice_chen@richtek.com>
> +config LEDS_MT6370_FLASHLIGHT
> + tristate "Flash LED Support for MediaTek MT6370 PMIC"
> + depends on LEDS_CLASS
I'd name it just LEDS_MT6370_FLASH.
> +// SPDX-License-Identifier: GPL-2.0-only
> +/*
> + * Copyright (C) 2022 Richtek Technology Corp.
> + *
> + * Author: Alice Chen <alice_chen@richtek.com
Add ">" at end of line.
The series is quite big, would it be possible to submit LED changes
in separate series?
Thanks,
Pavel
--
People of Russia, stop Putin before his war on Ukraine escalates.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
next prev parent reply other threads:[~2022-07-30 21:42 UTC|newest]
Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-22 10:23 [PATCH v6 00/13] Add MediaTek MT6370 PMIC support ChiaEn Wu
2022-07-22 10:23 ` [PATCH v6 01/13] dt-bindings: usb: Add MediaTek MT6370 TCPC ChiaEn Wu
2022-07-22 10:23 ` [PATCH v6 02/13] dt-bindings: power: supply: Add MediaTek MT6370 Charger ChiaEn Wu
2022-07-22 10:23 ` [PATCH v6 03/13] dt-bindings: leds: mt6370: Add MediaTek MT6370 current sink type LED indicator ChiaEn Wu
2022-07-22 10:23 ` [PATCH v6 04/13] dt-bindings: leds: Add MediaTek MT6370 flashlight ChiaEn Wu
2022-07-30 21:30 ` Pavel Machek
2022-07-22 10:23 ` [PATCH v6 05/13] dt-bindings: backlight: Add MediaTek MT6370 backlight ChiaEn Wu
2022-08-01 6:47 ` ChiaEn Wu
2022-07-22 10:24 ` [PATCH v6 06/13] dt-bindings: mfd: Add MediaTek MT6370 ChiaEn Wu
2022-07-22 10:24 ` [PATCH v6 07/13] mfd: mt6370: Add MediaTek MT6370 support ChiaEn Wu
2022-07-25 7:59 ` Andy Shevchenko
2022-07-25 8:29 ` ChiaEn Wu
2022-07-25 8:43 ` Andy Shevchenko
2022-07-25 9:06 ` ChiaEn Wu
2022-07-25 9:09 ` Andy Shevchenko
2022-07-22 10:24 ` [PATCH v6 08/13] usb: typec: tcpci_mt6370: Add MediaTek MT6370 tcpci driver ChiaEn Wu
2022-07-22 14:19 ` Guenter Roeck
2022-07-25 7:06 ` Chunfeng Yun
2022-07-25 7:17 ` ChiaEn Wu
2022-07-25 8:03 ` Andy Shevchenko
2022-07-22 10:24 ` [PATCH v6 09/13] iio: adc: mt6370: Add MediaTek MT6370 support ChiaEn Wu
2022-07-25 8:10 ` Andy Shevchenko
2022-07-22 10:24 ` [PATCH v6 10/13] power: supply: mt6370: Add MediaTek MT6370 charger driver ChiaEn Wu
2022-07-25 8:25 ` Andy Shevchenko
2022-07-22 10:24 ` [PATCH v6 11/13] leds: rgb: mt6370: Add MediaTek MT6370 current sink type LED Indicator support ChiaEn Wu
2022-07-22 10:52 ` AngeloGioacchino Del Regno
2022-07-25 8:40 ` Andy Shevchenko
2022-07-26 11:45 ` ChiaEn Wu
2022-07-26 12:17 ` Andy Shevchenko
2022-07-27 7:36 ` ChiaEn Wu
2022-07-27 10:03 ` Andy Shevchenko
2022-07-30 21:39 ` Pavel Machek
2022-08-01 7:55 ` szuni chen
2022-07-22 10:24 ` [PATCH v6 12/13] leds: flash: mt6370: Add MediaTek MT6370 flashlight support ChiaEn Wu
2022-07-22 10:48 ` AngeloGioacchino Del Regno
2022-07-25 8:51 ` Andy Shevchenko
2022-07-29 6:17 ` szuni chen
2022-07-29 10:34 ` Andy Shevchenko
2022-07-25 8:55 ` Andy Shevchenko
2022-07-26 4:15 ` szuni chen
2022-07-26 6:10 ` Andy Shevchenko
2022-07-30 21:42 ` Pavel Machek [this message]
2022-08-04 9:53 ` Alice Chen
2022-07-22 10:24 ` [PATCH v6 13/13] video: backlight: mt6370: Add MediaTek MT6370 support ChiaEn Wu
2022-07-25 9:07 ` Andy Shevchenko
2022-07-25 10:31 ` Daniel Thompson
2022-07-26 2:20 ` ChiaEn Wu
2022-07-26 9:30 ` Daniel Thompson
2022-07-26 11:28 ` ChiaEn Wu
2022-07-26 11:59 ` Daniel Thompson
2022-07-27 6:24 ` ChiaEn Wu
2022-07-28 11:31 ` Daniel Thompson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220730214205.GK23307@duo.ucw.cz \
--to=pavel@ucw.cz \
--cc=alice_chen@richtek.com \
--cc=andy.shevchenko@gmail.com \
--cc=broonie@kernel.org \
--cc=chiaen_wu@richtek.com \
--cc=chunfeng.yun@mediatek.com \
--cc=cy_huang@richtek.com \
--cc=daniel.thompson@linaro.org \
--cc=deller@gmx.de \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=gregkh@linuxfoundation.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=jic23@kernel.org \
--cc=jingoohan1@gmail.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lars@metafoo.de \
--cc=lee.jones@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=matthias.bgg@gmail.com \
--cc=peterwu.pub@gmail.com \
--cc=robh+dt@kernel.org \
--cc=sre@kernel.org \
--cc=szunichen@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).