From: Sudeep Holla <sudeep.holla@arm.com>
To: Rob Herring <robh@kernel.org>
Cc: Jassi Brar <jassisinghbrar@gmail.com>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Jassi Brar <jaswinder.singh@linaro.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
devicetree@vger.kernel.org
Subject: Re: [PATCH] dt-bindings: mailbox: arm,mhu: Make secure interrupt optional
Date: Mon, 1 Aug 2022 11:28:38 +0100 [thread overview]
Message-ID: <20220801102838.u3hcziiwts7bpxt2@bogus> (raw)
In-Reply-To: <CAL_JsqLwk+=CeDWqXzhrVESzhJnNjOjyR-TtisKGgjMUi7TivQ@mail.gmail.com>
On Fri, Jul 29, 2022 at 05:17:26PM -0600, Rob Herring wrote:
> On Fri, Jul 29, 2022 at 5:10 AM Sudeep Holla <sudeep.holla@arm.com> wrote:
[...]
> >
> > No this doesn't work IMO. Yes standalone everything looks fine, but you can
> > insert a module requesting this channel and bring down the system. So I am
> > not for this change.
>
> Not having the interrupt listed in DT doesn't prevent that. Is this
> security by obscurity?
>
I agree, as I mentioned in the other thread, if we had a way to mark that
channel as used elsewhere or disabled or unavailable, it would have been
great.
> I don't really care which way this is fixed though.
Understood.
> I just want the warning gone. We've all got better things to worry about.
Agreed.
> The DT not having the interrupt has been that way for years (presumably)
> and the kernel never needs the interrupt, so the schema should reflect
> reality.
I prefer this approach.
> On the flip side, considering it *can* be present already, there's not
> really much argument for not having it.
>
Can't disagree/argue that 😄.
--
Regards,
Sudeep
next prev parent reply other threads:[~2022-08-01 10:29 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-28 19:08 [PATCH] dt-bindings: mailbox: arm,mhu: Make secure interrupt optional Rob Herring
2022-07-28 20:17 ` Jassi Brar
2022-07-28 21:07 ` Jassi Brar
2022-07-29 11:10 ` Sudeep Holla
2022-07-29 15:18 ` Jassi Brar
2022-08-01 10:23 ` Sudeep Holla
2022-08-01 13:57 ` Jassi Brar
2022-08-01 14:18 ` Sudeep Holla
2022-07-29 23:17 ` Rob Herring
2022-08-01 10:28 ` Sudeep Holla [this message]
2022-07-29 8:48 ` Sudeep Holla
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220801102838.u3hcziiwts7bpxt2@bogus \
--to=sudeep.holla@arm.com \
--cc=devicetree@vger.kernel.org \
--cc=jassisinghbrar@gmail.com \
--cc=jaswinder.singh@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).