From: Rob Herring <robh@kernel.org>
To: Masahiro Yamada <masahiroy@kernel.org>
Cc: Frank Rowand <frowand.list@gmail.com>,
devicetree@vger.kernel.org,
Geert Uytterhoeven <geert+renesas@glider.be>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Nathan Chancellor <nathan@kernel.org>,
Sam Protsenko <semen.protsenko@linaro.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] dt-bindings: remove the dead code in cmd_mk_schema
Date: Mon, 1 Aug 2022 09:12:16 -0600 [thread overview]
Message-ID: <20220801151216.GA1026724-robh@kernel.org> (raw)
In-Reply-To: <20220729052112.3235325-1-masahiroy@kernel.org>
On Fri, Jul 29, 2022 at 02:21:12PM +0900, Masahiro Yamada wrote:
> Since commit 2783a7f56f99 ("dt-bindings: kbuild: Pass DT_SCHEMA_FILES to
> dt-validate"), the processed schema takes all the YAML files.
>
> Remove the dead code.
>
> Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
> ---
>
> Documentation/devicetree/bindings/Makefile | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
I also sent out a similar patch[1].
>
> diff --git a/Documentation/devicetree/bindings/Makefile b/Documentation/devicetree/bindings/Makefile
> index c9953f86b19d..223df2a023fd 100644
> --- a/Documentation/devicetree/bindings/Makefile
> +++ b/Documentation/devicetree/bindings/Makefile
> @@ -42,10 +42,8 @@ quiet_cmd_chk_bindings = CHKDT $@
>
> quiet_cmd_mk_schema = SCHEMA $@
> cmd_mk_schema = f=$$(mktemp) ; \
> - $(if $(DT_MK_SCHEMA_FLAGS), \
> - printf '%s\n' $(real-prereqs), \
> - $(find_all_cmd)) > $$f ; \
> - $(DT_MK_SCHEMA) -j $(DT_MK_SCHEMA_FLAGS) @$$f > $@ ; \
> + $(find_all_cmd) > $$f ; \
> + $(DT_MK_SCHEMA) -j @$$f > $@ ; \
I want to keep DT_MK_SCHEMA_FLAGS because I'm working on a new optional
flag to pass.
Rob
[1] https://lore.kernel.org/all/20220727211100.3249417-1-robh@kernel.org/
prev parent reply other threads:[~2022-08-01 15:12 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-29 5:21 [PATCH] dt-bindings: remove the dead code in cmd_mk_schema Masahiro Yamada
2022-08-01 15:12 ` Rob Herring [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220801151216.GA1026724-robh@kernel.org \
--to=robh@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=frowand.list@gmail.com \
--cc=geert+renesas@glider.be \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=masahiroy@kernel.org \
--cc=nathan@kernel.org \
--cc=semen.protsenko@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).