* [PATCH 2/3] ARM: dts: qcom: msm8960: add references to USB1
@ 2022-07-28 11:16 Shinjo Park
2022-07-28 11:50 ` Krzysztof Kozlowski
0 siblings, 1 reply; 7+ messages in thread
From: Shinjo Park @ 2022-07-28 11:16 UTC (permalink / raw)
Cc: peremen, David Heidelberg, Andy Gross, Bjorn Andersson,
Konrad Dybcio, Rob Herring, Krzysztof Kozlowski, linux-arm-msm,
devicetree, linux-kernel
Use the same USB definition as qcom-apq8064.dtsi, tested on Casio GzOne.
Signed-off-by: Shinjo Park <peremen@gmail.com>
Reviewed-by: David Heidelberg <david@ixit.cz>
---
arch/arm/boot/dts/qcom-msm8960.dtsi | 32 +++++++++++++++++++++++++++++
1 file changed, 32 insertions(+)
diff --git a/arch/arm/boot/dts/qcom-msm8960.dtsi b/arch/arm/boot/dts/qcom-msm8960.dtsi
index 991eb1948..a32073d61 100644
--- a/arch/arm/boot/dts/qcom-msm8960.dtsi
+++ b/arch/arm/boot/dts/qcom-msm8960.dtsi
@@ -4,6 +4,7 @@
#include <dt-bindings/interrupt-controller/arm-gic.h>
#include <dt-bindings/clock/qcom,gcc-msm8960.h>
#include <dt-bindings/clock/qcom,lcc-msm8960.h>
+#include <dt-bindings/reset/qcom,gcc-msm8960.h>
#include <dt-bindings/mfd/qcom-rpm.h>
#include <dt-bindings/soc/qcom,gsbi.h>
@@ -201,6 +202,37 @@ regulators {
};
};
+ usb1: usb@12500000 {
+ compatible = "qcom,ci-hdrc";
+ reg = <0x12500000 0x200>,
+ <0x12500200 0x200>;
+ interrupts = <GIC_SPI 100 IRQ_TYPE_LEVEL_HIGH>;
+ clocks = <&gcc USB_HS1_XCVR_CLK>, <&gcc USB_HS1_H_CLK>;
+ clock-names = "core", "iface";
+ assigned-clocks = <&gcc USB_HS1_XCVR_CLK>;
+ assigned-clock-rates = <60000000>;
+ resets = <&gcc USB_HS1_RESET>;
+ reset-names = "core";
+ phy_type = "ulpi";
+ ahb-burst-config = <0>;
+ phys = <&usb_hs1_phy>;
+ phy-names = "usb-phy";
+ status = "disabled";
+ #reset-cells = <1>;
+
+ ulpi {
+ usb_hs1_phy: phy {
+ compatible = "qcom,usb-hs-phy-msm8960",
+ "qcom,usb-hs-phy";
+ clocks = <&sleep_clk>, <&cxo_board>;
+ clock-names = "sleep", "ref";
+ resets = <&usb1 0>;
+ reset-names = "por";
+ #phy-cells = <0>;
+ };
+ };
+ };
+
acc0: clock-controller@2088000 {
compatible = "qcom,kpss-acc-v1";
reg = <0x02088000 0x1000>, <0x02008000 0x1000>;
--
2.34.1
^ permalink raw reply related [flat|nested] 7+ messages in thread* Re: [PATCH 2/3] ARM: dts: qcom: msm8960: add references to USB1
2022-07-28 11:16 [PATCH 2/3] ARM: dts: qcom: msm8960: add references to USB1 Shinjo Park
@ 2022-07-28 11:50 ` Krzysztof Kozlowski
2022-07-30 8:14 ` [PATCH v2 2/3] ARM: dts: qcom: msm8960: add the device node of USB1 Shinjo Park
0 siblings, 1 reply; 7+ messages in thread
From: Krzysztof Kozlowski @ 2022-07-28 11:50 UTC (permalink / raw)
To: Shinjo Park
Cc: David Heidelberg, Andy Gross, Bjorn Andersson, Konrad Dybcio,
Rob Herring, Krzysztof Kozlowski, linux-arm-msm, devicetree,
linux-kernel
On 28/07/2022 13:16, Shinjo Park wrote:
> Use the same USB definition as qcom-apq8064.dtsi, tested on Casio GzOne.
>
> Signed-off-by: Shinjo Park <peremen@gmail.com>
> Reviewed-by: David Heidelberg <david@ixit.cz>
Thank you for your patch. There is something to discuss/improve.
Similar problems as with previous patch - thread your patches and how
did you get review?
> ---
> arch/arm/boot/dts/qcom-msm8960.dtsi | 32 +++++++++++++++++++++++++++++
> 1 file changed, 32 insertions(+)
>
> diff --git a/arch/arm/boot/dts/qcom-msm8960.dtsi b/arch/arm/boot/dts/qcom-msm8960.dtsi
> index 991eb1948..a32073d61 100644
> --- a/arch/arm/boot/dts/qcom-msm8960.dtsi
> +++ b/arch/arm/boot/dts/qcom-msm8960.dtsi
> @@ -4,6 +4,7 @@
> #include <dt-bindings/interrupt-controller/arm-gic.h>
> #include <dt-bindings/clock/qcom,gcc-msm8960.h>
> #include <dt-bindings/clock/qcom,lcc-msm8960.h>
> +#include <dt-bindings/reset/qcom,gcc-msm8960.h>
> #include <dt-bindings/mfd/qcom-rpm.h>
> #include <dt-bindings/soc/qcom,gsbi.h>
>
> @@ -201,6 +202,37 @@ regulators {
> };
> };
>
> + usb1: usb@12500000 {
> + compatible = "qcom,ci-hdrc";
> + reg = <0x12500000 0x200>,
> + <0x12500200 0x200>;
> + interrupts = <GIC_SPI 100 IRQ_TYPE_LEVEL_HIGH>;
> + clocks = <&gcc USB_HS1_XCVR_CLK>, <&gcc USB_HS1_H_CLK>;
> + clock-names = "core", "iface";
> + assigned-clocks = <&gcc USB_HS1_XCVR_CLK>;
> + assigned-clock-rates = <60000000>;
> + resets = <&gcc USB_HS1_RESET>;
> + reset-names = "core";
> + phy_type = "ulpi";
> + ahb-burst-config = <0>;
> + phys = <&usb_hs1_phy>;
> + phy-names = "usb-phy";
> + status = "disabled";
status is the last property.
> + #reset-cells = <1>;
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 7+ messages in thread* [PATCH v2 2/3] ARM: dts: qcom: msm8960: add the device node of USB1
2022-07-28 11:50 ` Krzysztof Kozlowski
@ 2022-07-30 8:14 ` Shinjo Park
2022-08-02 5:21 ` Rudraksha Gupta
0 siblings, 1 reply; 7+ messages in thread
From: Shinjo Park @ 2022-07-30 8:14 UTC (permalink / raw)
Cc: peremen, David Heidelberg, Andy Gross, Bjorn Andersson,
Konrad Dybcio, Rob Herring, Krzysztof Kozlowski, linux-arm-msm,
devicetree, linux-kernel
Use the same USB definition as qcom-apq8064.dtsi, tested on Casio GzOne.
Signed-off-by: Shinjo Park <peremen@gmail.com>
Reviewed-by: David Heidelberg <david@ixit.cz>
---
v2:
- Rewrite commit message
- Reorder status line
arch/arm/boot/dts/qcom-msm8960.dtsi | 32 +++++++++++++++++++++++++++++
1 file changed, 32 insertions(+)
diff --git a/arch/arm/boot/dts/qcom-msm8960.dtsi b/arch/arm/boot/dts/qcom-msm8960.dtsi
index e1f010c9643e..4c8a67c0cc7b 100644
--- a/arch/arm/boot/dts/qcom-msm8960.dtsi
+++ b/arch/arm/boot/dts/qcom-msm8960.dtsi
@@ -4,6 +4,7 @@
#include <dt-bindings/interrupt-controller/arm-gic.h>
#include <dt-bindings/clock/qcom,gcc-msm8960.h>
#include <dt-bindings/clock/qcom,lcc-msm8960.h>
+#include <dt-bindings/reset/qcom,gcc-msm8960.h>
#include <dt-bindings/mfd/qcom-rpm.h>
#include <dt-bindings/soc/qcom,gsbi.h>
@@ -201,6 +202,37 @@ regulators {
};
};
+ usb1: usb@12500000 {
+ compatible = "qcom,ci-hdrc";
+ reg = <0x12500000 0x200>,
+ <0x12500200 0x200>;
+ interrupts = <GIC_SPI 100 IRQ_TYPE_LEVEL_HIGH>;
+ clocks = <&gcc USB_HS1_XCVR_CLK>, <&gcc USB_HS1_H_CLK>;
+ clock-names = "core", "iface";
+ assigned-clocks = <&gcc USB_HS1_XCVR_CLK>;
+ assigned-clock-rates = <60000000>;
+ resets = <&gcc USB_HS1_RESET>;
+ reset-names = "core";
+ phy_type = "ulpi";
+ ahb-burst-config = <0>;
+ phys = <&usb_hs1_phy>;
+ phy-names = "usb-phy";
+ #reset-cells = <1>;
+ status = "disabled";
+
+ ulpi {
+ usb_hs1_phy: phy {
+ compatible = "qcom,usb-hs-phy-msm8960",
+ "qcom,usb-hs-phy";
+ clocks = <&sleep_clk>, <&cxo_board>;
+ clock-names = "sleep", "ref";
+ resets = <&usb1 0>;
+ reset-names = "por";
+ #phy-cells = <0>;
+ };
+ };
+ };
+
acc0: clock-controller@2088000 {
compatible = "qcom,kpss-acc-v1";
reg = <0x02088000 0x1000>, <0x02008000 0x1000>;
--
2.34.1
^ permalink raw reply related [flat|nested] 7+ messages in thread* Re: [PATCH v2 2/3] ARM: dts: qcom: msm8960: add the device node of USB1
2022-07-30 8:14 ` [PATCH v2 2/3] ARM: dts: qcom: msm8960: add the device node of USB1 Shinjo Park
@ 2022-08-02 5:21 ` Rudraksha Gupta
2022-08-03 7:29 ` Shinjo Park
0 siblings, 1 reply; 7+ messages in thread
From: Rudraksha Gupta @ 2022-08-02 5:21 UTC (permalink / raw)
To: Shinjo Park
Cc: David Heidelberg, Andy Gross, Bjorn Andersson, Konrad Dybcio,
Rob Herring, Krzysztof Kozlowski, linux-arm-msm, devicetree,
linux-kernel
> #include <dt-bindings/clock/qcom,lcc-msm8960.h>
Does not apply cleanly to mainline. Please include the above
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v2 2/3] ARM: dts: qcom: msm8960: add the device node of USB1
2022-08-02 5:21 ` Rudraksha Gupta
@ 2022-08-03 7:29 ` Shinjo Park
2022-08-03 7:46 ` [PATCH v3 " Shinjo Park
0 siblings, 1 reply; 7+ messages in thread
From: Shinjo Park @ 2022-08-03 7:29 UTC (permalink / raw)
To: Rudraksha Gupta
Cc: David Heidelberg, Andy Gross, Bjorn Andersson, Konrad Dybcio,
Rob Herring, Krzysztof Kozlowski, linux-arm-msm, devicetree,
linux-kernel
On 2022년 8월 2일 화요일 오전 7시 21분 54초 CEST Rudraksha Gupta wrote:
> > #include <dt-bindings/clock/qcom,lcc-msm8960.h>
>
> Does not apply cleanly to mainline. Please include the above
Will be fixed in the next revision of this patch.
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH v3 2/3] ARM: dts: qcom: msm8960: add the device node of USB1
2022-08-03 7:29 ` Shinjo Park
@ 2022-08-03 7:46 ` Shinjo Park
2022-08-09 21:11 ` Bjorn Andersson
0 siblings, 1 reply; 7+ messages in thread
From: Shinjo Park @ 2022-08-03 7:46 UTC (permalink / raw)
Cc: peremen, David Heidelberg, Andy Gross, Bjorn Andersson,
Konrad Dybcio, Rob Herring, Krzysztof Kozlowski, linux-arm-msm,
devicetree, linux-kernel
Use the same USB definition as qcom-apq8064.dtsi, tested on Casio GzOne.
Signed-off-by: Shinjo Park <peremen@gmail.com>
Reviewed-by: David Heidelberg <david@ixit.cz>
---
v3:
- Include missing clock/qcom,lcc-msm8960.h to make cleanly applicable
v2:
- Rewrite commit message
- Reorder status line
arch/arm/boot/dts/qcom-msm8960.dtsi | 33 +++++++++++++++++++++++++++++
1 file changed, 33 insertions(+)
diff --git a/arch/arm/boot/dts/qcom-msm8960.dtsi b/arch/arm/boot/dts/qcom-msm8960.dtsi
index e14e1c5d1..0e099aa7c 100644
--- a/arch/arm/boot/dts/qcom-msm8960.dtsi
+++ b/arch/arm/boot/dts/qcom-msm8960.dtsi
@@ -3,6 +3,8 @@
#include <dt-bindings/interrupt-controller/arm-gic.h>
#include <dt-bindings/clock/qcom,gcc-msm8960.h>
+#include <dt-bindings/clock/qcom,lcc-msm8960.h>
+#include <dt-bindings/reset/qcom,gcc-msm8960.h>
#include <dt-bindings/mfd/qcom-rpm.h>
#include <dt-bindings/soc/qcom,gsbi.h>
@@ -167,6 +169,37 @@ regulators {
};
};
+ usb1: usb@12500000 {
+ compatible = "qcom,ci-hdrc";
+ reg = <0x12500000 0x200>,
+ <0x12500200 0x200>;
+ interrupts = <GIC_SPI 100 IRQ_TYPE_LEVEL_HIGH>;
+ clocks = <&gcc USB_HS1_XCVR_CLK>, <&gcc USB_HS1_H_CLK>;
+ clock-names = "core", "iface";
+ assigned-clocks = <&gcc USB_HS1_XCVR_CLK>;
+ assigned-clock-rates = <60000000>;
+ resets = <&gcc USB_HS1_RESET>;
+ reset-names = "core";
+ phy_type = "ulpi";
+ ahb-burst-config = <0>;
+ phys = <&usb_hs1_phy>;
+ phy-names = "usb-phy";
+ #reset-cells = <1>;
+ status = "disabled";
+
+ ulpi {
+ usb_hs1_phy: phy {
+ compatible = "qcom,usb-hs-phy-msm8960",
+ "qcom,usb-hs-phy";
+ clocks = <&sleep_clk>, <&cxo_board>;
+ clock-names = "sleep", "ref";
+ resets = <&usb1 0>;
+ reset-names = "por";
+ #phy-cells = <0>;
+ };
+ };
+ };
+
acc0: clock-controller@2088000 {
compatible = "qcom,kpss-acc-v1";
reg = <0x02088000 0x1000>, <0x02008000 0x1000>;
--
2.34.1
^ permalink raw reply related [flat|nested] 7+ messages in thread* Re: [PATCH v3 2/3] ARM: dts: qcom: msm8960: add the device node of USB1
2022-08-03 7:46 ` [PATCH v3 " Shinjo Park
@ 2022-08-09 21:11 ` Bjorn Andersson
0 siblings, 0 replies; 7+ messages in thread
From: Bjorn Andersson @ 2022-08-09 21:11 UTC (permalink / raw)
To: Shinjo Park
Cc: David Heidelberg, Andy Gross, Konrad Dybcio, Rob Herring,
Krzysztof Kozlowski, linux-arm-msm, devicetree, linux-kernel
On Wed 03 Aug 02:46 CDT 2022, Shinjo Park wrote:
> Use the same USB definition as qcom-apq8064.dtsi, tested on Casio GzOne.
>
I think this looks good, but I have a v2 of patch 1 and a v3 of patch 2,
and I don't seem to have patch 3 in my inbox(?)
Can you please resubmit the 3 patches with a --cover-letter, instead of
each patch being a reply of the previous instance of that particular
patch? This will make it much easier for me to merge the end result.
Thanks,
Bjorn
> Signed-off-by: Shinjo Park <peremen@gmail.com>
> Reviewed-by: David Heidelberg <david@ixit.cz>
> ---
>
> v3:
> - Include missing clock/qcom,lcc-msm8960.h to make cleanly applicable
>
> v2:
> - Rewrite commit message
> - Reorder status line
>
> arch/arm/boot/dts/qcom-msm8960.dtsi | 33 +++++++++++++++++++++++++++++
> 1 file changed, 33 insertions(+)
>
> diff --git a/arch/arm/boot/dts/qcom-msm8960.dtsi b/arch/arm/boot/dts/qcom-msm8960.dtsi
> index e14e1c5d1..0e099aa7c 100644
> --- a/arch/arm/boot/dts/qcom-msm8960.dtsi
> +++ b/arch/arm/boot/dts/qcom-msm8960.dtsi
> @@ -3,6 +3,8 @@
>
> #include <dt-bindings/interrupt-controller/arm-gic.h>
> #include <dt-bindings/clock/qcom,gcc-msm8960.h>
> +#include <dt-bindings/clock/qcom,lcc-msm8960.h>
> +#include <dt-bindings/reset/qcom,gcc-msm8960.h>
> #include <dt-bindings/mfd/qcom-rpm.h>
> #include <dt-bindings/soc/qcom,gsbi.h>
>
> @@ -167,6 +169,37 @@ regulators {
> };
> };
>
> + usb1: usb@12500000 {
> + compatible = "qcom,ci-hdrc";
> + reg = <0x12500000 0x200>,
> + <0x12500200 0x200>;
> + interrupts = <GIC_SPI 100 IRQ_TYPE_LEVEL_HIGH>;
> + clocks = <&gcc USB_HS1_XCVR_CLK>, <&gcc USB_HS1_H_CLK>;
> + clock-names = "core", "iface";
> + assigned-clocks = <&gcc USB_HS1_XCVR_CLK>;
> + assigned-clock-rates = <60000000>;
> + resets = <&gcc USB_HS1_RESET>;
> + reset-names = "core";
> + phy_type = "ulpi";
> + ahb-burst-config = <0>;
> + phys = <&usb_hs1_phy>;
> + phy-names = "usb-phy";
> + #reset-cells = <1>;
> + status = "disabled";
> +
> + ulpi {
> + usb_hs1_phy: phy {
> + compatible = "qcom,usb-hs-phy-msm8960",
> + "qcom,usb-hs-phy";
> + clocks = <&sleep_clk>, <&cxo_board>;
> + clock-names = "sleep", "ref";
> + resets = <&usb1 0>;
> + reset-names = "por";
> + #phy-cells = <0>;
> + };
> + };
> + };
> +
> acc0: clock-controller@2088000 {
> compatible = "qcom,kpss-acc-v1";
> reg = <0x02088000 0x1000>, <0x02008000 0x1000>;
> --
> 2.34.1
>
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2022-08-09 21:12 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-07-28 11:16 [PATCH 2/3] ARM: dts: qcom: msm8960: add references to USB1 Shinjo Park
2022-07-28 11:50 ` Krzysztof Kozlowski
2022-07-30 8:14 ` [PATCH v2 2/3] ARM: dts: qcom: msm8960: add the device node of USB1 Shinjo Park
2022-08-02 5:21 ` Rudraksha Gupta
2022-08-03 7:29 ` Shinjo Park
2022-08-03 7:46 ` [PATCH v3 " Shinjo Park
2022-08-09 21:11 ` Bjorn Andersson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).