devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 1/4] ARM: dts: bcmbca: bcm63178: fix timer node cpu mask flag
@ 2022-08-01 19:44 William Zhang
  2022-08-01 19:44 ` [PATCH 2/4] ARM: dts: bcmbca: bcm63178: clean up psci node William Zhang
                   ` (3 more replies)
  0 siblings, 4 replies; 8+ messages in thread
From: William Zhang @ 2022-08-01 19:44 UTC (permalink / raw)
  To: Linux ARM List
  Cc: f.fainelli, anand.gore, dan.beygelman, joel.peshkin,
	Broadcom Kernel List, kursad.oney, William Zhang,
	Krzysztof Kozlowski, Rob Herring, devicetree, linux-kernel

[-- Attachment #1: Type: text/plain, Size: 1240 bytes --]

The cpu mask flag value should match the number of cpu cores in the
chip. Correct the value to three cpus for BCM63178 triple core SoC.

Fixes: fc85b7e64acb ("ARM: dts: add dts files for bcmbca soc 63178")
Signed-off-by: William Zhang <william.zhang@broadcom.com>
---

 arch/arm/boot/dts/bcm63178.dtsi | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/arch/arm/boot/dts/bcm63178.dtsi b/arch/arm/boot/dts/bcm63178.dtsi
index 5463443f0762..14d2c5bd2c52 100644
--- a/arch/arm/boot/dts/bcm63178.dtsi
+++ b/arch/arm/boot/dts/bcm63178.dtsi
@@ -46,10 +46,10 @@ L2_0: l2-cache0 {
 
 	timer {
 		compatible = "arm,armv7-timer";
-		interrupts = <GIC_PPI 13 (GIC_CPU_MASK_SIMPLE(4) | IRQ_TYPE_LEVEL_LOW)>,
-			<GIC_PPI 14 (GIC_CPU_MASK_SIMPLE(4) | IRQ_TYPE_LEVEL_LOW)>,
-			<GIC_PPI 11 (GIC_CPU_MASK_SIMPLE(4) | IRQ_TYPE_LEVEL_LOW)>,
-			<GIC_PPI 10 (GIC_CPU_MASK_SIMPLE(4) | IRQ_TYPE_LEVEL_LOW)>;
+		interrupts = <GIC_PPI 13 (GIC_CPU_MASK_SIMPLE(3) | IRQ_TYPE_LEVEL_LOW)>,
+			<GIC_PPI 14 (GIC_CPU_MASK_SIMPLE(3) | IRQ_TYPE_LEVEL_LOW)>,
+			<GIC_PPI 11 (GIC_CPU_MASK_SIMPLE(3) | IRQ_TYPE_LEVEL_LOW)>,
+			<GIC_PPI 10 (GIC_CPU_MASK_SIMPLE(3) | IRQ_TYPE_LEVEL_LOW)>;
 		arm,cpu-registers-not-fw-configured;
 	};
 
-- 
2.34.1


[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4212 bytes --]

^ permalink raw reply related	[flat|nested] 8+ messages in thread

* [PATCH 2/4] ARM: dts: bcmbca: bcm63178: clean up psci node
  2022-08-01 19:44 [PATCH 1/4] ARM: dts: bcmbca: bcm63178: fix timer node cpu mask flag William Zhang
@ 2022-08-01 19:44 ` William Zhang
  2022-08-04 18:05   ` Florian Fainelli
  2022-08-01 19:44 ` [PATCH 3/4] ARM: dts: bcmbca: bcm63178: fix interrupt controller node William Zhang
                   ` (2 subsequent siblings)
  3 siblings, 1 reply; 8+ messages in thread
From: William Zhang @ 2022-08-01 19:44 UTC (permalink / raw)
  To: Linux ARM List
  Cc: f.fainelli, anand.gore, dan.beygelman, joel.peshkin,
	Broadcom Kernel List, kursad.oney, William Zhang,
	Krzysztof Kozlowski, Rob Herring, devicetree, linux-kernel

[-- Attachment #1: Type: text/plain, Size: 690 bytes --]

Remove unnecessary cpu_on and cpu_off properties from psci
node as they are only needed for psci version prior to 0.2.

Fixes: fc85b7e64acb ("ARM: dts: add dts files for bcmbca soc 63178")
Signed-off-by: William Zhang <william.zhang@broadcom.com>
---

 arch/arm/boot/dts/bcm63178.dtsi | 2 --
 1 file changed, 2 deletions(-)

diff --git a/arch/arm/boot/dts/bcm63178.dtsi b/arch/arm/boot/dts/bcm63178.dtsi
index 14d2c5bd2c52..98ab10e1c81e 100644
--- a/arch/arm/boot/dts/bcm63178.dtsi
+++ b/arch/arm/boot/dts/bcm63178.dtsi
@@ -80,8 +80,6 @@ uart_clk: uart-clk {
 	psci {
 		compatible = "arm,psci-0.2";
 		method = "smc";
-		cpu_off = <1>;
-		cpu_on = <2>;
 	};
 
 	axi@81000000 {
-- 
2.34.1


[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4212 bytes --]

^ permalink raw reply related	[flat|nested] 8+ messages in thread

* [PATCH 3/4] ARM: dts: bcmbca: bcm63178: fix interrupt controller node
  2022-08-01 19:44 [PATCH 1/4] ARM: dts: bcmbca: bcm63178: fix timer node cpu mask flag William Zhang
  2022-08-01 19:44 ` [PATCH 2/4] ARM: dts: bcmbca: bcm63178: clean up psci node William Zhang
@ 2022-08-01 19:44 ` William Zhang
  2022-08-04 18:05   ` Florian Fainelli
  2022-08-01 19:44 ` [PATCH 4/4] ARM: dts: bcmbca: bcm63178: cosmetic change William Zhang
  2022-08-04 18:05 ` [PATCH 1/4] ARM: dts: bcmbca: bcm63178: fix timer node cpu mask flag Florian Fainelli
  3 siblings, 1 reply; 8+ messages in thread
From: William Zhang @ 2022-08-01 19:44 UTC (permalink / raw)
  To: Linux ARM List
  Cc: f.fainelli, anand.gore, dan.beygelman, joel.peshkin,
	Broadcom Kernel List, kursad.oney, William Zhang,
	Krzysztof Kozlowski, Rob Herring, devicetree, linux-kernel

[-- Attachment #1: Type: text/plain, Size: 1050 bytes --]

Add the missing gic registers and interrupts property to the gic node.

Fixes: fc85b7e64acb ("ARM: dts: add dts files for bcmbca soc 63178")
Signed-off-by: William Zhang <william.zhang@broadcom.com>
---

 arch/arm/boot/dts/bcm63178.dtsi | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/arch/arm/boot/dts/bcm63178.dtsi b/arch/arm/boot/dts/bcm63178.dtsi
index 98ab10e1c81e..dba71fa53466 100644
--- a/arch/arm/boot/dts/bcm63178.dtsi
+++ b/arch/arm/boot/dts/bcm63178.dtsi
@@ -86,15 +86,17 @@ axi@81000000 {
 		compatible = "simple-bus";
 		#address-cells = <1>;
 		#size-cells = <1>;
-		ranges = <0 0x81000000 0x4000>;
+		ranges = <0 0x81000000 0x8000>;
 
 		gic: interrupt-controller@1000 {
 			compatible = "arm,cortex-a7-gic";
 			#interrupt-cells = <3>;
-			#address-cells = <0>;
 			interrupt-controller;
+			interrupts = <GIC_PPI 9 (GIC_CPU_MASK_SIMPLE(3) | IRQ_TYPE_LEVEL_HIGH)>;
 			reg = <0x1000 0x1000>,
-				<0x2000 0x2000>;
+				<0x2000 0x2000>,
+				<0x4000 0x2000>,
+				<0x6000 0x2000>;
 		};
 	};
 
-- 
2.34.1


[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4212 bytes --]

^ permalink raw reply related	[flat|nested] 8+ messages in thread

* [PATCH 4/4] ARM: dts: bcmbca: bcm63178: cosmetic change
  2022-08-01 19:44 [PATCH 1/4] ARM: dts: bcmbca: bcm63178: fix timer node cpu mask flag William Zhang
  2022-08-01 19:44 ` [PATCH 2/4] ARM: dts: bcmbca: bcm63178: clean up psci node William Zhang
  2022-08-01 19:44 ` [PATCH 3/4] ARM: dts: bcmbca: bcm63178: fix interrupt controller node William Zhang
@ 2022-08-01 19:44 ` William Zhang
  2022-08-04 18:06   ` Florian Fainelli
  2022-08-04 18:05 ` [PATCH 1/4] ARM: dts: bcmbca: bcm63178: fix timer node cpu mask flag Florian Fainelli
  3 siblings, 1 reply; 8+ messages in thread
From: William Zhang @ 2022-08-01 19:44 UTC (permalink / raw)
  To: Linux ARM List
  Cc: f.fainelli, anand.gore, dan.beygelman, joel.peshkin,
	Broadcom Kernel List, kursad.oney, William Zhang,
	Krzysztof Kozlowski, Rob Herring, devicetree, linux-kernel

[-- Attachment #1: Type: text/plain, Size: 708 bytes --]

Add new line between dts node.

Signed-off-by: William Zhang <william.zhang@broadcom.com>
---

 arch/arm/boot/dts/bcm63178.dtsi | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/arch/arm/boot/dts/bcm63178.dtsi b/arch/arm/boot/dts/bcm63178.dtsi
index dba71fa53466..cbd094dde6d0 100644
--- a/arch/arm/boot/dts/bcm63178.dtsi
+++ b/arch/arm/boot/dts/bcm63178.dtsi
@@ -32,6 +32,7 @@ CA7_1: cpu@1 {
 			next-level-cache = <&L2_0>;
 			enable-method = "psci";
 		};
+
 		CA7_2: cpu@2 {
 			device_type = "cpu";
 			compatible = "arm,cortex-a7";
@@ -39,6 +40,7 @@ CA7_2: cpu@2 {
 			next-level-cache = <&L2_0>;
 			enable-method = "psci";
 		};
+
 		L2_0: l2-cache0 {
 			compatible = "cache";
 		};
-- 
2.34.1


[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4212 bytes --]

^ permalink raw reply related	[flat|nested] 8+ messages in thread

* Re: [PATCH 1/4] ARM: dts: bcmbca: bcm63178: fix timer node cpu mask flag
  2022-08-01 19:44 [PATCH 1/4] ARM: dts: bcmbca: bcm63178: fix timer node cpu mask flag William Zhang
                   ` (2 preceding siblings ...)
  2022-08-01 19:44 ` [PATCH 4/4] ARM: dts: bcmbca: bcm63178: cosmetic change William Zhang
@ 2022-08-04 18:05 ` Florian Fainelli
  3 siblings, 0 replies; 8+ messages in thread
From: Florian Fainelli @ 2022-08-04 18:05 UTC (permalink / raw)
  To: bcm-kernel-feedback-list, William Zhang, Linux ARM List
  Cc: anand.gore, dan.beygelman, joel.peshkin, kursad.oney,
	Krzysztof Kozlowski, Rob Herring, devicetree, linux-kernel

On Mon,  1 Aug 2022 12:44:45 -0700, William Zhang <william.zhang@broadcom.com> wrote:
> The cpu mask flag value should match the number of cpu cores in the
> chip. Correct the value to three cpus for BCM63178 triple core SoC.
> 
> Fixes: fc85b7e64acb ("ARM: dts: add dts files for bcmbca soc 63178")
> Signed-off-by: William Zhang <william.zhang@broadcom.com>
> ---

Applied to https://github.com/Broadcom/stblinux/commits/devicetree/fixes, thanks!
--
Florian

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH 2/4] ARM: dts: bcmbca: bcm63178: clean up psci node
  2022-08-01 19:44 ` [PATCH 2/4] ARM: dts: bcmbca: bcm63178: clean up psci node William Zhang
@ 2022-08-04 18:05   ` Florian Fainelli
  0 siblings, 0 replies; 8+ messages in thread
From: Florian Fainelli @ 2022-08-04 18:05 UTC (permalink / raw)
  To: bcm-kernel-feedback-list, William Zhang, Linux ARM List
  Cc: anand.gore, dan.beygelman, joel.peshkin, kursad.oney,
	Krzysztof Kozlowski, Rob Herring, devicetree, linux-kernel

On Mon,  1 Aug 2022 12:44:46 -0700, William Zhang <william.zhang@broadcom.com> wrote:
> Remove unnecessary cpu_on and cpu_off properties from psci
> node as they are only needed for psci version prior to 0.2.
> 
> Fixes: fc85b7e64acb ("ARM: dts: add dts files for bcmbca soc 63178")
> Signed-off-by: William Zhang <william.zhang@broadcom.com>
> ---

Applied to https://github.com/Broadcom/stblinux/commits/devicetree/fixes, thanks!
--
Florian

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH 3/4] ARM: dts: bcmbca: bcm63178: fix interrupt controller node
  2022-08-01 19:44 ` [PATCH 3/4] ARM: dts: bcmbca: bcm63178: fix interrupt controller node William Zhang
@ 2022-08-04 18:05   ` Florian Fainelli
  0 siblings, 0 replies; 8+ messages in thread
From: Florian Fainelli @ 2022-08-04 18:05 UTC (permalink / raw)
  To: bcm-kernel-feedback-list, William Zhang, Linux ARM List
  Cc: anand.gore, dan.beygelman, joel.peshkin, kursad.oney,
	Krzysztof Kozlowski, Rob Herring, devicetree, linux-kernel

On Mon,  1 Aug 2022 12:44:47 -0700, William Zhang <william.zhang@broadcom.com> wrote:
> Add the missing gic registers and interrupts property to the gic node.
> 
> Fixes: fc85b7e64acb ("ARM: dts: add dts files for bcmbca soc 63178")
> Signed-off-by: William Zhang <william.zhang@broadcom.com>
> ---

Applied to https://github.com/Broadcom/stblinux/commits/devicetree/fixes, thanks!
--
Florian

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH 4/4] ARM: dts: bcmbca: bcm63178: cosmetic change
  2022-08-01 19:44 ` [PATCH 4/4] ARM: dts: bcmbca: bcm63178: cosmetic change William Zhang
@ 2022-08-04 18:06   ` Florian Fainelli
  0 siblings, 0 replies; 8+ messages in thread
From: Florian Fainelli @ 2022-08-04 18:06 UTC (permalink / raw)
  To: bcm-kernel-feedback-list, William Zhang, Linux ARM List
  Cc: anand.gore, dan.beygelman, joel.peshkin, kursad.oney,
	Krzysztof Kozlowski, Rob Herring, devicetree, linux-kernel

On Mon,  1 Aug 2022 12:44:48 -0700, William Zhang <william.zhang@broadcom.com> wrote:
> Add new line between dts node.
> 
> Signed-off-by: William Zhang <william.zhang@broadcom.com>
> ---

Applied to https://github.com/Broadcom/stblinux/commits/devicetree/fixes, thanks!
--
Florian

^ permalink raw reply	[flat|nested] 8+ messages in thread

end of thread, other threads:[~2022-08-04 18:06 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-08-01 19:44 [PATCH 1/4] ARM: dts: bcmbca: bcm63178: fix timer node cpu mask flag William Zhang
2022-08-01 19:44 ` [PATCH 2/4] ARM: dts: bcmbca: bcm63178: clean up psci node William Zhang
2022-08-04 18:05   ` Florian Fainelli
2022-08-01 19:44 ` [PATCH 3/4] ARM: dts: bcmbca: bcm63178: fix interrupt controller node William Zhang
2022-08-04 18:05   ` Florian Fainelli
2022-08-01 19:44 ` [PATCH 4/4] ARM: dts: bcmbca: bcm63178: cosmetic change William Zhang
2022-08-04 18:06   ` Florian Fainelli
2022-08-04 18:05 ` [PATCH 1/4] ARM: dts: bcmbca: bcm63178: fix timer node cpu mask flag Florian Fainelli

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).