From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id F0723C25B0C for ; Sat, 6 Aug 2022 15:09:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232010AbiHFPJD (ORCPT ); Sat, 6 Aug 2022 11:09:03 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37328 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231879AbiHFPJC (ORCPT ); Sat, 6 Aug 2022 11:09:02 -0400 Received: from mail-pg1-x533.google.com (mail-pg1-x533.google.com [IPv6:2607:f8b0:4864:20::533]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3703A101D1 for ; Sat, 6 Aug 2022 08:08:59 -0700 (PDT) Received: by mail-pg1-x533.google.com with SMTP id h132so4969639pgc.10 for ; Sat, 06 Aug 2022 08:08:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=uU4q+1kcLLtSx8+NPQzdu8kyauS2SIpK22Q1e7AOuwQ=; b=VSAHKMeN2BFKXhSB9mCom3orXUV6CDkNpa4g8LCmLWnwRbHujmQtNX8Y6V8rSf/56q 6T/avkIb0/OHfFSlt5KI/XadFRTEWFxL6W3dw1jXevlfQRPGNJdjGVHqh4yj9GoC/hvq t5vMkJeQaojH8X9crW3APgOxuDTqFRnWf+qnXY/xiOsBBOmnDBkmU0BdQV14mSeOHpwZ alGlTDNR0pWi9N1eGNXZE4R3UpPulij3sIo1BxLPw2C2DFbGKuRSceEAw8Tzcp/lc5Ga Z1ddTWJv/1YgCd01l+LtwexpoNmsaC+f1KMSO/LQfdLdz+bRWqXZ6y0NEzesnpqNRKDC hvHQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=uU4q+1kcLLtSx8+NPQzdu8kyauS2SIpK22Q1e7AOuwQ=; b=KMNQkiJP2WpRcdhCpj6sffko2btDuUT+jcUADH6jyZz+ntzUoKpNHHtIF2C1CTPJRF yzv94RVklX7fUOGf4M8kQqlwb8yngmrYiD3uRWIPnPOB39AGWug9WwTtK/As+A/2K5Zb 4aVg81NRldmSj5IY/8F9lh2/nTfsbPhwLDS50z5cMXzDMsXzDjNbzMB/+pXXt2zSt/M6 jyoWPL2eYIHQNAe5IJiGcJmNEq7uFQIbo09xY6FupVtPPUuMTx9Qv5mQH8l+i4dQj4nC kNg4+2dD/zoaMdvw3YrFXCFnz+WHStqRp7kM8WeftYX6+2xsIhU2pMGk71eMBvWBQ+ai Z8xA== X-Gm-Message-State: ACgBeo1ofvZEP9xyny9R5sdmODXwhn9QJMEQmnPqB5VBY9m9/1oaKath KgWaeWaxCMvk6aOxzuh1zGJk X-Google-Smtp-Source: AA6agR6HkJfzjY4xHcQDLXq9sUwFM7dPJqu+aUYTXPgnE+DcB+YVXM9CNjgMSNPlGgwdJ4qDOVdL5w== X-Received: by 2002:a63:8c47:0:b0:40d:2d4:e3a2 with SMTP id q7-20020a638c47000000b0040d02d4e3a2mr9868130pgn.2.1659798538271; Sat, 06 Aug 2022 08:08:58 -0700 (PDT) Received: from thinkpad ([117.202.188.20]) by smtp.gmail.com with ESMTPSA id h20-20020aa796d4000000b0052d4afc4302sm5253854pfq.175.2022.08.06.08.08.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 06 Aug 2022 08:08:57 -0700 (PDT) Date: Sat, 6 Aug 2022 20:38:48 +0530 From: Manivannan Sadhasivam To: Johan Hovold Cc: Greg Kroah-Hartman , Felipe Balbi , Rob Herring , Krzysztof Kozlowski , Andy Gross , Bjorn Andersson , Konrad Dybcio , Krishna Kurapati , Stephen Boyd , Doug Anderson , Matthias Kaehlcke , Pavankumar Kondeti , quic_ppratap@quicinc.com, quic_vpulyala@quicinc.com, linux-arm-msm@vger.kernel.org, linux-usb@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Rob Herring Subject: Re: [PATCH v2 7/9] dt-bindings: usb: qcom,dwc3: add wakeup-source property Message-ID: <20220806150848.GH14384@thinkpad> References: <20220804151001.23612-1-johan+linaro@kernel.org> <20220804151001.23612-8-johan+linaro@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20220804151001.23612-8-johan+linaro@kernel.org> Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Thu, Aug 04, 2022 at 05:09:59PM +0200, Johan Hovold wrote: > Add a wakeup-source property to the binding to describe whether the > wakeup interrupts can wake the system from suspend. > > Acked-by: Rob Herring > Signed-off-by: Johan Hovold So this is based on the fact that Qcom glue wrapper is supplying the wakeup interrupts. But isn't it possible that on other platform, the DWC IP can supply wakeup interrupts? In the driver, the wakeup-source parsing has been moved to the Qcom glue driver. But this contradicts with the binding. Thanks, Mani > --- > > Changes in v2 > - disallow 'wakeup-source' in child node (Krzysztof) > > Documentation/devicetree/bindings/usb/qcom,dwc3.yaml | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/Documentation/devicetree/bindings/usb/qcom,dwc3.yaml b/Documentation/devicetree/bindings/usb/qcom,dwc3.yaml > index fea3e7092ace..d5959bdea63e 100644 > --- a/Documentation/devicetree/bindings/usb/qcom,dwc3.yaml > +++ b/Documentation/devicetree/bindings/usb/qcom,dwc3.yaml > @@ -108,12 +108,17 @@ properties: > HS/FS/LS modes are supported. > type: boolean > > + wakeup-source: true > + > # Required child node: > > patternProperties: > "^usb@[0-9a-f]+$": > $ref: snps,dwc3.yaml# > > + properties: > + wakeup-source: false > + > required: > - compatible > - reg > -- > 2.35.1 > -- மணிவண்ணன் சதாசிவம்