From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2BCD0C19F2D for ; Sat, 6 Aug 2022 14:00:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230246AbiHFOAw (ORCPT ); Sat, 6 Aug 2022 10:00:52 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59500 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231272AbiHFOAj (ORCPT ); Sat, 6 Aug 2022 10:00:39 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F1B96B4BD; Sat, 6 Aug 2022 07:00:37 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 5BA4960CD4; Sat, 6 Aug 2022 14:00:37 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A930FC433C1; Sat, 6 Aug 2022 14:00:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1659794436; bh=c8FZd3Ih39ycJVziZGntn4W31W4E806xekd9LOj/6JY=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=hgewUI9bHJLxlVSO90x+7UBAFRwTNKsmt6AdDuJE2Go5KD0aqwwcxWK5OApX3etcS +hzuSn+JTYmWCDSPOvwQQ2gClq417kUFIkwAHeSG6gMG3Uoug1BPTnWLQXnNtz0+Gv mc4qjztmyAtnKnXUYxFmx+w79QwXG/7NGPEV31bexQ7PVAuHzsbG9CYBQ0Jw8Uw4GB U7onZmzWtEW8o2FTx0SJbjau7m+v0MmqsucL4s9QZURQwzXUKMRs4cr6raznedeQjk sq7RmX4kmEAQy3p6+fyKbrsDIFzGTiCCMBBP/jANbwhond50rISEjw/WeRhD09sOWL W+tm5e40SrJig== Date: Sat, 6 Aug 2022 15:10:54 +0100 From: Jonathan Cameron To: Claudiu Beznea Cc: , , , , , , , , , Subject: Re: [PATCH v3 00/19] iio: adc: at91-sama5d2_adc: add support for temperature sensor Message-ID: <20220806151054.7c4d80e7@jic23-huawei> In-Reply-To: <20220803102855.2191070-1-claudiu.beznea@microchip.com> References: <20220803102855.2191070-1-claudiu.beznea@microchip.com> X-Mailer: Claws Mail 4.1.0 (GTK 3.24.34; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Wed, 3 Aug 2022 13:28:36 +0300 Claudiu Beznea wrote: > Hi, > > The following series add support for temperature sensor available on > SAMA7G5. > > Temperature sensor available on SAMA7G5 provides 2 outputs VTEMP and VBG. > VTEMP is proportional to the absolute temperature voltage and VBG is a > quasi-temperature independent voltage. Both are necessary in computing > the temperature (for better accuracy). Also, for better accuracy the > following settings were imposed when measusing the temperature: > oversampling rate of 256, sampling frequency of 10MHz, a startup time of > 512 ticks, MR.tracktim=0xf, EMR.trackx=0x3. > > For computing the temperature measured by ADC calibration data is > necessary. This is provided via OTP memory available on SAMA7G5. > > Patches 1/19-4/19 provides some fixes. > Patches 5/19-16/19 prepares for the addition of temperature sensor > support. > Patch 17/16 adds the temperature sensor support. > > Along with temperature sensor support I took the chance and added > runtime PM support in this series, too (handled in patch 19/19). > > The rest of patches in this series are minor cleanups. Dropped v2 adn replaced with this one. For now just pushed out as testing to let the autobuilders take another look at it. I'll rebase when rc1 is out and then push this out for linux-next to pick up. Thanks, Jonathan > > Thank you, > Claudiu Beznea > > Changes in v3: > - fixed compilation warning by adjusting patches 10/19, 11/19 > > Changes in v2: > - addressed review comments > - with this, new patches were intruced in this series: 2/19, 4/19, > 8/19, 9,19 > - runtime pm support has been adapted to work also when CONFIG_PM > is not enabled > - collected tags > > Claudiu Beznea (19): > iio: adc: at91-sama5d2_adc: fix AT91_SAMA5D2_MR_TRACKTIM_MAX > iio: adc: at91-sama5d2_adc: check return status for pressure and touch > iio: adc: at91-sama5d2_adc: lock around oversampling and sample freq > iio: adc: at91-sama5d2_adc: disable/prepare buffer on suspend/resume > iio: adc: at91-sama5d2_adc: exit from write_raw() when buffers are > enabled > iio: adc: at91-sama5d2_adc: handle different EMR.OSR for different hw > versions > iio: adc: at91-sama5d2_adc: move the check of oversampling in its > function > iio: adc: at91-sama5d2_adc: drop AT91_OSR_XSAMPLES defines > iio: adc: at91-sama5d2_adc: add .read_avail() chan_info ops > iio: adc: at91-sama5d2_adc: adjust osr based on specific platform data > iio: adc: at91-sama5d2_adc: add 64 and 256 oversampling ratio > iio: adc: at91-sama5d2_adc: move oversampling storage in its function > iio: adc: at91-sama5d2_adc: update trackx on emr > iio: adc: at91-sama5d2_adc: add startup and tracktim as parameter for > at91_adc_setup_samp_freq() > iio: adc: at91-sama5d2_adc: lock around at91_adc_read_info_raw() > dt-bindings: iio: adc: at91-sama5d2_adc: add id for temperature > channel > iio: adc: at91-sama5d2_adc: add support for temperature sensor > iio: adc: at91-sama5d2_adc: add empty line after functions > iio: adc: at91-sama5d2_adc: add runtime pm support > > drivers/iio/adc/at91-sama5d2_adc.c | 684 +++++++++++++++--- > .../dt-bindings/iio/adc/at91-sama5d2_adc.h | 3 + > 2 files changed, 568 insertions(+), 119 deletions(-) >