From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B8544C25B0C for ; Sat, 6 Aug 2022 16:52:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233118AbiHFQwu (ORCPT ); Sat, 6 Aug 2022 12:52:50 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36154 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232596AbiHFQwu (ORCPT ); Sat, 6 Aug 2022 12:52:50 -0400 Received: from mail-pl1-x635.google.com (mail-pl1-x635.google.com [IPv6:2607:f8b0:4864:20::635]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AD7AF12087 for ; Sat, 6 Aug 2022 09:52:48 -0700 (PDT) Received: by mail-pl1-x635.google.com with SMTP id p18so5138100plr.8 for ; Sat, 06 Aug 2022 09:52:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=tbINJ7QsOYoYb8ZFX+exoUH6wh4ff1wK54fBzhvpouw=; b=JOLyQbC/YMjp6EweqOCx5ld/GN+PK4jwMP0XxvuVyYh9wO2unrHYuKJF32mfYXhGV6 F0WYdaUb9qRQjhplg92+CUn3PP6MCZuDcMUXJvXJOfXDb6QIyELTbxDl9FuJCr5UiAol h8gW2GFN+ikLlDIYzwq5jlVhbZdxOwqBKSmrNKjeVpVctmFPUwkYw4dfiNqMQeX3Jso/ +fI8v5+eIyaYd45EsqVtHuP3xFVt4fiZdmj7d3CACYAjvxdymM0aTyLY0F7c6VEZZnG4 pQ7A5reXVmP8cMlHc8ch57dHzBzfAugQyLfDx0DZKi+NuY1WzXQKCLEDkj0m7DRKdfHZ HDtw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=tbINJ7QsOYoYb8ZFX+exoUH6wh4ff1wK54fBzhvpouw=; b=HML1NS4nxROkZsUHIvPuV/4dIA7C4qdG8hfVWhbLppy9oT+CfuMe3hqizpsYpEFYuV KFGdQLegqQ6kPkYNnqDBiMy005Ce58n4WByxr6Sk2Chpo71GUfw8joImsqjvdi9AAqVA N2/pjmluh0CrDF8NQ7eak4nBat2NaxFk0oUidMTFyvdRDJIP0cQQlPoyaa3wjlNOt1VP Qx5f6ESESzC6ROYipHhX/e/B/H0oRYS4ACHydhYCW2Imsj2gleZrC//5HhIbLmVX/Dmq bM9fh9F2FEEOrH6DCk9/mnXkRw4y/MTWVedOrGDIaMxc73QeUY0qB5eUXGYC7dtfoC1L FWnA== X-Gm-Message-State: ACgBeo259YCdaPMpaO1nTg9i2Dv19iNl2299B7P7IwrxgGkKRYreXlhh 4i+NslBmUfsA0iA7v5fCMbTM X-Google-Smtp-Source: AA6agR49CnysaV2RsOmCz8D4Gvyz4ZIECUCvGu6eXfolX5aecwTuqZ6ew8l7Y094y5DPffBRTAE4yw== X-Received: by 2002:a17:902:8d8a:b0:16f:21fb:b97a with SMTP id v10-20020a1709028d8a00b0016f21fbb97amr11712794plo.160.1659804768082; Sat, 06 Aug 2022 09:52:48 -0700 (PDT) Received: from thinkpad ([117.202.188.20]) by smtp.gmail.com with ESMTPSA id u14-20020a62790e000000b0052d78e73e6asm5189736pfc.184.2022.08.06.09.52.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 06 Aug 2022 09:52:47 -0700 (PDT) Date: Sat, 6 Aug 2022 22:22:38 +0530 From: Manivannan Sadhasivam To: Johan Hovold Cc: Johan Hovold , Greg Kroah-Hartman , Felipe Balbi , Rob Herring , Krzysztof Kozlowski , Andy Gross , Bjorn Andersson , Konrad Dybcio , Krishna Kurapati , Stephen Boyd , Doug Anderson , Matthias Kaehlcke , Pavankumar Kondeti , quic_ppratap@quicinc.com, quic_vpulyala@quicinc.com, linux-arm-msm@vger.kernel.org, linux-usb@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Rob Herring Subject: Re: [PATCH v2 7/9] dt-bindings: usb: qcom,dwc3: add wakeup-source property Message-ID: <20220806165238.GM14384@thinkpad> References: <20220804151001.23612-1-johan+linaro@kernel.org> <20220804151001.23612-8-johan+linaro@kernel.org> <20220806150848.GH14384@thinkpad> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Sat, Aug 06, 2022 at 06:41:37PM +0200, Johan Hovold wrote: > On Sat, Aug 06, 2022 at 08:38:48PM +0530, Manivannan Sadhasivam wrote: > > On Thu, Aug 04, 2022 at 05:09:59PM +0200, Johan Hovold wrote: > > > Add a wakeup-source property to the binding to describe whether the > > > wakeup interrupts can wake the system from suspend. > > > > > > Acked-by: Rob Herring > > > Signed-off-by: Johan Hovold > > > > So this is based on the fact that Qcom glue wrapper is supplying the wakeup > > interrupts. But isn't it possible that on other platform, the DWC IP can supply > > wakeup interrupts? > > Yeah, possibly, and that's why Rob suggested keeping the 'wakeup-source' > property also in the core node. > > > In the driver, the wakeup-source parsing has been moved to the Qcom glue driver. > > But this contradicts with the binding. > > That's irrelevant. The core driver does not implement wakeup support. It > was just added as a hack for the Qualcomm driver, and you won't get > wakeup-capability for other platforms by just parsing the property in > the core driver. > > When/if wakeup support for such a platform is added, then the core > driver may need to look at the property again. > My point is, the platform drivers are free to add "wakeup-source" property in the DWC node. Then in that case, the DWC driver should handle the capability, isn't it? I know it is broken currently, but moving the wakeup parsing code is not helping either. And... I'm aware of the fact that the binding should describe the hardware and not the limitation of the driver. So perhaps we should document it in the driver as a TODO or something? Thanks, Mani > Johan -- மணிவண்ணன் சதாசிவம்