From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1BBA4C19F2D for ; Tue, 9 Aug 2022 13:14:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243656AbiHINOE (ORCPT ); Tue, 9 Aug 2022 09:14:04 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33464 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239452AbiHINOD (ORCPT ); Tue, 9 Aug 2022 09:14:03 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 96E6B167EE; Tue, 9 Aug 2022 06:14:02 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 38839B8118F; Tue, 9 Aug 2022 13:14:01 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id CDFCFC433B5; Tue, 9 Aug 2022 13:13:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1660050840; bh=ggMaGF1n3P9YOw7cYW+PdU4XaojPEBQoi4FO74/VIcc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=bnT9a04/mVDQyNPIffdI/KyT0Wh1ABab9t7d0No5CVKbPG22Ej7B7n1X7moOITUE9 aSWiJK5mSI0Qmw76+4wa0N1Qw/VLtHO2L9KpGeoyh2vSkWCe2XazpC3jo846nJ+gKn pWmXI4NyLB3JZnXgrfeEe9NXi9UCk7ItHIRibEbiWZsUeCNSEVMN/Az3ncW+Hqvyt8 uViSk8bp+FQU46q3eOZzaGcbpEDY+bf5+0UI0DgD1DgEBTkCldXfUSmXegfEAsAn/i n25NxgVUtlTwCZX0bFJGoJD2eoRVKqbr+Hdb+YeEXDnOLji5s+ea9lv5e29iIbwWqO aI/MIsUSDAPfQ== Received: by pali.im (Postfix) id 87A97C1F; Tue, 9 Aug 2022 15:13:57 +0200 (CEST) Date: Tue, 9 Aug 2022 15:13:57 +0200 From: Pali =?utf-8?B?Um9ow6Fy?= To: Krzysztof Kozlowski Cc: Krzysztof Kozlowski , Rob Herring , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] dt-bindings: marvell: Update Armada 37xx platform bindings Message-ID: <20220809131357.u3dfsy3gu3iamiv7@pali> References: <20220713200123.22612-1-pali@kernel.org> <20220808202352.iimhb2q6yawi35y6@pali> <20a349c9-a479-ad5b-fe33-4758a773972e@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20a349c9-a479-ad5b-fe33-4758a773972e@linaro.org> User-Agent: NeoMutt/20180716 Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Tuesday 09 August 2022 08:58:50 Krzysztof Kozlowski wrote: > On 08/08/2022 23:23, Pali Rohár wrote: > > PING? > > > > On Wednesday 13 July 2022 22:01:23 Pali Rohár wrote: > >> Distinguish between Armada 3700 family, Armada 3710 SoC and Armada 3720 SoC. > >> Armada 3720 DB is name of the board with Armada 3720 SoC, so correctly > >> indicate SoC in example. > >> > >> Signed-off-by: Pali Rohár > >> --- > >> .../devicetree/bindings/arm/marvell/armada-37xx.txt | 7 ++++++- > >> 1 file changed, 6 insertions(+), 1 deletion(-) > >> > >> diff --git a/Documentation/devicetree/bindings/arm/marvell/armada-37xx.txt b/Documentation/devicetree/bindings/arm/marvell/armada-37xx.txt > >> index f6d6642d81c0..d2ca008de266 100644 > >> --- a/Documentation/devicetree/bindings/arm/marvell/armada-37xx.txt > >> +++ b/Documentation/devicetree/bindings/arm/marvell/armada-37xx.txt > >> @@ -4,6 +4,11 @@ Marvell Armada 37xx Platforms Device Tree Bindings > >> Boards using a SoC of the Marvell Armada 37xx family must carry the > >> following root node property: > >> > >> + - compatible: must contain "marvell,armada3700" > >> + > >> +In addition, boards using the Marvell Armada 3710 SoC shall have the > >> +following property before the previous one: > >> + > > The change is an ABI break, which looks reasonable, but still platform > maintainer should comment on it. Especially on the aspect why the > marvell,armada3710 fallback was chosen at the first place. I do not think this is ABI break but rather incorrect documentation and bug in some board dts files. > Unfortunately none of Marvel folks were CCed here, so you will need to > resend it. Otherwise no one will apply it, regardless of our ack. Done.