From: "Nícolas F. R. A. Prado" <nfraprado@collabora.com>
To: Tinghan Shen <tinghan.shen@mediatek.com>
Cc: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
Yong Wu <yong.wu@mediatek.com>, Joerg Roedel <joro@8bytes.org>,
Will Deacon <will@kernel.org>,
Robin Murphy <robin.murphy@arm.com>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Lee Jones <lee@kernel.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>,
MandyJH Liu <mandyjh.liu@mediatek.com>,
iommu@lists.linux.dev, linux-mediatek@lists.infradead.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
Project_Global_Chrome_Upstream_Group@mediatek.com
Subject: Re: [PATCH v5 02/20] dt-bindings: memory: mediatek: Update condition for mt8195 smi node
Date: Tue, 9 Aug 2022 09:53:12 -0400 [thread overview]
Message-ID: <20220809135312.hadcs7ti2cgyyuez@notapiano> (raw)
In-Reply-To: <6a1977971317059fcfad685869b6ccf233edcb68.camel@mediatek.com>
On Tue, Aug 09, 2022 at 07:01:10PM +0800, Tinghan Shen wrote:
> Hi Krzysztof,
>
> On Thu, 2022-08-04 at 17:12 +0200, Krzysztof Kozlowski wrote:
> > On 04/08/2022 04:15, Tinghan Shen wrote:
> > >
> > > It's because the 'mediatek,mt8195-smi-sub-common' compatible incorrectly
> > > matches the 'else' conditions for gen2 HW without gals.
> > >
> > > Rewrite the 'else' condition to specifically identify the compatibles
> > > that utilizing gen2 HW without gals.
> > >
> > > Signed-off-by: Tinghan Shen <tinghan.shen@mediatek.com>
> > > Reviewed-by: AngeloGioacchino Del Regno
> > > <angelogioacchino.delregno@collabora.com>
> >
> > Unfortunately, your patches got corrupted.
> >
> >
> > Best regards,
> > Krzysztof
>
> Do you mean rebase to the latest linux-next?
> I'll rebase in the next version, thanks!
Hi TingHan,
the issue is that some line wrapping happened on your patches, which broke tags
and also the diffs themselves (it's very obvious on patch 3). So you need to
sort out your setup so that no longer happens, and resend the patch.
Thanks,
Nícolas
next prev parent reply other threads:[~2022-08-09 13:53 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-04 2:15 [PATCH v5 00/20] Add driver nodes for MT8195 SoC Tinghan Shen
2022-08-04 2:15 ` [PATCH v5 01/20] dt-bindings: iommu: mediatek: Increase max interrupt number Tinghan Shen
2022-08-04 2:15 ` [PATCH v5 02/20] dt-bindings: memory: mediatek: Update condition for mt8195 smi node Tinghan Shen
2022-08-04 15:12 ` Krzysztof Kozlowski
2022-08-09 11:01 ` Tinghan Shen
2022-08-09 11:34 ` Krzysztof Kozlowski
2022-08-09 13:53 ` Nícolas F. R. A. Prado [this message]
2022-08-10 1:51 ` Tinghan Shen
2022-08-04 2:15 ` [PATCH v5 03/20] dt-bindings: power: mediatek: Refine multiple level power domain nodes Tinghan Shen
2022-08-04 2:15 ` [PATCH v5 04/20] dt-bindings: power: mediatek: Support naming power controller node with unit address Tinghan Shen
2022-08-04 2:15 ` [PATCH v5 05/20] dt-bindings: power: mediatek: Update maintainer list Tinghan Shen
2022-08-04 2:15 ` [PATCH v5 06/20] dt-bindings: power: mediatek: Add bindings for MediaTek SCPSYS Tinghan Shen
2022-08-10 11:32 ` Lee Jones
2022-08-10 12:52 ` Sebastian Reichel
2022-08-04 2:15 ` [PATCH v5 07/20] arm64: dts: mediatek: Update mt81xx scpsys node to align with dt-bindings Tinghan Shen
2022-08-04 2:15 ` [PATCH v5 08/20] arm64: dts: mt8195: Disable watchdog external reset signal Tinghan Shen
2022-08-04 2:15 ` [PATCH v5 09/20] arm64: dts: mt8195: Disable I2C0 node Tinghan Shen
2022-08-04 2:15 ` [PATCH v5 10/20] arm64: dts: mt8195: Add cpufreq node Tinghan Shen
2022-08-04 2:15 ` [PATCH v5 11/20] arm64: dts: mt8195: Add vdosys and vppsys clock nodes Tinghan Shen
2022-08-04 2:15 ` [PATCH v5 12/20] arm64: dts: mt8195: Add power domains controller Tinghan Shen
2022-08-04 2:15 ` [PATCH v5 13/20] arm64: dts: mt8195: Add spmi node Tinghan Shen
2022-08-04 2:15 ` [PATCH v5 14/20] arm64: dts: mt8195: Add scp node Tinghan Shen
2022-08-04 2:15 ` [PATCH v5 15/20] arm64: dts: mt8195: Add audio related nodes Tinghan Shen
2022-08-04 2:15 ` [PATCH v5 16/20] arm64: dts: mt8195: Add adsp node and adsp mailbox nodes Tinghan Shen
2022-08-04 2:15 ` [PATCH v5 17/20] arm64: dts: mt8195: Specify audio reset controller Tinghan Shen
2022-08-04 2:15 ` [PATCH v5 18/20] arm64: dts: mt8195: Add iommu and smi nodes Tinghan Shen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220809135312.hadcs7ti2cgyyuez@notapiano \
--to=nfraprado@collabora.com \
--cc=Project_Global_Chrome_Upstream_Group@mediatek.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=devicetree@vger.kernel.org \
--cc=iommu@lists.linux.dev \
--cc=joro@8bytes.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=lee@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=mandyjh.liu@mediatek.com \
--cc=matthias.bgg@gmail.com \
--cc=robh+dt@kernel.org \
--cc=robin.murphy@arm.com \
--cc=tinghan.shen@mediatek.com \
--cc=will@kernel.org \
--cc=yong.wu@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).