From: Guenter Roeck <linux@roeck-us.net>
To: Robert Marko <robert.marko@sartura.hr>
Cc: jdelvare@suse.com, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, lars.povlsen@microchip.com,
Steen.Hegelund@microchip.com, UNGLinuxDriver@microchip.com,
linux-hwmon@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, luka.perkov@sartura.hr
Subject: Re: [PATCH 1/2] dt-bindings: hwmon: sparx5: use correct clock
Date: Tue, 9 Aug 2022 07:21:39 -0700 [thread overview]
Message-ID: <20220809142139.GA2105857@roeck-us.net> (raw)
In-Reply-To: <20220809112209.241045-1-robert.marko@sartura.hr>
On Tue, Aug 09, 2022 at 01:22:08PM +0200, Robert Marko wrote:
> SparX-5 temperature sensor uses system reference clock and not the AHB bus
> clock as indicated by the register information [1].
>
> So, correct the clock description as well the included example.
>
> [1] https://microchip-ung.github.io/sparx-5_reginfo/reginfo_sparx-5.html?select=hsiowrap,temp_sensor,temp_sensor_cfg,clk_cycles_1us
>
> Fixes: f5520753c16f ("dt-bindings: hwmon: Add Sparx5 temperature sensor")
> Signed-off-by: Robert Marko <robert.marko@sartura.hr>
> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Applied.
Thanks,
Guenter
> ---
> .../devicetree/bindings/hwmon/microchip,sparx5-temp.yaml | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/hwmon/microchip,sparx5-temp.yaml b/Documentation/devicetree/bindings/hwmon/microchip,sparx5-temp.yaml
> index 76be625d5646..51e8619dbf3c 100644
> --- a/Documentation/devicetree/bindings/hwmon/microchip,sparx5-temp.yaml
> +++ b/Documentation/devicetree/bindings/hwmon/microchip,sparx5-temp.yaml
> @@ -22,7 +22,7 @@ properties:
>
> clocks:
> items:
> - - description: AHB reference clock
> + - description: System reference clock
>
> '#thermal-sensor-cells':
> const: 0
> @@ -40,5 +40,5 @@ examples:
> compatible = "microchip,sparx5-temp";
> reg = <0x10508110 0xc>;
> #thermal-sensor-cells = <0>;
> - clocks = <&ahb_clk>;
> + clocks = <&sys_clk>;
> };
prev parent reply other threads:[~2022-08-09 14:21 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-09 11:22 [PATCH 1/2] dt-bindings: hwmon: sparx5: use correct clock Robert Marko
2022-08-09 11:22 ` [PATCH 2/2] arm64: dts: microchip: sparx5: use correct clock for tmon Robert Marko
2022-08-09 11:31 ` [PATCH 1/2] dt-bindings: hwmon: sparx5: use correct clock Krzysztof Kozlowski
2022-08-09 14:21 ` Guenter Roeck [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220809142139.GA2105857@roeck-us.net \
--to=linux@roeck-us.net \
--cc=Steen.Hegelund@microchip.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=devicetree@vger.kernel.org \
--cc=jdelvare@suse.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lars.povlsen@microchip.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luka.perkov@sartura.hr \
--cc=robert.marko@sartura.hr \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).