[PATCH 1/2] dt-bindings: hwmon: sparx5: use correct clock

[PATCH 1/2] dt-bindings: hwmon: sparx5: use correct clock

[Robert Marko]

SparX-5 temperature sensor uses system reference clock and not the AHB bus
clock as indicated by the register information [1].

So, correct the clock description as well the included example.

[1] https://microchip-ung.github.io/sparx-5_reginfo/reginfo_sparx-5.html?select=hsiowrap,temp_sensor,temp_sensor_cfg,clk_cycles_1us

Fixes: f5520753c16f ("dt-bindings: hwmon: Add Sparx5 temperature sensor")
Signed-off-by: Robert Marko <robert.marko@sartura.hr>
---
 .../devicetree/bindings/hwmon/microchip,sparx5-temp.yaml      | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/Documentation/devicetree/bindings/hwmon/microchip,sparx5-temp.yaml b/Documentation/devicetree/bindings/hwmon/microchip,sparx5-temp.yaml
index 76be625d5646..51e8619dbf3c 100644
--- a/Documentation/devicetree/bindings/hwmon/microchip,sparx5-temp.yaml
+++ b/Documentation/devicetree/bindings/hwmon/microchip,sparx5-temp.yaml
@@ -22,7 +22,7 @@ properties:
 
   clocks:
     items:
-      - description: AHB reference clock
+      - description: System reference clock
 
   '#thermal-sensor-cells':
     const: 0
@@ -40,5 +40,5 @@ examples:
         compatible = "microchip,sparx5-temp";
         reg = <0x10508110 0xc>;
         #thermal-sensor-cells = <0>;
-        clocks = <&ahb_clk>;
+        clocks = <&sys_clk>;
     };
-- 
2.37.1

[PATCH 2/2] arm64: dts: microchip: sparx5: use correct clock for tmon

[Robert Marko]

SparX-5 temperature sensor uses system reference clock and not the AHB bus
clock as indicated by the register information [1].

Configured number of system clock cycles in one 1us is now almost spot on
to the default register value.

[1] https://microchip-ung.github.io/sparx-5_reginfo/reginfo_sparx-5.html?select=hsiowrap,temp_sensor,temp_sensor_cfg,clk_cycles_1us

Fixes: d14f6a1ae07f ("arm64: dts: sparx5: Add hwmon temperature sensor")
Signed-off-by: Robert Marko <robert.marko@sartura.hr>
---
 arch/arm64/boot/dts/microchip/sparx5.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/microchip/sparx5.dtsi b/arch/arm64/boot/dts/microchip/sparx5.dtsi
index 6f6aab48516e..c9367127670b 100644
--- a/arch/arm64/boot/dts/microchip/sparx5.dtsi
+++ b/arch/arm64/boot/dts/microchip/sparx5.dtsi
@@ -421,7 +421,7 @@ tmon0: tmon@610508110 {
 			compatible = "microchip,sparx5-temp";
 			reg = <0x6 0x10508110 0xc>;
 			#thermal-sensor-cells = <0>;
-			clocks = <&ahb_clk>;
+			clocks = <&sys_clk>;
 		};
 
 		mdio0: mdio@6110102b0 {
-- 
2.37.1

Re: [PATCH 1/2] dt-bindings: hwmon: sparx5: use correct clock

[Krzysztof Kozlowski]

On 09/08/2022 14:22, Robert Marko wrote:
> SparX-5 temperature sensor uses system reference clock and not the AHB bus
> clock as indicated by the register information [1].
> 
> So, correct the clock description as well the included example.
> 
> [1] https://microchip-ung.github.io/sparx-5_reginfo/reginfo_sparx-5.html?select=hsiowrap,temp_sensor,temp_sensor_cfg,clk_cycles_1us
> 


Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>


Best regards,
Krzysztof

Re: [PATCH 1/2] dt-bindings: hwmon: sparx5: use correct clock

[Guenter Roeck]

On Tue, Aug 09, 2022 at 01:22:08PM +0200, Robert Marko wrote:
> SparX-5 temperature sensor uses system reference clock and not the AHB bus
> clock as indicated by the register information [1].
> 
> So, correct the clock description as well the included example.
> 
> [1] https://microchip-ung.github.io/sparx-5_reginfo/reginfo_sparx-5.html?select=hsiowrap,temp_sensor,temp_sensor_cfg,clk_cycles_1us
> 
> Fixes: f5520753c16f ("dt-bindings: hwmon: Add Sparx5 temperature sensor")
> Signed-off-by: Robert Marko <robert.marko@sartura.hr>
> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Applied.

Thanks,
Guenter

> ---
>  .../devicetree/bindings/hwmon/microchip,sparx5-temp.yaml      | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/hwmon/microchip,sparx5-temp.yaml b/Documentation/devicetree/bindings/hwmon/microchip,sparx5-temp.yaml
> index 76be625d5646..51e8619dbf3c 100644
> --- a/Documentation/devicetree/bindings/hwmon/microchip,sparx5-temp.yaml
> +++ b/Documentation/devicetree/bindings/hwmon/microchip,sparx5-temp.yaml
> @@ -22,7 +22,7 @@ properties:
>  
>    clocks:
>      items:
> -      - description: AHB reference clock
> +      - description: System reference clock
>  
>    '#thermal-sensor-cells':
>      const: 0
> @@ -40,5 +40,5 @@ examples:
>          compatible = "microchip,sparx5-temp";
>          reg = <0x10508110 0xc>;
>          #thermal-sensor-cells = <0>;
> -        clocks = <&ahb_clk>;
> +        clocks = <&sys_clk>;
>      };