From: Rob Herring <robh@kernel.org>
To: Zhu Ning <zhuning0077@gmail.com>
Cc: alsa-devel@alsa-project.org,
pierre-louis.bossart@linux.intel.com, tiwai@suse.com,
broonie@kernel.org, devicetree@vger.kernel.org,
David Yang <yangxiaohua@everest-semi.com>,
Zhu Ning <zhuning@everest-semi.com>
Subject: Re: [PATCH v5 1/2] ASoC: dt-bindings: Add Everest ES8326 audio CODEC
Date: Tue, 9 Aug 2022 12:34:12 -0600 [thread overview]
Message-ID: <20220809183412.GA2152771-robh@kernel.org> (raw)
In-Reply-To: <20220804091800.744316-1-zhuning0077@gmail.com>
On Thu, Aug 04, 2022 at 05:17:59PM +0800, Zhu Ning wrote:
> Add device tree binding documentation for Everest ES8326
>
> Signed-off-by: David Yang <yangxiaohua@everest-semi.com>
> Signed-off-by: Zhu Ning <zhuning@everest-semi.com>
> ----
> v5 tested by dtschema
> ---
> .../bindings/sound/everest,es8326.yaml | 116 ++++++++++++++++++
> 1 file changed, 116 insertions(+)
> create mode 100755 Documentation/devicetree/bindings/sound/everest,es8326.yaml
>
> diff --git a/Documentation/devicetree/bindings/sound/everest,es8326.yaml b/Documentation/devicetree/bindings/sound/everest,es8326.yaml
> new file mode 100755
> index 000000000000..07781408e788
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/sound/everest,es8326.yaml
> @@ -0,0 +1,116 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/sound/everest,es8326.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Everest ES8326 audio CODEC
> +
> +maintainers:
> + - David Yang <yangxiaohua@everest-semi.com>
> +
> +properties:
> + compatible:
> + const: everest,es8326
> +
> + reg:
> + maxItems: 1
> +
> + clocks:
> + items:
> + - description: clock for master clock (MCLK)
> +
> + clock-names:
> + items:
> + - const: mclk
> +
> + "#sound-dai-cells":
> + const: 0
> +
> + everest,jack-pol:
> + $ref: /schemas/types.yaml#/definitions/uint8
> + description: |
> + just the value of reg 57. Bit(3) decides whether the jack polarity is inverted.
> + Bit(2) decides whether the button on the headset is inverted.
> + Bit(1)/(0) decides the mic properity to be OMTP/CTIA or auto.
> + minimum: 0x00
> + maximum: 0x0f
> + default: 0x0f
> +
> + everest,mic1-src:
> + $ref: /schemas/types.yaml#/definitions/uint8
> + description:
> + the value of reg 2A when headset plugged.
> + minimum: 0x00
> + maximum: 0x77
> + default: 0x22
> +
> + everest,mic2-src:
> + $ref: /schemas/types.yaml#/definitions/uint8
> + description:
> + the value of reg 2A when headset unplugged.
> + minimum: 0x00
> + maximum: 0x77
> + default: 0x44
> +
> + everest,jack-detect-inverted:
> + $ref: /schemas/types.yaml#/definitions/flag
> + description:
> + Defined to invert the jack detection.
No response to my questions on v3?
Rob
next prev parent reply other threads:[~2022-08-09 19:02 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-04 9:17 [PATCH v5 1/2] ASoC: dt-bindings: Add Everest ES8326 audio CODEC Zhu Ning
2022-08-04 9:18 ` [PATCH v5 2/2] ASoC: codecs: add support for ES8326 Zhu Ning
2022-08-12 15:11 ` Amadeusz Sławiński
2022-08-09 18:34 ` Rob Herring [this message]
2022-08-10 1:36 ` [PATCH v5 2/2] ASoC: dt-bindings: Add Everest ES8326 audio CODEC Zhu Ning
2022-08-16 13:48 ` [PATCH v5 1/2] " Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220809183412.GA2152771-robh@kernel.org \
--to=robh@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=tiwai@suse.com \
--cc=yangxiaohua@everest-semi.com \
--cc=zhuning0077@gmail.com \
--cc=zhuning@everest-semi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).