From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BBA99C25B06 for ; Tue, 9 Aug 2022 20:11:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233564AbiHIULo (ORCPT ); Tue, 9 Aug 2022 16:11:44 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35384 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S242787AbiHIULn (ORCPT ); Tue, 9 Aug 2022 16:11:43 -0400 Received: from mail-io1-f50.google.com (mail-io1-f50.google.com [209.85.166.50]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8372D2529A; Tue, 9 Aug 2022 13:11:42 -0700 (PDT) Received: by mail-io1-f50.google.com with SMTP id v185so10484331ioe.11; Tue, 09 Aug 2022 13:11:42 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc; bh=O7HyUi1f0ct7jTcgS94yy1BXUesuJlz9DhUnCLRbuzo=; b=tHwYoyxMIb5Ky8AtbLjR00bLLbxM8pQFOEIQYYvxLdQwGDaWiIeXBRqAJkOO7sWu/0 S5zHsQEXhErUrxAfmpW9HERS2sxRWDIBHNq3zTVmXybboYDlNnt+uJeHnvG9e15hJhuK DxSc+hYCdflN1mi3IMBeu8tXfrBk6sQmjxXWV+bksxTBfdPUuPEsoYwjaWvoQYi9dgbJ iMAQhuGvqKqn9q1aszK8b+6YAyXVfPmc54wF5ufh63Fgp+9TgkhyT9BPFboXYa/ZIW64 aDdZaFtrCvAow+lNW/K1v05B/+18FJGrdwPfnROA2J9x5HLyw6+Vg5ExJcYVCll+gY8T 9Hiw== X-Gm-Message-State: ACgBeo14XJK9L5lGhijNTJdrYppdmLtiNJYQfF+YsvRgjt0j/Z+oaPov vpjFc6mlLEGiEpUjppGdqA== X-Google-Smtp-Source: AA6agR5KNR1iNXBpflAdtpiggKTLjG7yChdjG4ZWxFrMi569KUIrNbjVLoqn8zln7/MRDKRAympSiw== X-Received: by 2002:a02:661e:0:b0:342:c2ba:38ac with SMTP id k30-20020a02661e000000b00342c2ba38acmr8982398jac.143.1660075901657; Tue, 09 Aug 2022 13:11:41 -0700 (PDT) Received: from robh.at.kernel.org ([64.188.179.248]) by smtp.gmail.com with ESMTPSA id e13-20020a92690d000000b002dc1d6652cesm1395714ilc.13.2022.08.09.13.11.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 09 Aug 2022 13:11:41 -0700 (PDT) Received: (nullmailer pid 2312049 invoked by uid 1000); Tue, 09 Aug 2022 20:11:35 -0000 Date: Tue, 9 Aug 2022 14:11:35 -0600 From: Rob Herring To: Vladimir Oltean Cc: Linus Walleij , Vladimir Oltean , =?UTF-8?B?TWFyZWsgQmVow7pu?= , DENG Qingfang , linux-renesas-soc@vger.kernel.org, Claudiu Manoil , Landen Chao , devicetree@vger.kernel.org, Krzysztof Kozlowski , Rob Herring , George McCollister , =?UTF-8?B?Q2zDqW1lbnQgTMOpZ2Vy?= , Vivien Didelot , John Crispin , Kurt Kanzenbach , Woojung Huh , Luiz Angelo Daros de Luca , Matthias Brugger , Geert Uytterhoeven , Aleksander Jan Bajkowski , UNGLinuxDriver@microchip.com, Marek Vasut , =?UTF-8?Q?Alvin_=C5=A0ipraga?= , Arun Ramadoss , Martin Blumenstingl , Oleksij Rempel , Hauke Mehrtens , Mans Rullgard , Russell King , Andrew Lunn , Jakub Kicinski , Eric Dumazet , Sean Wang , netdev@vger.kernel.org, Pawel Dembicki , Marcin Wojtas , Paolo Abeni , Christian Marangi , "David S. Miller" , Alexandre Belloni , Florian Fainelli Subject: Re: [RFC PATCH v3 net-next 02/10] dt-bindings: net: dsa: hellcreek: add missing CPU port phy-mode/fixed-link to example Message-ID: <20220809201135.GA2312015-robh@kernel.org> References: <20220806141059.2498226-1-vladimir.oltean@nxp.com> <20220806141059.2498226-3-vladimir.oltean@nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220806141059.2498226-3-vladimir.oltean@nxp.com> Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Sat, 06 Aug 2022 17:10:51 +0300, Vladimir Oltean wrote: > Looking at hellcreek_phylink_get_caps(), I see that depending on whether > is_100_mbits is set, speeds of 1G or of 100M will be advertised. The > de1soc_r1_pdata sets is_100_mbits to true. > > The PHY modes declared in the capabilities are MII, RGMII and GMII. GMII > doesn't support 100Mbps, and as for RGMII, it would be a bit implausible > to me to support this PHY mode but limit it to only 25 MHz. So I've > settled on MII as a phy-mode in the example, and a fixed-link of > 100Mbps. > > As a side note, there exists such a thing as "rev-mii", because the MII > protocol is asymmetric, and "mii" is the designation for the MAC side > (expected to be connected to a PHY), and "rev-mii" is the designation > for the PHY side (expected to be connected to a MAC). I wonder whether > "mii" or "rev-mii" should actually be used here, since this is a CPU > port and presumably connected to another MAC. > > Signed-off-by: Vladimir Oltean > --- > v2->v3: patch is new > > .../devicetree/bindings/net/dsa/hirschmann,hellcreek.yaml | 6 ++++++ > 1 file changed, 6 insertions(+) > Acked-by: Rob Herring