From: Zhu Ning <zhuning0077@gmail.com>
To: alsa-devel@alsa-project.org
Cc: robh@kernel.org, pierre-louis.bossart@linux.intel.com,
tiwai@suse.com, broonie@kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v5 2/2] ASoC: dt-bindings: Add Everest ES8326 audio CODEC
Date: Wed, 10 Aug 2022 09:36:27 +0800 [thread overview]
Message-ID: <20220810013627.1156202-1-zhuning0077@gmail.com> (raw)
In-Reply-To: <20220809183412.GA2152771-robh@kernel.org>
>> + everest,jack-detect-inverted:
>> + description:
>> + Defined to invert the jack detection.
>
>What's the difference with this and bit 3 of everest,jack-pol?
>
>We already have numerous vendor properties for jack detect. Can we come
>up with something common?
>
>The problem with 'inverted' is it assumes you know the non-inverted
>state. Better to just state high or low.
This property is in compatible with the property in es8316.c and sof_essx8336.c.
(which is not documented in es8316.yaml, another problem)
There is a quirk in sof_essx8336.c so that when the user find they're having a
wrong jack insert configuration, they can set the quirk to invert it.
next prev parent reply other threads:[~2022-08-10 1:37 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-04 9:17 [PATCH v5 1/2] ASoC: dt-bindings: Add Everest ES8326 audio CODEC Zhu Ning
2022-08-04 9:18 ` [PATCH v5 2/2] ASoC: codecs: add support for ES8326 Zhu Ning
2022-08-12 15:11 ` Amadeusz Sławiński
2022-08-09 18:34 ` [PATCH v5 1/2] ASoC: dt-bindings: Add Everest ES8326 audio CODEC Rob Herring
2022-08-10 1:36 ` Zhu Ning [this message]
2022-08-16 13:48 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220810013627.1156202-1-zhuning0077@gmail.com \
--to=zhuning0077@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=robh@kernel.org \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).