From: Chris Morgan <macroalpha82@gmail.com>
To: linux-rockchip@lists.infradead.org
Cc: linux-phy@lists.infradead.org, devicetree@vger.kernel.org,
dri-devel@lists.freedesktop.org, vkoul@kernel.org, kishon@ti.com,
krzysztof.kozlowski+dt@linaro.org, robh+dt@kernel.org,
daniel@ffwll.ch, airlied@linux.ie, heiko@sntech.de,
hjc@rock-chips.com, Chris Morgan <macromorgan@hotmail.com>
Subject: [RFC 0/4] rockchip-dsi for rk3568
Date: Fri, 12 Aug 2022 09:32:43 -0500 [thread overview]
Message-ID: <20220812143247.25825-1-macroalpha82@gmail.com> (raw)
From: Chris Morgan <macromorgan@hotmail.com>
This series adds support for the dsi and dphy controllers on the
Rockchip RK3568. I can confirm that for the Rockchip RK3568 this
current series DOES NOT WORK properly yet. The image on the screen
is shifted about 100 pixels to the right and does not appear to be
a timing issue. This behavior was observed on both the Anbernic RG503
and RG353 portable gaming devices with different screens. These changes
were also tested on an RK3326 based device (an Odroid Go Advance) with
no noticeable regressions.
An example of the issue on multiple devices:
https://media.discordapp.net/attachments/973914035890290718/1007407064647221299/IMG_1999.jpg
https://media.discordapp.net/attachments/995430498677571604/1003754966932008960/AB25898E-73EC-40A9-BD47-3FB970DDFB31.jpg
Given the fact that the DSI controller is identical on the PX30 and
RK3568 aside from different grf registers I am assuming the PHY is
likely where the bugs are currently. I'm posting this as an RFC in the
hopes that someone more knowledgeable than I can help identify the
problem.
Chris Morgan (4):
dt-bindings: display: rockchip-dsi: add rk3568 compatible
dt-bindings: phy: phy-rockchip-inno-dsidphy: add compatible for rk3568
drm/rockchip: dsi: add rk3568 support
phy/rockchip: inno-dsidphy: Add support for rk3568
.../display/rockchip/dw_mipi_dsi_rockchip.txt | 1 +
.../bindings/phy/rockchip,px30-dsi-dphy.yaml | 1 +
.../gpu/drm/rockchip/dw-mipi-dsi-rockchip.c | 51 ++++-
.../phy/rockchip/phy-rockchip-inno-dsidphy.c | 204 ++++++++++++++----
4 files changed, 209 insertions(+), 48 deletions(-)
--
2.25.1
next reply other threads:[~2022-08-12 14:32 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-12 14:32 Chris Morgan [this message]
2022-08-12 14:32 ` [RFC 1/4] dt-bindings: display: rockchip-dsi: add rk3568 compatible Chris Morgan
2022-08-16 17:22 ` Rob Herring
2022-08-12 14:32 ` [RFC 2/4] dt-bindings: phy: phy-rockchip-inno-dsidphy: add compatible for rk3568 Chris Morgan
2022-08-16 17:22 ` Rob Herring
2022-08-12 14:32 ` [RFC 3/4] drm/rockchip: dsi: add rk3568 support Chris Morgan
2022-08-12 14:32 ` [RFC 4/4] phy/rockchip: inno-dsidphy: Add support for rk3568 Chris Morgan
2022-08-14 13:11 ` [RFC 0/4] rockchip-dsi " Peter Geis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220812143247.25825-1-macroalpha82@gmail.com \
--to=macroalpha82@gmail.com \
--cc=airlied@linux.ie \
--cc=daniel@ffwll.ch \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=heiko@sntech.de \
--cc=hjc@rock-chips.com \
--cc=kishon@ti.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-phy@lists.infradead.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=macromorgan@hotmail.com \
--cc=robh+dt@kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).