From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7FC2FC25B0E for ; Mon, 15 Aug 2022 13:58:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232895AbiHON6Q (ORCPT ); Mon, 15 Aug 2022 09:58:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42594 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232477AbiHON6O (ORCPT ); Mon, 15 Aug 2022 09:58:14 -0400 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 243CD22B1F for ; Mon, 15 Aug 2022 06:58:14 -0700 (PDT) Received: from ptx.hi.pengutronix.de ([2001:67c:670:100:1d::c0]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oNabN-0002nz-5Y; Mon, 15 Aug 2022 15:57:57 +0200 Received: from sha by ptx.hi.pengutronix.de with local (Exim 4.92) (envelope-from ) id 1oNabM-00075V-1g; Mon, 15 Aug 2022 15:57:56 +0200 Date: Mon, 15 Aug 2022 15:57:56 +0200 From: Sascha Hauer To: "Peng Fan (OSS)" Cc: abelvesa@kernel.org, abel.vesa@linaro.org, mturquette@baylibre.com, sboyd@kernel.org, shawnguo@kernel.org, kernel@pengutronix.de, festevam@gmail.com, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, linux-imx@nxp.com, linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Peng Fan Subject: Re: [PATCH 1/2] dt-bindings: clock: imx8m: introduce fsl,protected-clocks property Message-ID: <20220815135756.GC17485@pengutronix.de> References: <20220815033632.1687854-1-peng.fan@oss.nxp.com> <20220815033632.1687854-2-peng.fan@oss.nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220815033632.1687854-2-peng.fan@oss.nxp.com> X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-Accept-Language: de,en X-Accept-Content-Type: text/plain User-Agent: Mutt/1.10.1 (2018-07-13) X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::c0 X-SA-Exim-Mail-From: sha@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: devicetree@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hi Peng, On Mon, Aug 15, 2022 at 11:36:31AM +0800, Peng Fan (OSS) wrote: > From: Peng Fan > > i.MX8M Linux run on top of Jailhouse hypervisor, the root cell Linux > should not disable clocks used by inmate. This would also benifit > AMP to avoid Linux disable clocks used by Cortex-M4/M7. > > So introduce fsl,protected-clocks for above case. > > Signed-off-by: Peng Fan > --- > Documentation/devicetree/bindings/clock/imx8m-clock.yaml | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/Documentation/devicetree/bindings/clock/imx8m-clock.yaml b/Documentation/devicetree/bindings/clock/imx8m-clock.yaml > index 458c7645ee68..0ec490ff9a09 100644 > --- a/Documentation/devicetree/bindings/clock/imx8m-clock.yaml > +++ b/Documentation/devicetree/bindings/clock/imx8m-clock.yaml > @@ -39,6 +39,10 @@ properties: > ID in its "clocks" phandle cell. See include/dt-bindings/clock/imx8m-clock.h > for the full list of i.MX8M clock IDs. > > + fsl,protected-clocks: > + description: List of the Protected clock. > + $ref: /schemas/types.yaml#/definitions/uint32-array There already is a generic protected-clocks property described in https://github.com/devicetree-org/dt-schema/blob/0d1b78cd0c3d9a3d523ced17d7da64b03f6c18ea/dtschema/schemas/clock/clock.yaml#L131 We probably shouldn't add a property with the same name but different meaning. I am not sure if we want to go the route of a fsl specific property, it looks like other SoCs could have similar problems and it might be worth solving this problem with a broader view. Anyway, please add a description to the binding what this property actually does. Sascha -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |