From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A2F88C25B08 for ; Wed, 17 Aug 2022 09:47:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229781AbiHQJrn (ORCPT ); Wed, 17 Aug 2022 05:47:43 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59642 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229980AbiHQJrT (ORCPT ); Wed, 17 Aug 2022 05:47:19 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F13AD6B161; Wed, 17 Aug 2022 02:47:18 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 9F399B81BAB; Wed, 17 Aug 2022 09:47:17 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D3BF1C433D7; Wed, 17 Aug 2022 09:47:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1660729636; bh=Qcruij7g38NyR2lHzkGqFZ8XU8XPZecu7Higao6ZkKE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=RDSDvSPOpWDQ0dJ0qNKhdgc29+ejPMevlBuXxi4pal5VBqNzkzGygWNAWZ6PSIQBi NGRY/+Hg3BxKPrHBoIu7lyWzA3iJyQtjaq1+p0pkzr7QD+5ucwPvSqY3xP3b7z1rzl Ufq5FrRwEV4s1+chv28Er16uLSIIl/YYzFSwi4VJWsXkE1GJPP6qKN/iLyg3pLEtRP 6ToyiBs2JNB/QkfQ8/a9WXcrpqmSaLhVj5/eeFYjgWd2t+4zZUahPWkSG+rl4nJMv+ 6Wa34mfh2rIvPSxy8LAxblKCHUvQT2lsTHiX9KaB+37clhVu/R5ksJ2XlRjvhtFmZ0 3hemODx1pPL8w== Date: Wed, 17 Aug 2022 17:47:08 +0800 From: Shawn Guo To: wei.fang@nxp.com Cc: davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, s.hauer@pengutronix.de, netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com, peng.fan@nxp.com, ping.bai@nxp.com, sudeep.holla@arm.com, linux-arm-kernel@lists.infradead.org, aisheng.dong@nxp.com Subject: Re: [PATCH V4 2/3] arm64: dts: imx8ulp: Add the fec support Message-ID: <20220817094708.GC149610@dragon> References: <20220726143853.23709-1-wei.fang@nxp.com> <20220726143853.23709-3-wei.fang@nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220726143853.23709-3-wei.fang@nxp.com> Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Wed, Jul 27, 2022 at 12:38:52AM +1000, wei.fang@nxp.com wrote: > From: Wei Fang > > Add the fec support on i.MX8ULP platforms. > > Signed-off-by: Wei Fang > Reviewed-by: Ahmad Fatoum > --- > V2 change: > Remove the external clocks which is related to specific board. > V3 change: > No change. > V4 Change: > Add Reviewed-by tag. > --- > arch/arm64/boot/dts/freescale/imx8ulp.dtsi | 11 +++++++++++ > 1 file changed, 11 insertions(+) > > diff --git a/arch/arm64/boot/dts/freescale/imx8ulp.dtsi b/arch/arm64/boot/dts/freescale/imx8ulp.dtsi > index 60c1b018bf03..3e8a1e4f0fc2 100644 > --- a/arch/arm64/boot/dts/freescale/imx8ulp.dtsi > +++ b/arch/arm64/boot/dts/freescale/imx8ulp.dtsi > @@ -16,6 +16,7 @@ / { > #size-cells = <2>; > > aliases { > + ethernet0 = &fec; > gpio0 = &gpiod; > gpio1 = &gpioe; > gpio2 = &gpiof; > @@ -365,6 +366,16 @@ usdhc2: mmc@298f0000 { > bus-width = <4>; > status = "disabled"; > }; > + > + fec: ethernet@29950000 { > + compatible = "fsl,imx8ulp-fec", "fsl,imx6ul-fec", "fsl,imx6q-fec"; Since imx8ulp-fec is compatible with imx6ul-fec, what's the point of having imx6q-fec in there? It can be dropped, I guess? Shawn > + reg = <0x29950000 0x10000>; > + interrupts = ; > + interrupt-names = "int0"; > + fsl,num-tx-queues = <1>; > + fsl,num-rx-queues = <1>; > + status = "disabled"; > + }; > }; > > gpioe: gpio@2d000080 { > -- > 2.25.1 >