From: Rob Herring <robh@kernel.org>
To: Eliav Farber <farbere@amazon.com>
Cc: brgl@bgdev.pl, mark.rutland@arm.com, arnd@arndb.de,
gregkh@linuxfoundation.org, linux-i2c@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
talel@amazon.com, hhhawa@amazon.com, jonnyc@amazon.com,
hanochu@amazon.com, ronenk@amazon.com, itamark@amazon.com,
shellykz@amazon.com, shorer@amazon.com, amitlavi@amazon.com,
almogbs@amazon.com, dwmw@amazon.co.uk
Subject: Re: [PATCH 1/2] dt-bindings: at24: new optional property - enable-gpios
Date: Wed, 17 Aug 2022 19:48:39 -0600 [thread overview]
Message-ID: <20220818014839.GD921960-robh@kernel.org> (raw)
In-Reply-To: <20220816130002.41450-2-farbere@amazon.com>
On Tue, Aug 16, 2022 at 01:00:01PM +0000, Eliav Farber wrote:
> Boards using the AT24 EEPROMs might have a GPIO that must be set to
> enable the chip (e.g. pin that controls the power supply).
>
If this is a power supply control, use a gpio regulator.
> Add a new optional property to the device tree binding document, which
> allows to specify the GPIO line to which the enable pin is connected.
>
> On Linux this means that we need to hog the line at the beginning of
> probe function.
>
> Signed-off-by: Eliav Farber <farbere@amazon.com>
> ---
> Documentation/devicetree/bindings/eeprom/at24.txt | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/eeprom/at24.txt b/Documentation/devicetree/bindings/eeprom/at24.txt
> index f9a7c984274c..553b53ed3e4c 100644
> --- a/Documentation/devicetree/bindings/eeprom/at24.txt
> +++ b/Documentation/devicetree/bindings/eeprom/at24.txt
> @@ -73,6 +73,9 @@ Optional properties:
>
> - wp-gpios: GPIO to which the write-protect pin of the chip is connected.
>
> + - enable-gpios: GPIO to enables the chip (e.g. pin that controls the eeprom
> + power supply).
> +
> - address-width: number of address bits (one of 8, 16).
>
> Example:
> --
> 2.37.1
>
next prev parent reply other threads:[~2022-08-18 1:48 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-16 13:00 [PATCH 0/2] add enable gpio support for a24 eeprom driver Eliav Farber
2022-08-16 13:00 ` [PATCH 1/2] dt-bindings: at24: new optional property - enable-gpios Eliav Farber
2022-08-18 1:48 ` Rob Herring [this message]
2022-08-18 15:59 ` Farber, Eliav
2022-08-16 13:00 ` [PATCH 2/2] eeprom: at24: add enable gpio support Eliav Farber
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220818014839.GD921960-robh@kernel.org \
--to=robh@kernel.org \
--cc=almogbs@amazon.com \
--cc=amitlavi@amazon.com \
--cc=arnd@arndb.de \
--cc=brgl@bgdev.pl \
--cc=devicetree@vger.kernel.org \
--cc=dwmw@amazon.co.uk \
--cc=farbere@amazon.com \
--cc=gregkh@linuxfoundation.org \
--cc=hanochu@amazon.com \
--cc=hhhawa@amazon.com \
--cc=itamark@amazon.com \
--cc=jonnyc@amazon.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=ronenk@amazon.com \
--cc=shellykz@amazon.com \
--cc=shorer@amazon.com \
--cc=talel@amazon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).