From: Rob Herring <robh@kernel.org>
To: Eliav Farber <farbere@amazon.com>
Cc: jdelvare@suse.com, linux@roeck-us.net, mark.rutland@arm.com,
linux-hwmon@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, talel@amazon.com,
hhhawa@amazon.com, jonnyc@amazon.com, hanochu@amazon.com,
ronenk@amazon.com, itamark@amazon.com, shellykz@amazon.com,
shorer@amazon.com, amitlavi@amazon.com, almogbs@amazon.com,
dwmw@amazon.co.uk, rtanwar@maxlinear.com
Subject: Re: [PATCH 03/16] hwmon: (mr75203) update Moortec PVT controller intel,vm-map property
Date: Thu, 18 Aug 2022 09:02:54 -0600 [thread overview]
Message-ID: <20220818150254.GH1829017-robh@kernel.org> (raw)
In-Reply-To: <20220816082757.11990-4-farbere@amazon.com>
On Tue, Aug 16, 2022 at 08:27:44AM +0000, Eliav Farber wrote:
> The "intel,vm-map property" is optional and not required.
Please follow the subject format for the subsystem (bindings).
>
> Signed-off-by: Eliav Farber <farbere@amazon.com>
> ---
> Documentation/devicetree/bindings/hwmon/moortec,mr75203.yaml | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/hwmon/moortec,mr75203.yaml b/Documentation/devicetree/bindings/hwmon/moortec,mr75203.yaml
> index 6f3e3c01f717..f9e849cc73e0 100644
> --- a/Documentation/devicetree/bindings/hwmon/moortec,mr75203.yaml
> +++ b/Documentation/devicetree/bindings/hwmon/moortec,mr75203.yaml
> @@ -48,12 +48,12 @@ required:
> - compatible
> - reg
> - reg-names
> - - intel,vm-map
> - clocks
> - resets
> - "#thermal-sensor-cells"
>
> -additionalProperties: false
> +additionalProperties:
> + - intel,vm-map
Please test your changes. Not valid json-schema.
>
> examples:
> - |
> --
> 2.37.1
>
next prev parent reply other threads:[~2022-08-18 15:03 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-16 8:27 [PATCH 00/16] Variety of fixes and new features for mr75203 driver Eliav Farber
2022-08-16 8:27 ` [PATCH 01/16] hwmon: (mr75203) fix VM sensor allocation when "intel,vm-map" not defined Eliav Farber
2022-08-16 8:27 ` [PATCH 02/16] hwmon: (mr75203) update pvt->v_num to the actual number of used sensors Eliav Farber
2022-08-16 8:27 ` [PATCH 03/16] hwmon: (mr75203) update Moortec PVT controller intel,vm-map property Eliav Farber
2022-08-18 15:02 ` Rob Herring [this message]
2022-08-16 8:27 ` [PATCH 04/16] hwmon: (mr75203) add Moortec PVT controller reset-control-skip property Eliav Farber
2022-08-16 8:27 ` [PATCH 05/16] hwmon: (mr75203) add option to skip reset controller Eliav Farber
2022-08-16 8:27 ` [PATCH 06/16] hwmon: (mr75203) fix multi-channel voltage reading Eliav Farber
2022-08-16 8:27 ` [PATCH 07/16] hwmon: (mr75203) add VM active channels property for Moortec PVT controller Eliav Farber
2022-08-16 8:27 ` [PATCH 08/16] hwmon: (mr75203) add VM active channel support Eliav Farber
2022-08-16 16:52 ` kernel test robot
2022-08-16 18:17 ` kernel test robot
2022-08-16 19:55 ` kernel test robot
2022-08-16 8:27 ` [PATCH 09/16] hwmon: (mr75203) add VM pre-scalar property for Moortec PVT controller Eliav Farber
2022-08-16 8:27 ` [PATCH 10/16] hwmon: (mr75203) add VM pre-scalar support Eliav Farber
2022-08-16 8:27 ` [PATCH 11/16] hwmon: (mr75203) add protection for negative voltage value Eliav Farber
2022-08-16 8:27 ` [PATCH 12/16] hwmon: (mr75203) modify the temperature equation Eliav Farber
2022-08-16 8:27 ` [PATCH 13/16] hwmon: (mr75203) add thermal coefficient properties for Moortec PVT controller Eliav Farber
2022-08-18 15:05 ` Rob Herring
2022-08-16 8:27 ` [PATCH 14/16] hwmon: (mr75203) parse thermal coefficients from device-tree Eliav Farber
2022-08-16 8:27 ` [PATCH 15/16] hwmon: (mr75203) fix coding style space errors Eliav Farber
2022-08-16 8:27 ` [PATCH 16/16] hwmon: (mr75203) add debugfs to read and write temperature coefficients Eliav Farber
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220818150254.GH1829017-robh@kernel.org \
--to=robh@kernel.org \
--cc=almogbs@amazon.com \
--cc=amitlavi@amazon.com \
--cc=devicetree@vger.kernel.org \
--cc=dwmw@amazon.co.uk \
--cc=farbere@amazon.com \
--cc=hanochu@amazon.com \
--cc=hhhawa@amazon.com \
--cc=itamark@amazon.com \
--cc=jdelvare@suse.com \
--cc=jonnyc@amazon.com \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=mark.rutland@arm.com \
--cc=ronenk@amazon.com \
--cc=rtanwar@maxlinear.com \
--cc=shellykz@amazon.com \
--cc=shorer@amazon.com \
--cc=talel@amazon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).