From: Rob Herring <robh@kernel.org>
To: wei.fang@nxp.com
Cc: andrew@lunn.ch, hkallweit1@gmail.com, linux@armlinux.org.uk,
davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com, krzysztof.kozlowski+dt@linaro.org,
f.fainelli@gmail.com, netdev@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH V3 net 1/2] dt-bindings: net: ar803x: add disable-hibernation-mode propetry
Date: Thu, 18 Aug 2022 10:35:27 -0600 [thread overview]
Message-ID: <20220818163527.GB1978870-robh@kernel.org> (raw)
In-Reply-To: <20220818030054.1010660-2-wei.fang@nxp.com>
On Thu, Aug 18, 2022 at 11:00:53AM +0800, wei.fang@nxp.com wrote:
> From: Wei Fang <wei.fang@nxp.com>
>
> The hibernation mode of Atheros AR803x PHYs defaults to be
> enabled after hardware reset. When the cable is unplugged,
> the PHY will enter hibernation mode after about 10 seconds
> and the PHY clocks will be stopped to save power.
> However, some MACs need the phy output clock for proper
> functioning of their logic. For instance, stmmac needs the
> RX_CLK of PHY for software reset to complete.
> Therefore, add a DT property to configure the PHY to disable
> this hardware hibernation mode.
>
> Signed-off-by: Wei Fang <wei.fang@nxp.com>
> ---
> V2 change:
> 1. Add subject prefix.
> 2. Modify the property name and description to make them clear.
> V3 change:
> According to Andrew's suggestion, remodify the description to
> make it clear.
> ---
> Documentation/devicetree/bindings/net/qca,ar803x.yaml | 8 ++++++++
> 1 file changed, 8 insertions(+)
Reviewed-by: Rob Herring <robh@kernel.org>
next prev parent reply other threads:[~2022-08-18 16:35 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-18 3:00 [PATCH V3 net 0/2] Add DT property to disable hibernation mode wei.fang
2022-08-18 3:00 ` [PATCH V3 net 1/2] dt-bindings: net: ar803x: add disable-hibernation-mode propetry wei.fang
2022-08-18 16:35 ` Rob Herring [this message]
2022-08-18 3:00 ` [PATCH V3 net 2/2] net: phy: at803x: add disable hibernation mode support wei.fang
2022-08-18 19:29 ` Andrew Lunn
2022-08-18 19:58 ` Jakub Kicinski
2022-08-18 20:28 ` Andrew Lunn
2022-08-18 23:40 ` [PATCH V3 net 0/2] Add DT property to disable hibernation mode patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220818163527.GB1978870-robh@kernel.org \
--to=robh@kernel.org \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=f.fainelli@gmail.com \
--cc=hkallweit1@gmail.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=wei.fang@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).